Date: Fri, 10 Feb 2006 10:00:38 +0100 From: Anton Berezin <tobez@FreeBSD.org> To: Tod McQuillin <devin@spamcop.net> Cc: perl@FreeBSD.org Subject: Re: ports/93122: [PATCH] www/p5-HTML-Parser: [fix build on 4.x] Message-ID: <20060210090038.GA21422@heechee.tobez.org> In-Reply-To: <20060210175230.W64085@plexi.pun-pun.prv> References: <200602100842.k1A8gkKJ065130@freefall.freebsd.org> <20060210175230.W64085@plexi.pun-pun.prv>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Feb 10, 2006 at 05:53:47PM +0900, Tod McQuillin wrote: > On Fri, 10 Feb 2006, Anton Berezin wrote: > > >Synopsis: [PATCH] www/p5-HTML-Parser: [fix build on 4.x] > > > >State-Changed-From-To: open->closed > >State-Changed-By: tobez > >State-Changed-When: Fri Feb 10 09:42:46 CET 2006 > >State-Changed-Why: > >Whoops, I fixed it independently with a slightly different patch before > >seeing your PR. Thanks anyway. > > I thought about doing it your way but I wasn't sure if accessing ->offset, > ->line, ->column would be valid if ->eof was true. But comparing with > version 3.48 I see it used to access them without checking so I guess it's > okay. Since there is no deep magic going on, and the code assumes that p_state can be accessed, I see no harm in those assignments. But I do not claim that my patch is in any way better than yours, I would have committed your version if I were to see the PR before I fixed the compilation. :-) Cheers, \Anton. -- An undefined problem has an infinite number of solutions. -- Robert A. Humphrey
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060210090038.GA21422>