From owner-svn-src-all@freebsd.org Thu Jan 18 20:39:34 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 119FAEC1C06; Thu, 18 Jan 2018 20:39:34 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-it0-f48.google.com (mail-it0-f48.google.com [209.85.214.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D4CDD7F745; Thu, 18 Jan 2018 20:39:33 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-it0-f48.google.com with SMTP id q8so15123833itb.2; Thu, 18 Jan 2018 12:39:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :from:date:message-id:subject:to:cc:content-transfer-encoding; bh=W5oZf5/0rzq/xg6ObQbN2ntjF4j7NEAu4kVJq7243BE=; b=d3onNhIPS9ErbEaiBXwhAzuDbn4tZzugjwsCvDX8s3mZHM5RRTi/epnkjsuaklhMjE 3ML0IVa2NgmAPjpUz7ixF9oMy0pk95ZhYLEY3Z5apTsU0ABkBNw8sT1tby5B6pAAirR2 xECFbBA0HL8jyKzTmfl1F5VRWpQ1XAZcckoQ9u9eLXm1F800Fdd2ce0eBfp4X5ssjLZ8 U7I5Vg28j141EjQVBi+UlT4TU2zvfPOnXhwo6jdr7tsFTKFK1Zis3EHgbm1Yp+ZvHWx/ KmaqcYn85mUBntU8l4F2wED//t5Jjd7JHvDOO86hX++/qiFWdPLp9/6C77K5xBJUcDt8 D0Dg== X-Gm-Message-State: AKwxytd30WqNq35mM3ybOQtjIamns1+GS7qoDw/XXNB1JTcyNQBlletX wUsaVpjhQlt+yziQA1u4LwWXTPUf X-Google-Smtp-Source: ACJfBouY4qvoLeGrclnKEkLSd5K+O2nG8151wKwYY0Rlg4HWd2cjMA87Vfq8tbOt2aS+R5RylP1p1w== X-Received: by 10.36.107.142 with SMTP id v136mr15273934itc.113.1516307565946; Thu, 18 Jan 2018 12:32:45 -0800 (PST) Received: from mail-io0-f173.google.com (mail-io0-f173.google.com. [209.85.223.173]) by smtp.gmail.com with ESMTPSA id b12sm4208289ioe.38.2018.01.18.12.32.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 18 Jan 2018 12:32:45 -0800 (PST) Received: by mail-io0-f173.google.com with SMTP id f34so20965646ioi.13; Thu, 18 Jan 2018 12:32:45 -0800 (PST) X-Received: by 10.107.15.89 with SMTP id x86mr8068025ioi.38.1516307564881; Thu, 18 Jan 2018 12:32:44 -0800 (PST) MIME-Version: 1.0 Reply-To: cem@freebsd.org Received: by 10.2.166.21 with HTTP; Thu, 18 Jan 2018 12:32:44 -0800 (PST) In-Reply-To: <601ee1a2-8f4e-518d-4c86-89871cd652af@vangyzen.net> References: <201712291905.vBTJ57gI072871@repo.freebsd.org> <20180117224054.GO8113@FreeBSD.org> <601ee1a2-8f4e-518d-4c86-89871cd652af@vangyzen.net> From: Conrad Meyer Date: Thu, 18 Jan 2018 12:32:44 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r327354 - head/sys/vm To: Eric van Gyzen Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Jan 2018 20:39:34 -0000 On Thu, Jan 18, 2018 at 12:01 PM, Eric van Gyzen wrote: > On 01/17/2018 16:40, Gleb Smirnoff wrote: >> Yeah, style is sacred, but is there a single person on Earth who would >> not agree that moving variables from smaller blocks to function block >> reduces readability of the code? > > I agree that it reduces the readability. Not only that, it also > encourages real bugs by allowing access to the variable when it does not > make sense. I think the right way to propose this kind of policy change is to get agreement on how style(9) should be modified =E2=80=94 not arbitrarily go against style(9) in some files. The proposed change may be somewhat contentious and it might be a good exercise to go through the FreeBSD Community Process. I might separate these two concerns: 1. Allowing local / block scoped variables 2. Allowing C99 for loop initial declarations But I could see the argument that (2) is just a boring subset of (1). Thanks, Conrad