From owner-cvs-src@FreeBSD.ORG  Mon Mar 22 14:17:06 2004
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 96F7516A4CE; Mon, 22 Mar 2004 14:17:06 -0800 (PST)
Received: from harmony.village.org (rover.bsdimp.com [204.144.255.66])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 21FD543D39; Mon, 22 Mar 2004 14:17:06 -0800 (PST)
	(envelope-from imp@bsdimp.com)
Received: from localhost (warner@rover2.village.org [10.0.0.1])
	by harmony.village.org (8.12.10/8.12.9) with ESMTP id i2MMH4kj085237;
	Mon, 22 Mar 2004 15:17:05 -0700 (MST)
	(envelope-from imp@bsdimp.com)
Date: Mon, 22 Mar 2004 15:17:05 -0700 (MST)
Message-Id: <20040322.151705.45157792.imp@bsdimp.com>
To: wpaul@FreeBSD.org
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <20040322191542.CD8DE16A4CF@hub.freebsd.org>
References: <20040322102119.P33645@root.org>
	<20040322191542.CD8DE16A4CF@hub.freebsd.org>
X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
cc: nate@root.org
Subject: Re: cvs commit: src/sys/amd64/isa atpic.c src/sys/contrib/dev/oltr
 if_oltr.c src/sys/dev/aac aac_pci.c src/sys/dev/acpic
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 22 Mar 2004 22:17:06 -0000

In message: <20040322191542.CD8DE16A4CF@hub.freebsd.org>
            wpaul@FreeBSD.org (Bill Paul) writes:
: static __inline struct resource *
: bus_alloc_resource_any(device_t dev, int type, int *rid, u_int flags)
: {
:         return (bus_alloc_resource(dev, type, rid, 0ul, ~0ul, 1, flags));
: }
: 
: Please to be explaining why this isn't a macro:
: 
: #define bus_alloc_resource_any(dev, type, rid, flags)	\
: 	bus_alloc_resource(dev, type, rid, 0ul, ~0ul, 1, flags)

Because they are the same thing, and the inline is easier to deal with
and have fewer side effects.  If you are going give Nate a hassle
about it, don't.  I told him to do it that way.  Also, your macro is
wrong in that it doesn't have enough ().

Warner