From owner-cvs-all  Sat Sep  1 15:22: 1 2001
Delivered-To: cvs-all@freebsd.org
Received: from peter3.wemm.org (c1315225-a.plstn1.sfba.home.com [24.14.150.180])
	by hub.freebsd.org (Postfix) with ESMTP
	id 78A6837B403; Sat,  1 Sep 2001 15:21:51 -0700 (PDT)
Received: from overcee.netplex.com.au (overcee.wemm.org [10.0.0.3])
	by peter3.wemm.org (8.11.0/8.11.0) with ESMTP id f81MLpM26636;
	Sat, 1 Sep 2001 15:21:51 -0700 (PDT)
	(envelope-from peter@wemm.org)
Received: from wemm.org (localhost [127.0.0.1])
	by overcee.netplex.com.au (Postfix) with ESMTP
	id 315853807; Sat,  1 Sep 2001 15:21:51 -0700 (PDT)
	(envelope-from peter@wemm.org)
X-Mailer: exmh version 2.3.1 01/18/2001 with nmh-1.0.4
To: John Baldwin <jhb@FreeBSD.org>
Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/vm vm_zeroidle.c 
In-Reply-To: <200109012016.f81KGU977142@freefall.freebsd.org> 
Date: Sat, 01 Sep 2001 15:21:51 -0700
From: Peter Wemm <peter@wemm.org>
Message-Id: <20010901222151.315853807@overcee.netplex.com.au>
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

John Baldwin wrote:
> jhb         2001/09/01 13:16:30 PDT
> 
>   Modified files:
>     sys/vm               vm_zeroidle.c 
>   Log:
>   Process priority is locked by the sched_lock, not the proc lock.
>   
>   Revision  Changes    Path
>   1.5       +3 -3      src/sys/vm/vm_zeroidle.c

Then you probably want to tweak rtprio(2) as well, where this was copied
from..

rtprio(curp, uap)
{
...
                PROC_LOCK(p);
...	
                error = rtp_to_pri(&rtp, &p->p_pri);
                break;
...
        PROC_UNLOCK(p);
        return (error);
}

Or perhaps better: put sched_lock calls into rtp_to_pri() function since
that would save all the callers of it from grabbing / releasing it themselves.
(see posix4/ksched.c kern/kern_resource.c vm/vm_zeroidle.c)

Cheers,
-Peter
--
Peter Wemm - peter@FreeBSD.org; peter@yahoo-inc.com; peter@netplex.com.au
"All of this is for nothing if we don't go to the stars" - JMS/B5


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message