From owner-svn-src-all@FreeBSD.ORG  Fri Mar  8 00:18:12 2013
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id A784E8A4;
 Fri,  8 Mar 2013 00:18:12 +0000 (UTC)
 (envelope-from john@jnielsen.net)
Received: from ns1.jnielsen.net (secure.freebsdsolutions.net [69.55.234.48])
 by mx1.freebsd.org (Postfix) with ESMTP id 8AECDD06;
 Fri,  8 Mar 2013 00:18:12 +0000 (UTC)
Received: from [192.168.2.93] (c-67-182-217-170.hsd1.ut.comcast.net
 [67.182.217.170]) (authenticated bits=0)
 by ns1.jnielsen.net (8.14.4/8.14.4) with ESMTP id r27NqU2R063968
 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT);
 Thu, 7 Mar 2013 18:52:31 -0500 (EST)
 (envelope-from john@jnielsen.net)
Content-Type: text/plain; charset=iso-8859-1
Mime-Version: 1.0 (Mac OS X Mail 6.2 \(1499\))
Subject: Re: svn commit: r247904 - head/crypto/openssh
From: John Nielsen <john@jnielsen.net>
In-Reply-To: <86txonqvbe.fsf@ds4.des.no>
Date: Thu, 7 Mar 2013 16:52:26 -0700
Content-Transfer-Encoding: quoted-printable
Message-Id: <ABDA0C8F-E62D-4857-9A08-95166141C62B@jnielsen.net>
References: <201303062322.r26NMebp009010@svn.freebsd.org>
 <20130307022835.GA1496@glenbarber.us> <51386C23.2020600@FreeBSD.org>
 <86txonqvbe.fsf@ds4.des.no>
To: =?iso-8859-1?Q?Dag-Erling_Sm=F8rgrav?= <des@des.no>
X-Mailer: Apple Mail (2.1499)
X-DCC-sonic.net-Metrics: ns1.jnielsen.net 1117; Body=7 Fuz1=7 Fuz2=7
X-Virus-Scanned: clamav-milter 0.97.5 at ns1.jnielsen.net
X-Virus-Status: Clean
Cc: src-committers@freebsd.org, Sean Bruno <seanwbruno@gmail.com>,
 svn-src-all@freebsd.org, Dimitry Andric <dim@freebsd.org>,
 Glen Barber <gjb@freebsd.org>, svn-src-head@freebsd.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 08 Mar 2013 00:18:12 -0000

On Mar 7, 2013, at 4:54 AM, Dag-Erling Sm=F8rgrav <des@des.no> wrote:

> Dimitry Andric <dim@FreeBSD.org> writes:
>> Glen Barber <gjb@FreeBSD.org> writes:
>>> This commit now causes ssh(1) to dump core.
>> Indeed, it will be the same problem that was reported many times on
>> ports@; our strnvis() is not compatible with OpenBSD's strnvis(). :(
>=20
> Thank you, and my apologies for the string of f*ups.  I am currently
> testing a patch based on Dimitry's and Sean's suggestions.
>=20
> I've been working like a dog on OpenPAM and OpenSSH the last couple of
> weeks and made a few too many assumptions...

Thanks DES. As another data point, I did basically the same thing as =
Sean yesterday before you committed r247904--undefined HAVE_STRNVIS. =
Working fine, but I don't know what all that change affects.

FreeBSD 10.0-CURRENT (STEALTH) #0 r247897M: Wed Mar  6 15:05:54 MST 2013

JN