From owner-cvs-all Mon Dec 31 1: 7:49 2001 Delivered-To: cvs-all@freebsd.org Received: from k6.locore.ca (k6.locore.ca [198.96.117.170]) by hub.freebsd.org (Postfix) with ESMTP id 11ECF37B426; Mon, 31 Dec 2001 01:07:40 -0800 (PST) Received: (from jake@localhost) by k6.locore.ca (8.11.6/8.11.6) id fBV2A3Y22831; Sun, 30 Dec 2001 21:10:03 -0500 (EST) (envelope-from jake) Date: Sun, 30 Dec 2001 21:10:02 -0500 From: Jake Burkholder To: Poul-Henning Kamp Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/i386 trap.c Message-ID: <20011230211002.C9752@locore.ca> References: <200112301943.fBUJhxB15608@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <200112301943.fBUJhxB15608@freefall.freebsd.org>; from phk@FreeBSD.org on Sun, Dec 30, 2001 at 11:43:59AM -0800 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Apparently, On Sun, Dec 30, 2001 at 11:43:59AM -0800, Poul-Henning Kamp said words to the effect of; > phk 2001/12/30 11:43:59 PST > > Modified files: > sys/i386/i386 trap.c > Log: > GC an alternate trap_pfault() which has rotted away behind an "#ifdef notyet" > since 21-Mar-95 . > > Revision Changes Path > 1.210 +0 -118 src/sys/i386/i386/trap.c This is the one that should have been used. The existing one is broken because it allows faults on user memory in kernel mode without using copy{in,out} or {f,s}uword. Apparently there is still broken kernel code that expects this to work. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message