From owner-freebsd-ports Mon Mar 29 1:51:16 1999 Delivered-To: freebsd-ports@freebsd.org Received: from stampede.cs.berkeley.edu (stampede.CS.Berkeley.EDU [128.32.45.124]) by hub.freebsd.org (Postfix) with ESMTP id 5AE5214E6C for ; Mon, 29 Mar 1999 01:51:05 -0800 (PST) (envelope-from asami@cs.berkeley.edu) Received: from silvia.hip.berkeley.edu ([207.92.173.144]) by stampede.cs.berkeley.edu (8.8.7/8.7.3) with ESMTP id BAA13923; Mon, 29 Mar 1999 01:50:50 -0800 (PST) Received: (from asami@localhost) by silvia.hip.berkeley.edu (8.9.2/8.6.9) id BAA31713; Mon, 29 Mar 1999 01:50:10 -0800 (PST) Date: Mon, 29 Mar 1999 01:50:10 -0800 (PST) Message-Id: <199903290950.BAA31713@silvia.hip.berkeley.edu> X-Authentication-Warning: silvia.hip.berkeley.edu: asami set sender to asami@cs.berkeley.edu using -f To: nbm@mithrandr.moria.org Cc: freebsd-ports@freebsd.org In-reply-to: <19990328182548.A86409@rucus.ru.ac.za> (message from Neil Blakey-Milner on Sun, 28 Mar 1999 18:25:49 +0000) Subject: Re: CVSup and Fetch From: asami@freebsd.org (Satoshi "the Wraith" Asami) References: <199903261302.IAA19553@istari.home.net> <199903261348.FAA18790@silvia.hip.berkeley.edu> <19990327152150.A57118@rucus.ru.ac.za> <199903271329.FAA22229@silvia.hip.berkeley.edu> <19990327165750.A68075@rucus.ru.ac.za> <199903280511.VAA01750@bubble.didi.com> <19990328182548.A86409@rucus.ru.ac.za> Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org * From: Neil Blakey-Milner * Well, let me just submit a PR with the patches in. Just saw it. I think it's generally a good solution to a very important problem. * The only query I have about them is whether people would prefer that * for, say, LICENSE=COPYRIGHT check ${WRKSRC}/${LICENSE} - since I'd imagine * one would only really use the license variable if it's one of the default * licenses, or a file somewhere in ${WRKSRC}. I think it's fundamentally flawed to try to dig something out of ${WRKSRC}. LICENSE files (if it exists) should be installed somewhere alongside the ports' own docs, that's why I suggested you refer to the installed location or a standard template (BSD/GPL/etc.). Also, depending on something in ${WRKSRC} will break the "package-noinstall" target. I generally don't like the idea of keeping a copy of the license in the ports tree. What's in a distfile shouldn't be in our repository. If the port has a really funky license, a warning about it can be put in pkg/DESCR as that's where people look first. * Also, I'm using -n to pkg_install, since -l and -L are being used by * other pkg_*. I don't mind either way. That's eventually Jordan's call anyway. :) Satoshi To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message