Date: Sun, 16 Dec 2007 22:20:46 -0800 From: Alfred Perlstein <alfred@freebsd.org> To: Diomidis Spinellis <dds@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/bin/mv mv.c Message-ID: <20071217062046.GE16982@elvis.mu.org> In-Reply-To: <200712161747.lBGHlYk9093518@repoman.freebsd.org> References: <200712161747.lBGHlYk9093518@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
* Diomidis Spinellis <dds@FreeBSD.org> [071216 09:47] wrote: > dds 2007-12-16 17:47:34 UTC > > FreeBSD src repository > > Modified files: > bin/mv mv.c > Log: > Eliminate gcc "variable clobbered" warnings by declaring the variables > living across the vfork as volatile. > > Noted by: kan > > Revision Changes Path > 1.48 +2 -1 src/bin/mv/mv.c I'm pretty sure that calling warn(3) under vfork() is not allowed as it can clobber stdio state. To fix this, have the parent catch a return value from the child and emit the warning. -Alfred
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20071217062046.GE16982>