From nobody Fri Jul 4 20:26:11 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bYlX53zxYz60l1c; Fri, 04 Jul 2025 20:26:13 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bYlX46Y1xz3tBr; Fri, 04 Jul 2025 20:26:12 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1751660773; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=gExnEWnwpIkwg1vLqNXj1Rxii+oQq23UFji0M6Pie4E=; b=riAfkcdp73dyccVceZwgfcpicOe6tJHRstffx3rdFyMBP5MpWTZQPomtlp2nZqdkfcGSKL 5QIFuVip9XhEG+9Uo1V5nYDyUx5a8+9s7qXCq9JsPGltbsOtB1HOGSvZ0u+59FyFj5JmPR yflSTDI1j+KDtvHFFghEuaHksWRSISJA5zONnfmQ61FfcaDH+PY2Vx+rkHf1j0/kglCF60 /YkEDKmhO6PjtyOcs60tfdT9xEMwAgk9ifRP16BRE+Q/pxIvLCceeWGOjJar6x/jpqTqJD uEnHMNR/hpmFsP3Rked7FjfPiMptWF50bIkz7bVy6bD48G519F5WauFszYc5Vw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1751660773; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=gExnEWnwpIkwg1vLqNXj1Rxii+oQq23UFji0M6Pie4E=; b=cCqkkSxogpDaATLQhv8TVpm0N+hSaj3BrhUUsA1tGco6mVkbmpM2NidcbIixMSHv64WHHO ub4MWPSjSEU1sXXZuwzr5HjPlYPzz1O2/UY7LIbT/k0ZCy6A483wzZamFrtKWrerzqx8mN 6YnletvP7pxJtlYqLv2QtQDQzFkE75HobkFEFetwcUQVGANKdKBXC8Zd+Lz3O6MLeyPxsh 1Nk+j7gOv+btM7zhV0eGoMpvW3dijuisQpS17yB1Sfq0pQ8LEtjmEYkfgb1tzWAHX3Svp7 jkoRYu60tUBpcfegbB/ij/uOVGG44x7mNl1A7gD+ho56kmYpSDhWE5XGu3Q3/g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1751660773; a=rsa-sha256; cv=none; b=t/TbHP23J3f7g0yPovRl0SB8NojRi8/7dtJUG280Ph90AzOwaoGStrP7y+qUSky2DNuqgk tmoPpVkqn/+EWTuP3xdRYgGnAdekrDIyw4P/Im7Mg6Q5ApGVcdrgq/pzDHhFx+IJvdOMyL QWIjZpMsAnA1LB5TP40MVn8t/RfsayPGZ5f+2/hav/WpXqbC/SbOZMUhln85R35jSTiqYn ZyFqR0258t2LHPtQpZ1LXgtKS0OIRIVm56RVpbtISWUwiXFef8vOCVknDIonPyPvtAxRP4 81XEZASfc+5nQR+eLA9ZE65Zd/vU0QvFTfFrtEAALagwSjFb0Mm1z95VBOG+xA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4bYlX40cYgz14y7; Fri, 04 Jul 2025 20:26:12 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 564KQBcc096935; Fri, 4 Jul 2025 20:26:11 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 564KQBvd096932; Fri, 4 Jul 2025 20:26:11 GMT (envelope-from git) Date: Fri, 4 Jul 2025 20:26:11 GMT Message-Id: <202507042026.564KQBvd096932@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Ahmad Khalifa Subject: git: ff826f8ed434 - main - gpiopps: don't use internal gpiobus function List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: vexeduxr X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: ff826f8ed434c03f9f122eee16a060472d4860d5 Auto-Submitted: auto-generated The branch main has been updated by vexeduxr: URL: https://cgit.FreeBSD.org/src/commit/?id=ff826f8ed434c03f9f122eee16a060472d4860d5 commit ff826f8ed434c03f9f122eee16a060472d4860d5 Author: Ahmad Khalifa AuthorDate: 2025-07-04 20:03:18 +0000 Commit: Ahmad Khalifa CommitDate: 2025-07-04 20:24:31 +0000 gpiopps: don't use internal gpiobus function gpiobus_release_pin is only meant to be used internally by gpiobus. Use gpio_pin_release instead. This also fixes a memory leak since gpio_pin_get_by_ofw_idx returns a malloc'd pointer, which gpio_pin_release now frees. Reviewed by: wulf, imp Approved by: imp (mentor) Differential Revision: https://reviews.freebsd.org/D50871 --- sys/dev/gpio/gpiopps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/gpio/gpiopps.c b/sys/dev/gpio/gpiopps.c index bb8afa5e062c..82620a50a798 100644 --- a/sys/dev/gpio/gpiopps.c +++ b/sys/dev/gpio/gpiopps.c @@ -160,7 +160,7 @@ gpiopps_detach(device_t dev) if (sc->ires != NULL) bus_release_resource(dev, SYS_RES_IRQ, sc->irid, sc->ires); if (sc->gpin != NULL) - gpiobus_release_pin(GPIO_GET_BUS(sc->gpin->dev), sc->gpin->pin); + gpio_pin_release(sc->gpin); return (0); }