From nobody Thu Jan 15 14:18:57 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dsQ8K6QXnz6P2b7 for ; Thu, 15 Jan 2026 14:18:57 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dsQ8K4VX4z4QR7 for ; Thu, 15 Jan 2026 14:18:57 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1768486737; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=picccOrhR3X2iwBJGKA+wS+CJVpYX/iKmuRsz+DFtVA=; b=cZH1hpYZNrC0wA3RTZVtSv1gfnJuym0ibt9O4+XYAVByrFQytP4pPLlY3+1DUDGmKoVo7x k4IQDVG9Sk48Q6sJHwO7mkFfiBKxAx+cTa0CqeM14KyFYKacQEwjHB6AjPUv7yDLJ7alFr 2f4B+vXCMFG0CUXFXdNX8gT5bBJSvDSWcgnlzPrFBfq61Zd9j0u+HyURIGO5nFvwsR1vI/ dp4wUtal0SqpqAKCARL2fM8JthNTTUTZ4wbxMT377YrvgJF0NPGyXlgXu66pF1AmBKEKMj 7yZjypuDCBjbyW/G0JaS5HkFyGdHcsYMZrsBRC84KgkQXmwQzJuUuPTtI7lK5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1768486737; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=picccOrhR3X2iwBJGKA+wS+CJVpYX/iKmuRsz+DFtVA=; b=qwrapC9AFIHSPams4RijOegLQJlhdIk7MnOZHCoz3AhW89Q4wBte7TArJTQ6XoBEUmd8y9 aSQjDpM4bGW+2tawW4MGLS56zE1Al1jHqL9tNOCmlLLHthnIxuqiCaddv6om0Me1pJtfaB 88EvKEqbNS6trwYHeKo+oFvFpuJ8fQctG0Me5NLoYOeswPH4fp1atJPXxoOYrY3d3lHAF0 StlEYkkgFE4pTlwSqtPLRp/M1YyTbmpW4CxwdgNm3dhqRGAZ5HiqUUzR2PWwyeg4HSo/ps tJSRD4hsJBkcAZzhbWfasg5hixUCKuCRgGcwSj9kPVZe6hJuh3drRNbsM6YF7Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1768486737; a=rsa-sha256; cv=none; b=CQ1gvBl5ue0mdB+2IAKxmId5iAwGuJYzu+C/Lck5BLOSVy4SkRctqNiDAWfsoDuelizJiu A9aUIWf2jFvSkqT1Fv0OUdzgPpeMGmwOzpJOIW04SzUd5cqZWFmPCvAHR70saVPDe2QIvz bdkpi3iPzw4ni3sQdFv7OV+QUTHzLFl0DM8DT5lodC2X9InEeNt8Uk/9/+2GncFpNFqXzY N0s3m/kDiLvGrmSzWrbXSgaLs5rqIzEqUfwqvVo5Os5k16ufqE5VJbztm8F3YrFcnYvids RGF7R9lHzVuKePeCg/+UfafY159clRweKLLBkf/K/hUATV+o/1yoF+k/m9sLOg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4dsQ8K3vZwzXjj for ; Thu, 15 Jan 2026 14:18:57 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id f713 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 15 Jan 2026 14:18:57 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: aa1eb6233890 - main - linuxkpi: Avoid a potential null pointer dereference in an error path List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: aa1eb623389008c95b897976f4d28a7fe0acd93c Auto-Submitted: auto-generated Date: Thu, 15 Jan 2026 14:18:57 +0000 Message-Id: <6968f751.f713.1a206b20@gitrepo.freebsd.org> The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=aa1eb623389008c95b897976f4d28a7fe0acd93c commit aa1eb623389008c95b897976f4d28a7fe0acd93c Author: Mark Johnston AuthorDate: 2026-01-15 13:51:17 +0000 Commit: Mark Johnston CommitDate: 2026-01-15 13:51:17 +0000 linuxkpi: Avoid a potential null pointer dereference in an error path Reported by: Kevin Day Reviewed by: bz, emaste MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D54672 --- sys/compat/linuxkpi/common/src/linux_firmware.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sys/compat/linuxkpi/common/src/linux_firmware.c b/sys/compat/linuxkpi/common/src/linux_firmware.c index 12658df5ce83..0c6d855501ef 100644 --- a/sys/compat/linuxkpi/common/src/linux_firmware.c +++ b/sys/compat/linuxkpi/common/src/linux_firmware.c @@ -66,7 +66,8 @@ _linuxkpi_request_firmware(const char *fw_name, const struct linuxkpi_firmware * uint32_t flags; if (fw_name == NULL || fw == NULL || dev == NULL) { - *fw = NULL; + if (fw != NULL) + *fw = NULL; return (-EINVAL); }