From owner-freebsd-current@freebsd.org Tue Aug 18 13:37:53 2020 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 1AD313BC745 for ; Tue, 18 Aug 2020 13:37:53 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 4BWBmw5Xwcz44mf for ; Tue, 18 Aug 2020 13:37:52 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: by mailman.nyi.freebsd.org (Postfix) id BE4133BC744; Tue, 18 Aug 2020 13:37:52 +0000 (UTC) Delivered-To: current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id BE0E13BBFF7 for ; Tue, 18 Aug 2020 13:37:52 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BWBmw4YG2z44tt for ; Tue, 18 Aug 2020 13:37:52 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: by mail-wr1-x443.google.com with SMTP id r4so18273775wrx.9 for ; Tue, 18 Aug 2020 06:37:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=E8t3ancdYw185rzyN7TDxVEPNZJSPW2bf4W66AS2Jk8=; b=rMKrVrXgeja58uZqj0x1D294H+9VcxA4RDVZbQOvG3UPu0k/md7qJqq7p71RT2kbbs Njcy5WlzEBRVFJ2b9kh4B2Igr2da+WDX//TT9SnB3k7uskqGTOkBnXoolgCHADrHZLdX eHVTRYnocOEYEKTez57rWRqBtSAmgbmD/5tCXOriVzy3KAo1KC9pefnVPr6g8XXzMyXF XUM3OAuXAjdfrpWe9exi08xt5RDEC4nnjmzL8ky/hEU8W6loYfT4XOdWAWc9u7SMG4W8 wVgzhEEXzfrZgS6cRRGAtoCRHJrhCYSM5PcbEz0LwvDvo06l5CWXzCwU8JP4ixCddS9w KUVQ== X-Gm-Message-State: AOAM5336XbHI9y6csCd5OCDKZToeSMMR9rmtlrJ62T1+N1373wgMPglh 7Wz907aWGRmkRCPqlFRzfUeP4vi8oNHliReC+zasNe4N X-Google-Smtp-Source: ABdhPJwYU+GLjDFu03lploNWNDAlSx+XWlIR5TxG1i81jO/ZORv3zOkksYNshZ4mQv3MBeH1p/laZET1hb1JJqygKlg= X-Received: by 2002:adf:e94c:: with SMTP id m12mr20355474wrn.109.1597757871123; Tue, 18 Aug 2020 06:37:51 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a5d:614c:0:0:0:0:0 with HTTP; Tue, 18 Aug 2020 06:37:50 -0700 (PDT) In-Reply-To: <20200818132902.GQ1394@albert.catwhisker.org> References: <20200818124419.GO1394@albert.catwhisker.org> <20200818125825.GP1394@albert.catwhisker.org> <20200818132902.GQ1394@albert.catwhisker.org> From: Mateusz Guzik Date: Tue, 18 Aug 2020 15:37:50 +0200 Message-ID: Subject: Re: "panic: malloc(M_WAITOK) in non-sleepable context" after r364296 -> r364341 To: current@freebsd.org, Mateusz Guzik Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4BWBmw4YG2z44tt X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Aug 2020 13:37:53 -0000 So the previous patch should just print a warning. Does this take care of the problem in general? I don't have means to test the patch. diff --git a/sys/cam/scsi/scsi_pass.c b/sys/cam/scsi/scsi_pass.c index b299fbddd84..c6d6a5da403 100644 --- a/sys/cam/scsi/scsi_pass.c +++ b/sys/cam/scsi/scsi_pass.c @@ -652,6 +652,7 @@ passregister(struct cam_periph *periph, void *arg) args.mda_gid = GID_OPERATOR; args.mda_mode = 0600; args.mda_si_drv1 = periph; + args.mda_flags = MAKEDEV_NOWAIT; error = make_dev_s(&args, &softc->dev, "%s%d", periph->periph_name, periph->unit_number); if (error != 0) { On 8/18/20, David Wolfskill wrote: > On Tue, Aug 18, 2020 at 03:24:52PM +0200, Mateusz Guzik wrote: >> Try this: >> [replacing new KASSERT() with WITNESS_WARN()...] >> .... > > Thanks; on it. Should take care of it, I think. > > Peace, > david > -- > David H. Wolfskill david@catwhisker.org > Donald Trump is either ignorant of how to govern or is refusing to do so. > > See http://www.catwhisker.org/~david/publickey.gpg for my public key. > -- Mateusz Guzik