Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 8 Aug 2018 16:29:29 -0400
From:      Ryan Steinmetz <zi@freebsd.org>
To:        Adam Weinberger <adamw@adamw.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r476670 - in head/devel: . rubygem-solve
Message-ID:  <20180808202929.GA63276@exodus.zi0r.com>
In-Reply-To: <CAP7rwciJj9U0TOEvnwSCc2hCWh_NF44pPjHfmQRu8MGCYq24AA@mail.gmail.com>
References:  <201808081953.w78Jr68X078029@repo.freebsd.org> <CAP7rwciJj9U0TOEvnwSCc2hCWh_NF44pPjHfmQRu8MGCYq24AA@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help

On (08/08/18 14:17), Adam Weinberger wrote:
>On Wed, Aug 8, 2018 at 1:53 PM Ryan Steinmetz <zi@freebsd.org> wrote:
>> +COMMENT=       A ruby version constraint solver
>>
>>
>> Added: head/devel/rubygem-solve/pkg-descr
>> ==============================================================================
>> --- /dev/null   00:00:00 1970   (empty, because file is newly added)
>> +++ head/devel/rubygem-solve/pkg-descr  Wed Aug  8 19:53:06 2018        (r476670)
>> @@ -0,0 +1,3 @@
>> +A Ruby version constraint solver.
>> +
>> +WWW: https://rubygems.org/gems/solve
>>
>
>Ryan,
>
>You've just added a number of ports with uninformative pkg-descrs, and
>unhelpful COMMENT strings. These aren't merely formalities. Users
>should be able to read the pkg-descr and understand if it's the right
>package for them, and COMMENT is the first target for searches.
>Please, go back over them and, at the very least, expand the pkg-descr
>files with more information. As a general rule, pkg-descr should NEVER
>be the same text as the COMMENT.

Adam,

These are the description strings from authors of the code.  They came 
from either rubygems.org and/or the gem source repository.  For example, 
in the case of rubygem-solve:

https://rubygems.org/gems/solve

https://github.com/berkshelf/solve

If you have any specific things you would like to see added to any of 
the individual ports, please let me know.

Thanks,
-r

>
># Adam
>
>
>--
>Adam Weinberger
>adamw@adamw.org
>https://www.adamw.org

-- 
Ryan Steinmetz
PGP: 9079 51A3 34EF 0CD4 F228  EDC6 1EF8 BA6B D028 46D7



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180808202929.GA63276>