From owner-svn-src-head@freebsd.org Thu Aug 16 18:35:01 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 29E53107246E; Thu, 16 Aug 2018 18:35:01 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-lf1-x143.google.com (mail-lf1-x143.google.com [IPv6:2a00:1450:4864:20::143]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 803647223B; Thu, 16 Aug 2018 18:35:00 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-lf1-x143.google.com with SMTP id l16-v6so4105399lfc.13; Thu, 16 Aug 2018 11:35:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=Uedel5gr/DP1qKFM3FvlFqr1swpDrElh8Wg4G6o2zZo=; b=LtG1Wva5BtR7AnG405DFF96IPwFkpwYAhcqQKhywMHzuioLCCj3hZE4WHcfvbjrqSs 2AfXBZGCKhMkL45cw+i8h5PQW9/uY+lCRnMmRhmCw0p9sByOwyeZ+9U8T2VRitKvXVb/ yXIwRlyrVrqzXTLwe1zg/0ZQgT/UsWEXTFjACVGaleHfGMhN+WsHOLv+T8wayflSnPbx qWEgl5dLmUHRc8262B1BW3PkP0riAyiA4X0ehrGrkVuo/uvgkv7gI2k5Ib0Qagqupdia +OXDSrblAnqFJhOfzarbu5SGOpwQ4nHs/gagysc4DQDYNbZqBIyR+cW5yt39+Tij6gWi REow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=Uedel5gr/DP1qKFM3FvlFqr1swpDrElh8Wg4G6o2zZo=; b=rsyLkcfDuIGOEiGyQS3A8aQz5/a4+yobRkjRHZQ7F8/2fDGfbs/yZNqwvz584uJQhu +h2QQDwDaaDoQn/KlbY4n9bKjlb0zjnJ1iVdydOJvCzev7ni+k+JwNyiER9Ruk9Xqvl4 JSvQ/qpF7qpcDg2HnZNTKmMjZWbMDiiWWlTVRS4DvnzQcLvFlviFByjnTLDK2uIAVrMj XcKffkOy2Ggg1jCK1/OQ1FqKJd/vOafgTJG7HZL0hAnUE3PIUk6os2EmuTxmXKd7NCC7 Fxfz2OudvZLsDQz/XUxmbbt0xT6IQ3+/ferfGCwFXJ2rKXDkeUiYZ0GEgnwysbCVh1Vy Vs/g== X-Gm-Message-State: AOUpUlEGfQavbsY6IYEh89k7AXdcS3sc8mY95xP1q6wLF0MGjfcErHOq Cin7sNjW+f6Bmn7dxG1OwPCC9vOAppbbQb/vuNl2P1zh X-Google-Smtp-Source: AA+uWPx+veKkyxr9lU5GjuqvQt2urOQZUV8/FkAOK8OGbnWwTUGX8zVtYlr4iVe03ZrIZPIcP4Zhe3fbhkAcTwga/Ws= X-Received: by 2002:a19:1366:: with SMTP id j99-v6mr21118738lfi.21.1534444498867; Thu, 16 Aug 2018 11:34:58 -0700 (PDT) MIME-Version: 1.0 Sender: asomers@gmail.com Received: by 2002:ab3:7851:0:0:0:0:0 with HTTP; Thu, 16 Aug 2018 11:34:58 -0700 (PDT) In-Reply-To: <201808140754.w7E7sEFs018313@repo.freebsd.org> References: <201808140754.w7E7sEFs018313@repo.freebsd.org> From: Alan Somers Date: Thu, 16 Aug 2018 12:34:58 -0600 X-Google-Sender-Auth: QEpJIPzogrkHvGfzKQtwZxQgyAA Message-ID: Subject: Re: svn commit: r337736 - in head/sys: netinet netinet6 To: "Andrey V. Elsukov" Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.27 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Aug 2018 18:35:01 -0000 On Tue, Aug 14, 2018 at 1:54 AM, Andrey V. Elsukov wrote: > Author: ae > Date: Tue Aug 14 07:54:14 2018 > New Revision: 337736 > URL: https://svnweb.freebsd.org/changeset/base/337736 > > Log: > Restore ability to send ICMP and ICMPv6 redirects. > > It was lost when tryforward appeared. Now ip[6]_tryforward will be > enabled > only when sending redirects for corresponding IP version is disabled via > sysctl. Otherwise will be used default forwarding function. > > PR: 221137 > Submitted by: mckay@ > MFC after: 2 weeks > > Modified: > head/sys/netinet/ip_input.c > head/sys/netinet6/ip6_input.c > This change broke the sys/netipsec/tunnel tests. I don't know if it's a limitation of the tests, or a genuine kernel bug, but I bisected the regression down to this change. Can you please fix it? https://ci.freebsd.org/job/FreeBSD-head-amd64-test/8630/testReport/sys.netipsec.tunnel/empty/v4/