From owner-freebsd-ports-bugs@FreeBSD.ORG Sat May 26 04:20:05 2007 Return-Path: X-Original-To: freebsd-ports-bugs@hub.freebsd.org Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 0919116A46B for ; Sat, 26 May 2007 04:20:05 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [69.147.83.40]) by mx1.freebsd.org (Postfix) with ESMTP id DBB3013C46A for ; Sat, 26 May 2007 04:20:04 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id l4Q4K43J062032 for ; Sat, 26 May 2007 04:20:04 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id l4Q4K4Xp062028; Sat, 26 May 2007 04:20:04 GMT (envelope-from gnats) Resent-Date: Sat, 26 May 2007 04:20:04 GMT Resent-Message-Id: <200705260420.l4Q4K4Xp062028@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Eygene Ryabinkin Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id B8E4716A400 for ; Sat, 26 May 2007 04:10:45 +0000 (UTC) (envelope-from rea-fbsd@codelabs.ru) Received: from pobox.codelabs.ru (pobox.codelabs.ru [144.206.177.45]) by mx1.freebsd.org (Postfix) with ESMTP id 6CD7113C468 for ; Sat, 26 May 2007 04:10:43 +0000 (UTC) (envelope-from rea-fbsd@codelabs.ru) Received: from twilight.localdomain (ppp8.mbslab.kiae.ru [144.206.177.208]) by pobox.codelabs.ru with esmtps (TLSv1:AES256-SHA:256) id 1Hrnbz-0007RL-SI; Sat, 26 May 2007 08:10:40 +0400 Message-Id: <20070526041034.BFBF0412D@twilight.localdomain> Date: Sat, 26 May 2007 08:10:34 +0400 (MSD) From: Eygene Ryabinkin To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: mi@FreeBSD.org, jose@diasfernandes.pt Subject: ports/113020: bad OPTIONS syntax and checks in ports/textproc/htmldoc X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Eygene Ryabinkin List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 May 2007 04:20:05 -0000 >Number: 113020 >Category: ports >Synopsis: bad OPTIONS syntax and checks in ports/textproc/htmldoc >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sat May 26 04:20:03 GMT 2007 >Closed-Date: >Last-Modified: >Originator: Eygene Ryabinkin >Release: FreeBSD 7.0-CURRENT i386 >Organization: Code Labs >Environment: System: FreeBSD XXX 7.0-CURRENT FreeBSD 7.0-CURRENT #25: Fri May 18 17:25:48 MSD 2007 root@XXX:/usr/src/sys/i386/compile/XXX i386 >Description: * OPTIONS statements should carry 'on' or 'off'. HTMLDOCGUI was using 'no'. * One should check the WITH_/WITHOUT_ values of the opposite kind relative to what is told in the OPTIONS. For the HTMLDOCGUI='off' WITH_HTMLDOCGUI should be checked. See Porter Handbook for the explanation. >How-To-Repeat: Define BATCH=yes and compile the port. It will be built with the GUI support, but it is intended to be built without GUI by-default. >Fix: The following patch will go. May be the PORTREVISION should be bumped. diff -ur htmldoc.orig/Makefile htmldoc/Makefile --- htmldoc.orig/Makefile Sat May 26 07:20:48 2007 +++ htmldoc/Makefile Sat May 26 07:38:26 2007 @@ -19,7 +19,7 @@ LIB_DEPENDS= jpeg:${PORTSDIR}/graphics/jpeg \ png:${PORTSDIR}/graphics/png -OPTIONS= HTMLDOCGUI "Build GUI front-end" no +OPTIONS= HTMLDOCGUI "Build GUI front-end" off # .bz2 file is available since Aug 2, but we don't want to # start mirroring _in addition to_ the .gz variant. When the # vendor's release is updated again, we should switch to .bz2 @@ -48,7 +48,7 @@ .include -.if !defined(WITHOUT_HTMLDOCGUI) +.if defined(WITH_HTMLDOCGUI) LIB_DEPENDS+= fltk:${PORTSDIR}/x11-toolkits/fltk CONFIGURE_ARGS+=--enable-gui .endif >Release-Note: >Audit-Trail: >Unformatted: