From owner-freebsd-hackers@FreeBSD.ORG Thu Feb 4 16:52:04 2010 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 310B2106568D for ; Thu, 4 Feb 2010 16:52:04 +0000 (UTC) (envelope-from jhellenthal@gmail.com) Received: from mail-fx0-f225.google.com (mail-fx0-f225.google.com [209.85.220.225]) by mx1.freebsd.org (Postfix) with ESMTP id A59EA8FC26 for ; Thu, 4 Feb 2010 16:52:03 +0000 (UTC) Received: by fxm25 with SMTP id 25so709041fxm.34 for ; Thu, 04 Feb 2010 08:52:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:date:from:to:cc :subject:in-reply-to:message-id:references:user-agent :x-openpgp-key-id:x-openpgp-key-fingerprint:mime-version :content-type:content-id; bh=WbbIng1kHHd1MNRAauynKpmAe/MN4s3j2mj5nyfmi4k=; b=Sran/D/5zC1yMRV7XxZy16HGOTQHz9Rug1iRpUyWmYsU/pcMhZwxpFe74UdN/i7ZUM IybG4BRri0uWgfC7zIMkLOve3nG5D9CBjt17osRTEB3A1rdblZ2BRgndYn5A4P0MkLBT 8XU9tCHfhO82o7nF3M3WC8gpuuhJAvAdQiC34= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:x-openpgp-key-id:x-openpgp-key-fingerprint:mime-version :content-type:content-id; b=QDgYpI+GSh0S3kAHHNNmqzSZZ/7i/iBkRHfNeH6yK/WwqafRnAJj1whnsMyLCUDFPd Y0bBHysNXeQDjv2+WL1Y0inUR9V6BYRIiHS8ay+OFFSVY+YfdvYQrfnn5/BRzvAILcbh JQhtRdfZOhmvxP3Hu0V32x6cb1F+sOt5D7Yq8= Received: by 10.87.21.22 with SMTP id y22mr2559364fgi.52.1265302322523; Thu, 04 Feb 2010 08:52:02 -0800 (PST) Received: from centel.dataix.local (ppp-21.210.dialinfree.com [209.172.21.210]) by mx.google.com with ESMTPS id d6sm3441959fga.29.2010.02.04.08.51.48 (version=TLSv1/SSLv3 cipher=RC4-MD5); Thu, 04 Feb 2010 08:51:54 -0800 (PST) Sender: "J. Hellenthal" Date: Thu, 4 Feb 2010 11:51:14 -0500 From: jhell To: Eitan Adler In-Reply-To: Message-ID: References: User-Agent: Alpine 2.00 (BSF 1167 2008-08-23) X-OpenPGP-Key-Id: 0x89D8547E X-OpenPGP-Key-Fingerprint: 85EF E26B 07BB 3777 76BE B12A 9057 8789 89D8 547E MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="1091451658-1141520619-1265302016=:27763" Content-ID: Cc: FreeBSD Hackers , Jason Spiro Subject: Re: [RFC] [patch] pkill verbose option X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Feb 2010 16:52:04 -0000 This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --1091451658-1141520619-1265302016=:27763 Content-Type: TEXT/PLAIN; CHARSET=US-ASCII; FORMAT=flowed Content-ID: -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Content-ID: On Thu, 4 Feb 2010 11:01, jhell@ wrote: > > On Thu, 4 Feb 2010 05:01, eitanadlerlist@ wrote: >> This patch hijacks pgrep's -l >> > [cut] > > This particular section of the patch should probably be left out until its > worked over in a way that it does not print the info message if a process has > been found and killed already. > > if (!didAction && !pgrep) > { > printf("No matching processes belonging to you were found\n"); > } > > > Thanks for the re-patch, quick and resourceful... ;) > > The attached patch is for stable/7 and does not have the above printf for no matching processes. It also cleans up the formatting a little following the rest of the code and adds the -l flag to the usage statement. This is only the patch for pkill itself and not for the manual page. ;-) - -- jhell -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iQEcBAEBAgAGBQJLavsEAAoJEJBXh4mJ2FR+WMwH/1FQY4+FV5xLd6Lg2xgjcbG0 ptDjfr5EdIowWeE2EckcmkZGHZa6Z9WL3zcgOHBfJbsm7pchKUoAjzihlk2iW76u yBHknDs0Wysv7g0y2nA5sDmjAzzJV8xF8W7aGps+eRJYp1dSDQh9h5zRLAKqZXQ+ hmc43ZUOTYsOoMdPcHJUm48og5Q7IiVeh4B7T6PeMaFdolwW8wGwJuXjOzRw4+UH A6g+bBctFNrLIxj6eb39oxhIXoDv7unwM+JONJKJvtKWOmbVD22VVYSMeNKSOeqX 9SelPiwdBj9ulJfTuRmrpfuPw/J7CpkrIwKsifPqP3DYuKQ8qLiBO/jRJwLNkpA= =PD/9 -----END PGP SIGNATURE----- --1091451658-1141520619-1265302016=:27763 Content-Type: TEXT/PLAIN; CHARSET=US-ASCII; NAME=pkill.patch Content-Transfer-Encoding: BASE64 Content-ID: Content-Description: Content-Disposition: ATTACHMENT; FILENAME=pkill.patch SW5kZXg6IHBraWxsLmMNCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBw a2lsbC5jCShyZXZpc2lvbiAxOTM2MjcpDQorKysgcGtpbGwuYwkod29ya2lu ZyBjb3B5KQ0KQEAgLTE4Miw3ICsxODIsNyBAQA0KIAlwaWRmaWxlbG9jayA9 IDA7DQogCWV4ZWNmID0gY29yZWYgPSBfUEFUSF9ERVZOVUxMOw0KIA0KLQl3 aGlsZSAoKGNoID0gZ2V0b3B0KGFyZ2MsIGFyZ3YsICJERjpHOklMTTpOOlA6 U1U6YWQ6Zmc6aWo6bG5vczp0OnU6dngiKSkgIT0gLTEpDQorCXdoaWxlICgo Y2ggPSBnZXRvcHQoYXJnYywgYXJndiwgIkRGOkc6SUxNOk46UDpTVTphZDpm ZzppbGo6bG5vczp0OnU6dngiKSkgIT0gLTEpDQogCQlzd2l0Y2ggKGNoKSB7 DQogCQljYXNlICdEJzoNCiAJCQlkZWJ1Z19vcHQrKzsNCkBAIC0yNDUsOCAr MjQ1LDYgQEANCiAJCQljcml0ZXJpYSA9IDE7DQogCQkJYnJlYWs7DQogCQlj YXNlICdsJzoNCi0JCQlpZiAoIXBncmVwKQ0KLQkJCQl1c2FnZSgpOw0KIAkJ CWxvbmdmbXQgPSAxOw0KIAkJCWJyZWFrOw0KIAkJY2FzZSAnbic6DQpAQCAt NTI4LDEwICs1MjYsMTUgQEANCiAJLyoNCiAJICogVGFrZSB0aGUgYXBwcm9w cmlhdGUgYWN0aW9uIGZvciBlYWNoIG1hdGNoZWQgcHJvY2VzcywgaWYgYW55 Lg0KIAkgKi8NCisJaW50IGRpZEFjdGlvbiA9IDA7DQogCWZvciAoaSA9IDAs IHJ2ID0gMCwga3AgPSBwbGlzdDsgaSA8IG5wcm9jOyBpKyssIGtwKyspIHsN CiAJCWlmIChQU0tJUChrcCkpDQogCQkJY29udGludWU7DQogCQlpZiAoc2Vs ZWN0ZWRbaV0pIHsNCisJCQlpZiAobG9uZ2ZtdCkgew0KKwkJCQlkaWRBY3Rp b24gPSAxOw0KKwkJCQlwcmludGYoImtpbGwgLSVkICVkXG4iLHNpZ251bSxr cC0+a2lfcGlkKTsNCisJCQl9DQogCQkJaWYgKGludmVyc2UpDQogCQkJCWNv bnRpbnVlOw0KIAkJfSBlbHNlIGlmICghaW52ZXJzZSkNCkBAIC01NTAsNyAr NTUzLDcgQEANCiAJaWYgKHBncmVwKQ0KIAkJdXN0ciA9ICJbLUxTZmlsbm92 eF0gWy1kIGRlbGltXSI7DQogCWVsc2UNCi0JCXVzdHIgPSAiWy1zaWduYWxd IFstSUxmaW5vdnhdIjsNCisJCXVzdHIgPSAiWy1zaWduYWxdIFstSUxmaWxu b3Z4XSI7DQogDQogCWZwcmludGYoc3RkZXJyLA0KIAkJInVzYWdlOiAlcyAl cyBbLUYgcGlkZmlsZV0gWy1HIGdpZF0gWy1NIGNvcmVdIFstTiBzeXN0ZW1d XG4iDQo= --1091451658-1141520619-1265302016=:27763--