From owner-freebsd-stable@FreeBSD.ORG Thu Sep 17 08:55:18 2009 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5F3241065672 for ; Thu, 17 Sep 2009 08:55:18 +0000 (UTC) (envelope-from smithi@nimnet.asn.au) Received: from sola.nimnet.asn.au (paqi.nimnet.asn.au [115.70.110.159]) by mx1.freebsd.org (Postfix) with ESMTP id C7EF28FC17 for ; Thu, 17 Sep 2009 08:55:17 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by sola.nimnet.asn.au (8.14.2/8.14.2) with ESMTP id n8H8tBt8098079; Thu, 17 Sep 2009 18:55:14 +1000 (EST) (envelope-from smithi@nimnet.asn.au) Date: Thu, 17 Sep 2009 18:55:11 +1000 (EST) From: Ian Smith To: Doug Barton In-Reply-To: <4AB17CB9.3040704@FreeBSD.org> Message-ID: <20090917183525.O73400@sola.nimnet.asn.au> References: <4AAFED75.4020502@andric.com> <4AB099BB.9040603@therek.net> <4AB17CB9.3040704@FreeBSD.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: freebsd-stable@freebsd.org, Oliver Fromme , Cezary Morga Subject: Re: 8.0 rc.d scripts less verbose? X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Sep 2009 08:55:18 -0000 On Wed, 16 Sep 2009, Doug Barton wrote: > Cezary Morga wrote: > > Dimitry Andric pisze: > >> Index: etc/rc.subr > >> =================================================================== > >> --- etc/rc.subr (revision 196888) > >> +++ etc/rc.subr (working copy) > >> @@ -680,7 +680,7 @@ run_rc_command() > >> > >> # setup the full command to run > >> # > >> - [ -z "${rc_quiet}" ] && echo "Starting ${name}." > >> + echo "Starting ${name}." > >> if [ -n "$_chroot" ]; then > >> _doit="\ > >> ${_nice:+nice -n $_nice }\ > > > > Wouldn't it be easier to set rc_quiet to zero-length value, like > > rc_quiet=""? > > That actually would give off too much information because rc_quiet > suppresses error messages about scripts that don't currently have > _enable set to anything useful. That's arguably a bug, but it's a bug > that we've come to depend on. > > The attached patch adds a knob you can set in rc.conf to see "Starting > foo" messages again. If people find this useful I'll be glad to commit > it. I'm also open to suggestions for a better name. >From your patch: - [ -z "${rc_quiet}" ] && echo "Starting ${name}." + [ -z "${rc_quiet}" -o -n "${rc_starting}" ] && echo "Starting ${name}." Presumably this variable would go in /etc/defaults/rc.conf .. seems that all the other rc.conf binary choices are either set "YES" or "NO" rather than something or empty, so perhaps more consistent with that might be: [ -z "${rc_quiet}" -o "${rc_starting}" = "YES" ] && echo "Starting ${name}." As for name, not fussed, but maybe rc_startmsgs maybe more indicative? Also, I agree with Oliver; YES should probably be the default (POLA) so folks annoyed by 'too much information' in console.log can disable it. HTH, Ian