From nobody Fri Dec 31 22:05:39 2021 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 721BD192B198 for ; Fri, 31 Dec 2021 22:05:57 +0000 (UTC) (envelope-from ericturgeon.bsd@gmail.com) Received: from mail-vk1-xa33.google.com (mail-vk1-xa33.google.com [IPv6:2607:f8b0:4864:20::a33]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JQfNP2WSwz4f0P; Fri, 31 Dec 2021 22:05:57 +0000 (UTC) (envelope-from ericturgeon.bsd@gmail.com) Received: by mail-vk1-xa33.google.com with SMTP id u198so15731770vkb.13; Fri, 31 Dec 2021 14:05:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xJpj2IvAAaR9PC4N6TdH/o0y+mi9v08hxV6DV6tLTAo=; b=K4URDU0+/q/2HuGKEE8/gj6m9JokJuB0az+NPk/sXzx5M1yZbwr1oe5g092OYnaYiU Uk/j9t+HKIWMJHeBfcZI4ZtJHoTuNC+BJA1O3H3OS3/TpOA7KpYWfMWto+cGEYijz20j UTyXj+IpLb8anN+tx51AEGEpula2ea/Pt5V5uHFOiIU4hswQBizcgNIrETv+7LYeyitY KwMft6OxNBwRf3GLixd8ny879IBEWRtGaaPHienxKLRc0EQlaZv7SSy+SsK64OwzzACx x+quxEiPGYiPVIQK5Ava0LU5+MQfxNXrwWM09p+38uNtsNYQO4kR9yi/u/m6xRISfeM6 n7hA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xJpj2IvAAaR9PC4N6TdH/o0y+mi9v08hxV6DV6tLTAo=; b=h0Aj5DvF8lc1XinH2QCJAjvR7iDZauiE4BNioqFiC3PxfmooXTDF3m5DC9qgUsLld8 voSdaEkCJOOq8hQ35lDylBrn6UfNmTLK8KtCE+xYZEpztrLKnlx5ksSAJUAwD8dGwxqC hOZp16S+JrZYyHehK4Z/ECD6iwXY6sP0TiBGSqHkeNwwiN6444766UOaPPF7+xBKfWRe 0D+uW9NdkISKamI9zoc83X1IBzxnnZ2FHPtK6sL7jWSh+Rj/LjLa9ba0zSJK0nQxIdC9 YbNLF28pd+YUtj7lohpPOYB3BQlgolA1rmYnJ0DZfM572xGFbeAaOkZivAm4l+BStKfJ tv4A== X-Gm-Message-State: AOAM533fdeGxqURWeY3gV1dBDpWz8Y7rqL1Yo9cn5coNUa5kBX4zdC9/ IJyHKNGhTdvwZZxAa4qsNibziAH0HDc7LQ0jmJI= X-Google-Smtp-Source: ABdhPJwgsJtmQwgf3cl2XbTQ/D8q04mMj0v9A4rJ9sk8SddCSS5IPngfrUOW693lL0SW7TfUfFkAnignSA6W64x8OnE= X-Received: by 2002:a05:6122:2001:: with SMTP id l1mr12635847vkd.16.1640988350735; Fri, 31 Dec 2021 14:05:50 -0800 (PST) List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 References: <20211230110857.1c0ac0e19e8206cb64a040d7@dec.sakura.ne.jp> <202112300342.1BU3gPt9003879@slippy.cwsent.com> <202112301701.1BUH1dji009235@slippy.cwsent.com> <202112310402.1BV42p3C036429@slippy.cwsent.com> <20211231162719.3f7f909008d3cbacefe124c0@dec.sakura.ne.jp> In-Reply-To: <20211231162719.3f7f909008d3cbacefe124c0@dec.sakura.ne.jp> From: Eric Turgeon Date: Fri, 31 Dec 2021 18:05:39 -0400 Message-ID: Subject: Re: git: f3caf742108b - main - x11/mate-screensaver: Fix PAM build To: Tomoaki AOKI Cc: Cy Schubert , dev-commits-ports-main@freebsd.org, Cy Schubert Content-Type: multipart/alternative; boundary="000000000000b9e8f805d4785faf" X-Rspamd-Queue-Id: 4JQfNP2WSwz4f0P X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[] X-Spam: Yes X-ThisMailContainsUnwantedMimeParts: N --000000000000b9e8f805d4785faf Content-Type: text/plain; charset="UTF-8" Ok, I made a fork of mate-desktop/mate-screensaver and reverted https://github.com/mate-desktop/mate-screensaver/commit/ec813dffa59d30fa30ab3e4932095337b5813132#diff-aeac78bee2093aadfdb2899062cd27c459b83549bbb843417bf3693ca58673a2 and https://github.com/mate-desktop/mate-screensaver/commit/ec813dffa59d30fa30ab3e4932095337b5813132#diff-3ff2c5a579bd5353be616133d0eef15a260c9f44f9064a5a36b58cb7c4b1d989 . I did run sh autogen.sh --with-console-kit=yes --with-systemd=no --enable-authentication-scheme=helper --with-passwd-helper=/usr/local/bin/pam_helper, gmake and sudo gmake install. Everything is back to normal now I am trying to find if src/gs-auth-helper.c or src/gs-auth-helper.c is the problem. *Eric Turgeon* On Fri, Dec 31, 2021 at 3:27 AM Tomoaki AOKI wrote: > That's what I pointed as suspicious (but couldn't track where the > problem lives in) on Bug 260811. > > If introducing missing header(s) is suffice, and any open source > software having it allows partial use, creating header-only port > deriving from it can be an option. > > For example, electron* ports are derived from chromium. > > > On Fri, 31 Dec 2021 00:27:34 -0400 > Eric Turgeon wrote: > > > It is most likely this commit > > > https://github.com/mate-desktop/mate-screensaver/commit/ed6e6065bf0e85b64317b5a34b9f7a36a0c839a6 > > . > > > > *Eric Turgeon* > > > > > > On Fri, Dec 31, 2021 at 12:02 AM Cy Schubert > > wrote: > > > > > I can confirm PAM authentication is broken by this new release. Like > > > layers > > > of an onion, this problem will need to be investigated further. I doubt > > > simply adding additional macros would resolve the problem. The reason I > > > believe this is that the macros are likely a small part of something > > > larger. > > > > > > Having said that, ports/security/pecl-pam includes a copy of the file > with > > > a reference to the URL from whence it came (suggesting a GPL violation > in > > > the ports tree). > > > > > > I think the path forward is to engage our upstream. Then look at a > number > > > of short-term or longer-term options to get us over this hump. > > > > > > If upstream is open to fixing the problem temporarily marking the PAM > > > option broken or temporarily rolling back the upgrade may suffice. > > > > > > Alternatively, if upstream isn't open to remediation we may want to > > > consider importing Linux-pam on github as a port. Be aware that > multiple > > > PAM stacks can coexist however similar problems we have with three > KRB5s > > > will require getting linking just right. This option does have the > > > advantage of supporting other software written for Linux-PAM (instead > of > > > OpenPAM or Solaris PAM -- FreeBSD PAM is based on OpenPAM). > > > > > > Another alternative is dump mate-screensaver for xscreensaver. IIRC > > > xscreensaver was the original screen saver for Gnome back in the day. > (IMO > > > xscreensaver is superior to the Gnome and mate screensavers, though > this > > > is > > > just a personal preference. I've also used it to replace the CDE > > > screensaver on a per-user basis.) Anyhow, just a thought for anyone. > > > > > > Until we look at the code we won't have a good idea of what kind of > work > > > is > > > involved. > > > > > > Strategically a Linux-PAM port might be something we might want to > think > > > about long term. Tactically, any of the other options could work. > > > > > > > > > -- > > > Cheers, > > > Cy Schubert > > > FreeBSD UNIX: Web: https://FreeBSD.org > > > NTP: Web: https://nwtime.org > > > > > > The need of the many outweighs the greed of the few. > > > > > > > > > In message <202112301701.1BUH1dji009235@slippy.cwsent.com>, Cy > Schubert > > > writes: > > > > No. It's a bunch of inline macros that perform memory and other > > > functions. > > > > All could have been made to be actual functions. On my Fedora VM at > $JOB > > > > they're part of the pam-devel.rpm. > > > > > > > > > > > > -- > > > > Cheers, > > > > Cy Schubert > > > > FreeBSD UNIX: Web: https://FreeBSD.org > > > > NTP: Web: https://nwtime.org > > > > > > > > The need of the many outweighs the greed of the few. > > > > > > > > > > > > In message > > > > > > om> > > > > , Eric Turgeon writes: > > > > > --00000000000063b43405d45dfc6d > > > > > Content-Type: text/plain; charset="UTF-8" > > > > > > > > > > Do we have an equivalent of security/_pam_macros.h? > > > > > > > > > > *Eric Turgeon* > > > > > > > > > > > > > > > On Wed, Dec 29, 2021 at 11:42 PM Cy Schubert < > > > Cy.Schubert@cschubert.com> > > > > > wrote: > > > > > > > > > > > This commit only fixed a compile time error, include file > > > > > > security/_pam_macros.h not found (discovered by my poudriere > build). > > > > > > security/_pam_macros is an include file found only on some > distros of > > > > > > Linux, a Linuxism. Try it without PAM enabled; the file not found > > > error > > > > > > may > > > > > > just be the beginning of a multitude of PAM issues. > > > > > > > > > > > > I'll try to look at it over the next couple days. > > > > > > > > > > > > > > > > > > -- > > > > > > Cheers, > > > > > > Cy Schubert > > > > > > FreeBSD UNIX: Web: https://FreeBSD.org > > > > > > NTP: Web: https://nwtime.org > > > > > > > > > > > > The need of the many outweighs the greed of the few. > > > > > > > > > > > > > > > > > > In message < > 20211230110857.1c0ac0e19e8206cb64a040d7@dec.sakura.ne.jp > > > >, > > > > > > Tomoaki > > > > > > AOKI writes: > > > > > > > Hi. > > > > > > > Wondered whih commit to comment but decided to latest. > > > > > > > mate-screensaver no longer opens login panel after upgrading > from > > > > > > > 1.26.0 to 1.26.1. > > > > > > > > > > > > > > Created Bug 260811 [1]. > > > > > > > > > > > > > > [1] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=260811 > > > > > > > > > > > > > > > > > > > > > > The branch main has been updated by cy: > > > > > > > > > > > > > > > > URL: > > > > > > > > > > > > > > > > > https://cgit.FreeBSD.org/ports/commit/?id=f3caf742108bb552724d4c4dae74b28 > > > > ea > > > > > 26 > > > > > > > 6a6a3 > > > > > > > > > > > > > > > > commit f3caf742108bb552724d4c4dae74b28ea266a6a3 > > > > > > > > Author: Cy Schubert > > > > > > > > AuthorDate: 2021-12-29 03:12:39 +0000 > > > > > > > > Commit: Cy Schubert > > > > > > > > CommitDate: 2021-12-29 03:12:39 +0000 > > > > > > > > > > > > > > > > x11/mate-screensaver: Fix PAM build > > > > > > > > > > > > > > > > Fix build when PAM enabled; is a > > > Linuxis > > > > m. > > > > > > > > --- > > > > > > > > x11/mate-screensaver/files/patch-helper_pam-helper.c | 10 > > > ++++++++++ > > > > > > > > 1 file changed, 10 insertions(+) > > > > > > > > > > > > > > > > diff --git > a/x11/mate-screensaver/files/patch-helper_pam-helper.c > > > > > > > b/x11/mate-screensaver/files/patch-helper_pam-helper.c > > > > > > > > new file mode 100644 > > > > > > > > index 000000000000..605141fb0e54 > > > > > > > > --- /dev/null > > > > > > > > +++ b/x11/mate-screensaver/files/patch-helper_pam-helper.c > > > > > > > > _at__at_ -0,0 +1,10 _at__at_ > > > > > > > > +--- helper/pam-helper.c.orig 2021-11-15 > > > 14:28:47.000000000 -08 > > > > 00 > > > > > > > > ++++ helper/pam-helper.c 2021-12-28 19:09:39.501645000 > -0800 > > > > > > > > +_at__at_ -33,7 +33,6 _at__at_ > > > > > > > > + */ > > > > > > > > + > > > > > > > > + #include > > > > > > > > +-#include > > > > > > > > + > > > > > > > > + #include > > > > > > > > + #include > > > > > > > > > > > > > > -- > > > > > > > Tomoaki AOKI > > > > > > > > > > > > > > > > > > > > > > > > > > > > --00000000000063b43405d45dfc6d > > > > > Content-Type: text/html; charset="UTF-8" > > > > > Content-Transfer-Encoding: quoted-printable > > > > > > > > > >
Do we have an equivalent of > > > security/_pam_macros.h? > > > = > > > > > div>

> > class=3D"gmail_signature" dat > > > > = > > > > > a-smartmail=3D"gmail_signature">
> > dir=3D"ltr">
> > > = > > > > > >
dir=3D"ltr"> > > color= > > > > > =3D"#888888">Eric > > > Turgeon > > > = > > > > > > > > > >
> > > = > > > > > >


> > class= > > > > > =3D"gmail_quote">
On Wed, Dec > 29, > > > 2021 > > > > = > > > > > at 11:42 PM Cy Schubert < > > Cy.Schubert@cschubert.com">C > > > > = > > > > > y.Schubert@cschubert.com> wrote:
> > class=3D"gmail > > > > = > > > > > _quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid > > > rgb(204,204 > > > > = > > > > > ,204);padding-left:1ex">This commit only fixed a compile time > error, > > > includ > > > > = > > > > > e file
> > > > > security/_pam_macros.h not found (discovered by my poudriere > build). > > >
> > > > > security/_pam_macros is an include file found only on some distros > of > > >
> > > > > Linux, a Linuxism. Try it without PAM enabled; the file not found > > > error may > > > > = > > > > >
> > > > > just be the beginning of a multitude of PAM issues.
> > > > >
> > > > > I'll try to look at it over the next couple days.
> > > > >
> > > > >
> > > > > --
> > > > > Cheers,
> > > > > Cy Schubert < > > target=3D"_bla > > > > = > > > > > nk">Cy.Schubert@cschubert.com>
> > > > > FreeBSD UNIX:=C2=A0 <cy@FreeBSD.org>=C2=A0 =C2=A0Web:=C2=A0 > > > href= > > > > > =3D"https://FreeBSD.org" rel=3D"noreferrer" target=3D"_blank"> > > > https://FreeB > > > > = > > > > > SD.org
> > > > > NTP:=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0< > > cy@nwtim > > > > = > > > > > e.org" target=3D"_blank">cy@nwtime.org>=C2=A0 =C2=A0 > > > Web:=C2=A0 > > > = > > > > > ref=3D"https://nwtime.org" rel=3D"noreferrer" target=3D"_blank"> > > > https://nwt > > > > = > > > > > ime.org
> > > > >
> > > > > =C2=A0 =C2=A0 =C2=A0 =C2=A0 The need of the many outweighs the > greed > > > of the > > > > = > > > > > few.
> > > > >
> > > > >
> > > > > In message < > > 20211230110857.1c0ac0e19e8206cb64a040d7@de > > > > = > > > > > c.sakura.ne.jp" > > > target=3D"_blank">20211230110857.1c0ac0e19e8206cb64a040d7@d > > > > = > > > > > ec.sakura.ne.jp>,
> > > > > Tomoaki
> > > > > AOKI writes:
> > > > > > Hi.
> > > > > > Wondered whih commit to comment but decided to latest.
> > > > > > mate-screensaver no longer opens login panel after upgrading > > > from
> > > > > > 1.26.0 to 1.26.1.
> > > > > >
> > > > > > Created Bug 260811 [1].
> > > > > >
> > > > > > [1] > > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D260 > > > > = > > > > > 811" rel=3D"noreferrer" target=3D"_blank"> > > > https://bugs.freebsd.org/bugzilla > > > > = > > > > > /show_bug.cgi?id=3D260811
> > > > > >
> > > > > >
> > > > > > > The branch main has been updated by cy:
> > > > > > >
> > > > > > > URL:
> > > > > > > > https://cgit.FreeBSD.org/ports/commit/?id=3Df3caf742108bb55 > > > > = > > > > > 2724d4c4dae74b28ea26" rel=3D"noreferrer" target=3D"_blank"> > > > https://cgit.Fre > > > > = > > > > > > eBSD.org/ports/commit/?id=3Df3caf742108bb552724d4c4dae74b28ea26
> > > > > > 6a6a3
> > > > > > >
> > > > > > > commit f3caf742108bb552724d4c4dae74b28ea266a6a3
> > > > > > > Author:=C2=A0 =C2=A0 =C2=A0Cy Schubert > > > <cy_at_FreeBSD.org>< > > > > = > > > > > br> > > > > > > > AuthorDate: 2021-12-29 03:12:39 +0000
> > > > > > > Commit:=C2=A0 =C2=A0 =C2=A0Cy Schubert > > > <cy_at_FreeBSD.org>< > > > > = > > > > > br> > > > > > > > CommitDate: 2021-12-29 03:12:39 +0000
> > > > > > >
> > > > > > >=C2=A0 =C2=A0 =C2=A0x11/mate-screensaver: Fix PAM > build
> > > > > > >=C2=A0 =C2=A0 =C2=A0
> > > > > > >=C2=A0 =C2=A0 =C2=A0Fix build when PAM enabled; > > > <security/_pam_ > > > > = > > > > > macros.h> is a Linuxism.
> > > > > > > ---
> > > > > > >=C2=A0 > x11/mate-screensaver/files/patch-helper_pam-helper.c | > > > 10 + > > > > = > > > > > +++++++++
> > > > > > >=C2=A0 1 file changed, 10 insertions(+)
> > > > > > >
> > > > > > > diff --git > > > a/x11/mate-screensaver/files/patch-helper_pam-helper.c > > > > = > > > > >
> > > > > > b/x11/mate-screensaver/files/patch-helper_pam-helper.c
> > > > > > > new file mode 100644
> > > > > > > index 000000000000..605141fb0e54
> > > > > > > --- /dev/null
> > > > > > > +++ > > > b/x11/mate-screensaver/files/patch-helper_pam-helper.c
> > > > > > > _at__at_ -0,0 +1,10 _at__at_
> > > > > > > +--- helper/pam-helper.c.orig=C2=A0 =C2=A0 =C2=A0 > > > =C2=A02021-11-1 > > > > = > > > > > 5 14:28:47.000000000 -0800
> > > > > > > ++++ helper/pam-helper.c=C2=A0 =C2=A0 2021-12-28 > > > 19:09:39.5016450 > > > > = > > > > > 00 -0800
> > > > > > > +_at__at_ -33,7 +33,6 _at__at_
> > > > > > > +=C2=A0 */
> > > > > > > +
> > > > > > > + #include <security/pam_appl.h>
> > > > > > > +-#include <security/_pam_macros.h>
> > > > > > > +
> > > > > > > + #include <sys/types.h>
> > > > > > > + #include <stdarg.h>
> > > > > >
> > > > > > --
> > > > > > Tomoaki AOKI=C2=A0 =C2=A0 < > > junchoon@dec.sakura.ne > > > > = > > > > > .jp" target=3D"_blank">junchoon@dec.sakura.ne.jp>
> > > > >
> > > > >
> > > > >
> > > > > > > > > > --00000000000063b43405d45dfc6d-- > > > > > > > > > > > > > > > > -- > Tomoaki AOKI > --000000000000b9e8f805d4785faf Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Ok, I made a fork of mate-desktop/mate-screensaver= and reverted=C2=A0 https://github.com/mate-de= sktop/mate-screensaver/commit/ec813dffa59d30fa30ab3e4932095337b5813132#diff= -aeac78bee2093aadfdb2899062cd27c459b83549bbb843417bf3693ca58673a2 and <= a href=3D"https://github.com/mate-desktop/mate-screensaver/commit/ec813dffa= 59d30fa30ab3e4932095337b5813132#diff-3ff2c5a579bd5353be616133d0eef15a260c9f= 44f9064a5a36b58cb7c4b1d989">https://github.com/mate-desktop/mate-screensave= r/commit/ec813dffa59d30fa30ab3e4932095337b5813132#diff-3ff2c5a579bd5353be61= 6133d0eef15a260c9f44f9064a5a36b58cb7c4b1d989.
I= did run sh autogen.sh --with-console-kit=3Dyes --with-systemd=3Dno --enabl= e-authentication-scheme=3Dhelper --with-passwd-helper=3D/usr/local/bin/pam_= helper, gmake and sudo gmake install.
Every= thing is back to normal now I am trying to find if src/gs-auth-helper.c or = src/gs-auth-helper.c is the problem.
Eric Turgeon


On Fri, Dec 31, 2021= at 3:27 AM Tomoaki AOKI <j= unchoon@dec.sakura.ne.jp> wrote:
That's what I pointed as suspicious (but couldn= 't track where the
problem lives in) on Bug 260811.

If introducing missing header(s) is suffice, and any open source
software having it allows partial use, creating header-only port
deriving from it can be an option.

For example, electron* ports are derived from chromium.


On Fri, 31 Dec 2021 00:27:34 -0400
Eric Turgeon <ericturgeon.bsd@gmail.com> wrote:

> It is most likely this commit
> https://github.com/mate-desktop/mate-screensaver/commit/ed6e6065bf0e85b643= 17b5a34b9f7a36a0c839a6
> .
>
> *Eric Turgeon*
>
>
> On Fri, Dec 31, 2021 at 12:02 AM Cy Schubert <Cy.Schubert@cschubert.com>=
> wrote:
>
> > I can confirm PAM authentication is broken by this new release. L= ike
> > layers
> > of an onion, this problem will need to be investigated further. I= doubt
> > simply adding additional macros would resolve the problem. The re= ason I
> > believe this is that the macros are likely a small part of someth= ing
> > larger.
> >
> > Having said that, ports/security/pecl-pam includes a copy of the = file with
> > a reference to the URL from whence it came (suggesting a GPL viol= ation in
> > the ports tree).
> >
> > I think the path forward is to engage our upstream. Then look at = a number
> > of short-term or longer-term options to get us over this hump. > >
> > If upstream is open to fixing the problem temporarily marking the= PAM
> > option broken or temporarily rolling back the upgrade may suffice= .
> >
> > Alternatively, if upstream isn't open to remediation we may w= ant to
> > consider importing Linux-pam on github as a port. Be aware that m= ultiple
> > PAM stacks can coexist however similar problems we have with thre= e KRB5s
> > will require getting linking just right. This option does have th= e
> > advantage of supporting other software written for Linux-PAM (ins= tead of
> > OpenPAM or Solaris PAM -- FreeBSD PAM is based on OpenPAM).
> >
> > Another alternative is dump mate-screensaver for xscreensaver. II= RC
> > xscreensaver was the original screen saver for Gnome back in the = day. (IMO
> > xscreensaver is superior to the Gnome and mate screensavers, thou= gh this
> > is
> > just a personal preference. I've also used it to replace the = CDE
> > screensaver on a per-user basis.) Anyhow, just a thought for anyo= ne.
> >
> > Until we look at the code we won't have a good idea of what k= ind of work
> > is
> > involved.
> >
> > Strategically a Linux-PAM port might be something we might want t= o think
> > about long term. Tactically, any of the other options could work.=
> >
> >
> > --
> > Cheers,
> > Cy Schubert <Cy.Schubert@cschubert.com>
> > FreeBSD UNIX:=C2=A0 <cy@FreeBSD.org>=C2=A0 =C2=A0Web:=C2=A0= https= ://FreeBSD.org
> > NTP:=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0<cy@nwtime.org>=C2=A0 =C2=A0 Web:= =C2=A0 = https://nwtime.org
> >
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0The need of the many outweighs t= he greed of the few.
> >
> >
> > In message <202112301701.1BUH1dji009235@slippy.cwsent.= com>, Cy Schubert
> > writes:
> > > No. It's a bunch of inline macros that perform memory an= d other
> > functions.
> > > All could have been made to be actual functions. On my Fedor= a VM at $JOB
> > > they're part of the pam-devel.rpm.
> > >
> > >
> > > --
> > > Cheers,
> > > Cy Schubert <Cy.Schubert@cschubert.com>
> > > FreeBSD UNIX:=C2=A0 <cy@FreeBSD.org>=C2=A0 =C2=A0Web:= =C2=A0 https://FreeBSD.org
> > > NTP:=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0<cy@nwtime.org>=C2=A0 =C2=A0 = Web:=C2=A0 https://nwtime.org
> > >
> > >=C2=A0 =C2=A0 =C2=A0 =C2=A0The need of the many outweighs the= greed of the few.
> > >
> > >
> > > In message
> > <CADRZFmrE8avprf7NZPcU+tbsgVBzk9=3Dqp4zHKgxLXSOK60QQQw@mail.gm= ail.c
> > > om>
> > > , Eric Turgeon writes:
> > > > --00000000000063b43405d45dfc6d
> > > > Content-Type: text/plain; charset=3D"UTF-8" > > > >
> > > > Do we have an equivalent of security/_pam_macros.h?
> > > >
> > > > *Eric Turgeon*
> > > >
> > > >
> > > > On Wed, Dec 29, 2021 at 11:42 PM Cy Schubert <
> > Cy= .Schubert@cschubert.com>
> > > > wrote:
> > > >
> > > > > This commit only fixed a compile time error, inclu= de file
> > > > > security/_pam_macros.h not found (discovered by my= poudriere build).
> > > > > security/_pam_macros is an include file found only= on some distros of
> > > > > Linux, a Linuxism. Try it without PAM enabled; the= file not found
> > error
> > > > > may
> > > > > just be the beginning of a multitude of PAM issues= .
> > > > >
> > > > > I'll try to look at it over the next couple da= ys.
> > > > >
> > > > >
> > > > > --
> > > > > Cheers,
> > > > > Cy Schubert <Cy.Schubert@cschubert.com>
> > > > > FreeBSD UNIX:=C2=A0 <cy@FreeBSD.org>=C2=A0 = =C2=A0Web:=C2=A0 https://FreeBSD.org
> > > > > NTP:=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0<<= a href=3D"mailto:cy@nwtime.org" target=3D"_blank">cy@nwtime.org>=C2= =A0 =C2=A0 Web:=C2=A0 https://nwtime.org
> > > > >
> > > > >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0The need of the m= any outweighs the greed of the few.
> > > > >
> > > > >
> > > > > In message <20211230110857.1= c0ac0e19e8206cb64a040d7@dec.sakura.ne.jp
> > >,
> > > > > Tomoaki
> > > > > AOKI writes:
> > > > > > Hi.
> > > > > > Wondered whih commit to comment but decided t= o latest.
> > > > > > mate-screensaver no longer opens login panel = after upgrading from
> > > > > > 1.26.0 to 1.26.1.
> > > > > >
> > > > > > Created Bug 260811 [1].
> > > > > >
> > > > > > [1] https://= bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D260811
> > > > > >
> > > > > >
> > > > > > > The branch main has been updated by cy:<= br> > > > > > > >
> > > > > > > URL:
> > > > > >
> > > > >
> > https://cgit.Fr= eeBSD.org/ports/commit/?id=3Df3caf742108bb552724d4c4dae74b28
> > > ea
> > > > 26
> > > > > > 6a6a3
> > > > > > >
> > > > > > > commit f3caf742108bb552724d4c4dae74b28ea= 266a6a3
> > > > > > > Author:=C2=A0 =C2=A0 =C2=A0Cy Schubert &= lt;cy_at_FreeBSD.org>
> > > > > > > AuthorDate: 2021-12-29 03:12:39 +0000 > > > > > > > Commit:=C2=A0 =C2=A0 =C2=A0Cy Schubert &= lt;cy_at_FreeBSD.org>
> > > > > > > CommitDate: 2021-12-29 03:12:39 +0000 > > > > > > >
> > > > > > >=C2=A0 =C2=A0 =C2=A0x11/mate-screensaver:= Fix PAM build
> > > > > > >
> > > > > > >=C2=A0 =C2=A0 =C2=A0Fix build when PAM en= abled; <security/_pam_macros.h> is a
> > Linuxis
> > > m.
> > > > > > > ---
> > > > > > >=C2=A0 x11/mate-screensaver/files/patch-h= elper_pam-helper.c | 10
> > ++++++++++
> > > > > > >=C2=A0 1 file changed, 10 insertions(+) > > > > > > >
> > > > > > > diff --git a/x11/mate-screensaver/files/= patch-helper_pam-helper.c
> > > > > > b/x11/mate-screensaver/files/patch-helper_pam= -helper.c
> > > > > > > new file mode 100644
> > > > > > > index 000000000000..605141fb0e54
> > > > > > > --- /dev/null
> > > > > > > +++ b/x11/mate-screensaver/files/patch-h= elper_pam-helper.c
> > > > > > > _at__at_ -0,0 +1,10 _at__at_
> > > > > > > +--- helper/pam-helper.c.orig=C2=A0 =C2= =A0 =C2=A0 =C2=A02021-11-15
> > 14:28:47.000000000 -08
> > > 00
> > > > > > > ++++ helper/pam-helper.c=C2=A0 =C2=A0 20= 21-12-28 19:09:39.501645000 -0800
> > > > > > > +_at__at_ -33,7 +33,6 _at__at_
> > > > > > > +=C2=A0 */
> > > > > > > +
> > > > > > > + #include <security/pam_appl.h> > > > > > > > +-#include <security/_pam_macros.h>= ;
> > > > > > > +
> > > > > > > + #include <sys/types.h>
> > > > > > > + #include <stdarg.h>
> > > > > >
> > > > > > --
> > > > > > Tomoaki AOKI=C2=A0 =C2=A0 <junchoon@dec.sakura.ne.jp>
> > > > >
> > > > >
> > > > >
> > > >
> > > > --00000000000063b43405d45dfc6d
> > > > Content-Type: text/html; charset=3D"UTF-8" > > > > Content-Transfer-Encoding: quoted-printable
> > > >
> > > > <div dir=3D3D"ltr"><div>Do we hav= e an equivalent of
> > security/_pam_macros.h?</
> > > =3D
> > > > div><div><br></div><div><= div><div dir=3D3D"ltr"
> > class=3D3D"gmail_signature" dat
> > > =3D
> > > > a-smartmail=3D3D"gmail_signature"><div = dir=3D3D"ltr"><div><div
> > dir=3D3D"ltr"><div
> > > =3D
> > > > ><div dir=3D3D"ltr"><div><d= iv dir=3D3D"ltr"><div dir=3D3D"ltr"><span&g= t;<font
> > color=3D
> > > > =3D3D"#888888"><font><font color= =3D3D"#000000"><b>Eric
> > Turgeon</b></font></font
> > > =3D
> > > >
> > ></font></span><span></span><cite&g= t;</cite><br></div><span></span></div>&= lt;/div
> > > =3D
> > > > ></div></div></div></div><= ;/div></div></div><br></div></div><br&g= t;<div
> > class=3D
> > > > =3D3D"gmail_quote"><div dir=3D3D"l= tr" class=3D3D"gmail_attr">On Wed, Dec 29,
> > 2021
> > > =3D
> > > >=C2=A0 at 11:42 PM Cy Schubert &lt;<a href=3D3D&q= uot;mailto:
> > Cy= .Schubert@cschubert.com">C
> > > =3D
> > > > y.Schubert@cschubert.com</a>&gt; wrote:<br></= div><blockquote
> > class=3D3D"gmail
> > > =3D
> > > > _quote" style=3D3D"margin:0px 0px 0px 0.8ex;b= order-left:1px solid
> > rgb(204,204
> > > =3D
> > > > ,204);padding-left:1ex">This commit only fixed = a compile time error,
> > includ
> > > =3D
> > > > e file <br>
> > > > security/_pam_macros.h not found (discovered by my poud= riere build).
> > <br>
> > > > security/_pam_macros is an include file found only on s= ome distros of
> > <br>
> > > > Linux, a Linuxism. Try it without PAM enabled; the file= not found
> > error may
> > > =3D
> > > >=C2=A0 <br>
> > > > just be the beginning of a multitude of PAM issues.<= br>
> > > > <br>
> > > > I&#39;ll try to look at it over the next couple day= s.<br>
> > > > <br>
> > > > <br>
> > > > -- <br>
> > > > Cheers,<br>
> > > > Cy Schubert &lt;<a href=3D3D"mailto:Cy.Schubert@cschube= rt.com"
> > target=3D3D"_bla
> > > =3D
> > > > nk">Cy.Schubert@cschubert.com</a>&gt;<br&g= t;
> > > > FreeBSD UNIX:=3DC2=3DA0 &lt;cy@FreeBSD.org&gt;= =3DC2=3DA0 =3DC2=3DA0Web:=3DC2=3DA0 <a
> > href=3D
> > > > =3D3D"https://FreeBSD.org" rel=3D3D"norefe= rrer" target=3D3D"_blank">
> > ht= tps://FreeB
> > > =3D
> > > > SD.org</a><br>
> > > > NTP:=3DC2=3DA0 =3DC2=3DA0 =3DC2=3DA0 =3DC2=3DA0 =3DC2= =3DA0 =3DC2=3DA0&lt;<a href=3D3D"mailto:
> > cy@nwtim
> > > =3D
> > > > e.org" target=3D3D"_blank">cy@nwtime.org</a>&gt;=3DC2=3D= A0 =3DC2=3DA0
> > Web:=3DC2=3DA0 <a h
> > > =3D
> > > > ref=3D3D"https://nwtime.org" rel=3D3D"noref= errer" target=3D3D"_blank">
> > http= s://nwt
> > > =3D
> > > > ime.org</a><br>
> > > > <br>
> > > > =3DC2=3DA0 =3DC2=3DA0 =3DC2=3DA0 =3DC2=3DA0 The need of= the many outweighs the greed
> > of the
> > > =3D
> > > >=C2=A0 few.<br>
> > > > <br>
> > > > <br>
> > > > In message &lt;<a href=3D3D"mailto:
> > 20211230110857.1c0ac0e19e8206cb64a040d7@de
> > > =3D
> > > > c.sakura.ne.jp"
> > target=3D3D"_blank">20211230110857.1c0ac0e19e8206cb6= 4a040d7@d
> > > =3D
> > > > ec.sakura.ne.jp</a>&gt;, <br>
> > > > Tomoaki<br>
> > > > AOKI writes:<br>
> > > > &gt; Hi.<br>
> > > > &gt; Wondered whih commit to comment but decided to= latest.<br>
> > > > &gt; mate-screensaver no longer opens login panel a= fter upgrading
> > from<br>
> > > > &gt; 1.26.0 to 1.26.1.<br>
> > > > &gt;<br>
> > > > &gt; Created Bug 260811 [1].<br>
> > > > &gt;<br>
> > > > &gt; [1] <a href=3D3D"
> > https://bugs.freebsd.org/bugzilla= /show_bug.cgi?id=3D3D260
> > > =3D
> > > > 811" rel=3D3D"noreferrer" target=3D3D&qu= ot;_blank">
> > https://bugs.freebsd.org/bugzilla
> > > =3D
> > > > /show_bug.cgi?id=3D3D260811</a><br>
> > > > &gt;<br>
> > > > &gt;<br>
> > > > &gt; &gt; The branch main has been updated by c= y:<br>
> > > > &gt; &gt; <br>
> > > > &gt; &gt; URL:<br>
> > > > &gt; <a href=3D3D"
> > https://cgit.FreeBSD.org/port= s/commit/?id=3D3Df3caf742108bb55
> > > =3D
> > > > 2724d4c4dae74b28ea26" rel=3D3D"noreferrer&quo= t; target=3D3D"_blank">
> > https://cgit.Fre
> > > =3D
> > > > eBSD.org/ports/commit/?id=3D3Df3caf742108bb552724d4c4da= e74b28ea26</a><br>
> > > > &gt; 6a6a3<br>
> > > > &gt; &gt; <br>
> > > > &gt; &gt; commit f3caf742108bb552724d4c4dae74b2= 8ea266a6a3<br>
> > > > &gt; &gt; Author:=3DC2=3DA0 =3DC2=3DA0 =3DC2=3D= A0Cy Schubert
> > &lt;cy_at_FreeBSD.org&gt;<
> > > =3D
> > > > br>
> > > > &gt; &gt; AuthorDate: 2021-12-29 03:12:39 +0000= <br>
> > > > &gt; &gt; Commit:=3DC2=3DA0 =3DC2=3DA0 =3DC2=3D= A0Cy Schubert
> > &lt;cy_at_FreeBSD.org&gt;<
> > > =3D
> > > > br>
> > > > &gt; &gt; CommitDate: 2021-12-29 03:12:39 +0000= <br>
> > > > &gt; &gt; <br>
> > > > &gt; &gt;=3DC2=3DA0 =3DC2=3DA0 =3DC2=3DA0x11/ma= te-screensaver: Fix PAM build<br>
> > > > &gt; &gt;=3DC2=3DA0 =3DC2=3DA0 =3DC2=3DA0<br= >
> > > > &gt; &gt;=3DC2=3DA0 =3DC2=3DA0 =3DC2=3DA0Fix bu= ild when PAM enabled;
> > &lt;security/_pam_
> > > =3D
> > > > macros.h&gt; is a Linuxism.<br>
> > > > &gt; &gt; ---<br>
> > > > &gt; &gt;=3DC2=3DA0 x11/mate-screensaver/files/= patch-helper_pam-helper.c |
> > 10 +
> > > =3D
> > > > +++++++++<br>
> > > > &gt; &gt;=3DC2=3DA0 1 file changed, 10 insertio= ns(+)<br>
> > > > &gt; &gt; <br>
> > > > &gt; &gt; diff --git
> > a/x11/mate-screensaver/files/patch-helper_pam-helper.c
> > > =3D
> > > > <br>
> > > > &gt; b/x11/mate-screensaver/files/patch-helper_pam-= helper.c<br>
> > > > &gt; &gt; new file mode 100644<br>
> > > > &gt; &gt; index 000000000000..605141fb0e54<b= r>
> > > > &gt; &gt; --- /dev/null<br>
> > > > &gt; &gt; +++
> > b/x11/mate-screensaver/files/patch-helper_pam-helper.c<br><= br> > > > > &gt; &gt; _at__at_ -0,0 +1,10 _at__at_<br>= ;
> > > > &gt; &gt; +--- helper/pam-helper.c.orig=3DC2=3D= A0 =3DC2=3DA0 =3DC2=3DA0
> > =3DC2=3DA02021-11-1
> > > =3D
> > > > 5 14:28:47.000000000 -0800<br>
> > > > &gt; &gt; ++++ helper/pam-helper.c=3DC2=3DA0 = =3DC2=3DA0 2021-12-28
> > 19:09:39.5016450
> > > =3D
> > > > 00 -0800<br>
> > > > &gt; &gt; +_at__at_ -33,7 +33,6 _at__at_<br&= gt;
> > > > &gt; &gt; +=3DC2=3DA0 */<br>
> > > > &gt; &gt; + <br>
> > > > &gt; &gt; + #include &lt;security/pam_appl.= h&gt;<br>
> > > > &gt; &gt; +-#include &lt;security/_pam_macr= os.h&gt;<br>
> > > > &gt; &gt; + <br>
> > > > &gt; &gt; + #include &lt;sys/types.h&gt= ;<br>
> > > > &gt; &gt; + #include &lt;stdarg.h&gt;&l= t;br>
> > > > &gt;<br>
> > > > &gt; -- <br>
> > > > &gt; Tomoaki AOKI=3DC2=3DA0 =3DC2=3DA0 &lt;<= a href=3D3D"mailto:
> > junch= oon@dec.sakura.ne
> > > =3D
> > > > .jp" target=3D3D"_blank">junchoon@dec.sakura.ne.j= p</a>&gt;<br>
> > > > <br>
> > > > <br>
> > > > </blockquote></div>
> > > >
> > > > --00000000000063b43405d45dfc6d--
> > >
> >
> >
> >


--
Tomoaki AOKI=C2=A0 =C2=A0 <junchoon@dec.sakura.ne.jp>
--000000000000b9e8f805d4785faf--