From owner-freebsd-bugs  Tue Jul 20  2:20: 7 1999
Delivered-To: freebsd-bugs@freebsd.org
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21])
	by hub.freebsd.org (Postfix) with ESMTP id 2989114BED
	for <freebsd-bugs@FreeBSD.org>; Tue, 20 Jul 1999 02:20:02 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.9.3/8.9.2) id CAA98427;
	Tue, 20 Jul 1999 02:20:01 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: from leap.innerx.net (leap.innerx.net [38.179.176.25])
	by hub.freebsd.org (Postfix) with ESMTP id E817E14EC0
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 20 Jul 1999 02:15:15 -0700 (PDT)
	(envelope-from chris@holly.dyndns.org)
Received: from holly.dyndns.org (ip194.houston3.tx.pub-ip.psi.net [38.12.169.194])
	by leap.innerx.net (Postfix) with ESMTP id B600937084
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 20 Jul 1999 05:14:42 -0400 (EDT)
Received: (from chris@localhost)
	by holly.dyndns.org (8.9.3/8.9.3) id EAA36668;
	Tue, 20 Jul 1999 04:15:29 -0500 (CDT)
	(envelope-from chris)
Message-Id: <199907200915.EAA36668@holly.dyndns.org>
Date: Tue, 20 Jul 1999 04:15:29 -0500 (CDT)
From: chris@calldei.com
Reply-To: chris@calldei.com
To: FreeBSD-gnats-submit@freebsd.org
X-Send-Pr-Version: 3.2
Subject: misc/12716: [Patch] query-pr-summary.cgi excludes closed reports even if state='closed'
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org


>Number:         12716
>Category:       misc
>Synopsis:       [Patch] query-pr-summary.cgi excludes closed reports even if state='closed'
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Jul 20 02:20:01 PDT 1999
>Closed-Date:
>Last-Modified:
>Originator:     Chris Costello
>Release:        FreeBSD 4.0-CURRENT i386
>Organization:
none
>Environment:

query-pr-summary.cgi:
     $Id: query-pr-summary.cgi,v 1.22 1999/02/26 22:05:58 billf Exp $

>Description:

When the state specified in a PR search is 'closed' but the 'Closed too'
checkbox is not enabled, no results are turned up, even though there are
closed reports that would turn up had 'Closed too' been enabled.

>How-To-Repeat:

This will show no PRs:
http://www.freebsd.org/cgi/query-pr-summary.cgi?state=closed&sort=none&originator=Chris+Costello&closedtoo=

This will show my closed PRs:
http://www.freebsd.org/cgi/query-pr-summary.cgi?state=closed&sort=none&originator=Chris+Costello&closedtoo=on

>Fix:
This might be a little bit crude, but it definitely works.

Index: query-pr-summary.cgi
===================================================================
RCS file: /home/ncvs/www/en/cgi/query-pr-summary.cgi,v
retrieving revision 1.22
diff -u -r1.22 query-pr-summary.cgi
--- query-pr-summary.cgi	1999/02/26 22:05:58	1.22
+++ query-pr-summary.cgi	1999/07/20 09:10:41
@@ -10,6 +10,7 @@
 $project       = "FreeBSD";
 $mail_prefix   = "freebsd-";
 $mail_unass    = "freebsd-bugs";
+$closed_too    = 0;
 
 %statemap = (
 	"open",		"o",
@@ -60,6 +61,8 @@
 	}
 }
 
+$closed_too = 1 if $input{'state'} eq 'closed' || $input{'closedtoo'};
+
 #------------------------------------------------------------------------
 
 %mons = ('Jan', '01',  'Feb', '02',  'Mar', '03',
@@ -203,7 +206,7 @@
 #       [--list-categories] [--list-responsible] [--list-submitters]
 #       [--text=text] [--multitext=mtext] [PR] [PR]...
 
-$query_args .= " --skip-closed" unless $input{"closedtoo"};
+$query_args .= " --skip-closed" unless $closed_too;
 
 # Only read the appropriate PR's.
 foreach ("category", "originator", "priority", "class", "responsible",

>Release-Note:
>Audit-Trail:
>Unformatted:


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message