From owner-svn-src-head@FreeBSD.ORG  Mon Apr 16 20:01:35 2012
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 6C6DD106564A;
	Mon, 16 Apr 2012 20:01:35 +0000 (UTC)
	(envelope-from bzeeb-lists@lists.zabbadoz.net)
Received: from mx1.sbone.de (mx1.sbone.de [IPv6:2a01:4f8:130:3ffc::401:25])
	by mx1.freebsd.org (Postfix) with ESMTP id E83C48FC18;
	Mon, 16 Apr 2012 20:01:34 +0000 (UTC)
Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:31::2013:587])
	(using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.sbone.de (Postfix) with ESMTPS id EADFD25D3870;
	Mon, 16 Apr 2012 20:01:33 +0000 (UTC)
Received: from content-filter.sbone.de (content-filter.sbone.de
	[IPv6:fde9:577b:c1a9:31::2013:2742])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mail.sbone.de (Postfix) with ESMTPS id 0365EBE4FBB;
	Mon, 16 Apr 2012 20:01:33 +0000 (UTC)
X-Virus-Scanned: amavisd-new at sbone.de
Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:31::2013:587])
	by content-filter.sbone.de (content-filter.sbone.de
	[fde9:577b:c1a9:31::2013:2742]) (amavisd-new, port 10024)
	with ESMTP id aajPKvQqPHbw; Mon, 16 Apr 2012 20:01:32 +0000 (UTC)
Received: from orange-en1.sbone.de (orange-en1.sbone.de
	[IPv6:fde9:577b:c1a9:31:cabc:c8ff:fecf:e8e3])
	(using TLSv1 with cipher AES128-SHA (128/128 bits))
	(No client certificate requested)
	by mail.sbone.de (Postfix) with ESMTPSA id EC577BE4FBA;
	Mon, 16 Apr 2012 20:01:31 +0000 (UTC)
Mime-Version: 1.0 (Apple Message framework v1084)
Content-Type: text/plain; charset=us-ascii
From: "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net>
In-Reply-To: <CACVs6=8BYYN0ZW7zzHZduns-ZH9hUF=M1EmXfoOkCZVMh1ubpg@mail.gmail.com>
Date: Mon, 16 Apr 2012 20:01:30 +0000
Content-Transfer-Encoding: 7bit
Message-Id: <AEC8B145-8DD5-4504-8DAF-255B64B6C3D2@lists.zabbadoz.net>
References: <201204160938.q3G9cLmw026093@svn.freebsd.org>
	<CACVs6=8BYYN0ZW7zzHZduns-ZH9hUF=M1EmXfoOkCZVMh1ubpg@mail.gmail.com>
To: Juli Mallett <jmallett@FreeBSD.org>
X-Mailer: Apple Mail (2.1084)
Cc: Andrew Turner <andrew@freebsd.org>, svn-src-head@freebsd.org,
	svn-src-all@freebsd.org, src-committers@freebsd.org
Subject: Re: svn commit: r234337 - in head: lib/libc/arm/gen sys/arm/include
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 16 Apr 2012 20:01:35 -0000


On 16. Apr 2012, at 19:41 , Juli Mallett wrote:

> On Mon, Apr 16, 2012 at 02:38, Andrew Turner <andrew@freebsd.org> wrote:
>> Log:
>>  Replace the C implementation of __aeabi_read_tp with an assembly version.
>>  This ensures we follow the ABI by preserving registers r1-r3.
> 
>> +ENTRY(__aeabi_read_tp)
>> +       ldr     r0, .Larm_tp_address
>> +       ldr     r0, [r0]
>> +       RET
>> +
>> +.Larm_tp_address:
>> +       .word ARM_TP_ADDRESS
>> +
> 
> Why is this indirection required?  Can't you just use ARM_TP_ADDRESS
> instead of loading it from data?  Also, is our convention for ARM to
> use END() with ENTRY() or not?

Don't you generally want END() . ?

-- 
Bjoern A. Zeeb                                 You have to have visions!
   It does not matter how good you are. It matters what good you do!