From owner-freebsd-questions@FreeBSD.ORG  Fri Feb  3 11:24:09 2006
Return-Path: <owner-freebsd-questions@FreeBSD.ORG>
X-Original-To: freebsd-questions@freebsd.org
Delivered-To: freebsd-questions@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id AA6F816A427
	for <freebsd-questions@freebsd.org>;
	Fri,  3 Feb 2006 11:24:09 +0000 (GMT)
	(envelope-from gunnar.flygt@sr.se)
Received: from dart.sr.se (dart.SR.SE [134.25.0.132])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 8CD4143D5E
	for <freebsd-questions@freebsd.org>;
	Fri,  3 Feb 2006 11:24:03 +0000 (GMT)
	(envelope-from gunnar.flygt@sr.se)
Received: from honken.sr.se (honken.sr.se [134.25.128.27])
	by dart.sr.se (8.13.1/8.13.1) with ESMTP id k13BO20B058755
	for <freebsd-questions@freebsd.org>;
	Fri, 3 Feb 2006 12:24:02 +0100 (CET)
	(envelope-from gunnar.flygt@sr.se)
Received: from bsd-gf.sr.se (bsd-gf.SR.SE [134.25.200.100])
	by honken.sr.se (8.13.3/8.13.3) with ESMTP id k13BO21l042222
	for <freebsd-questions@freebsd.org>;
	Fri, 3 Feb 2006 12:24:02 +0100 (CET)
	(envelope-from gunnar.flygt@sr.se)
Received: from localhost (localhost [IPv6:::1])
	by bsd-gf.sr.se (8.13.4/8.13.4) with ESMTP id k13BLjiX068977
	for <freebsd-questions@FreeBSD.org>;
	Fri, 3 Feb 2006 12:24:02 +0100 (CET)
	(envelope-from gunnar.flygt@sr.se)
From: Gunnar Flygt <gunnar.flygt@sr.se>
To: FreeBSD Questions <freebsd-questions@freebsd.org>
Message-ID: <20030430093709.GA55280@sr.se>
Mail-Followup-To: Gunnar Flygt <gunnar.flygt@sr.se>,
	FreeBSD Questions <freebsd-questions@FreeBSD.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.4.1i
Lines: 56
Subject: problems with sh after upgrade to 4.7
X-BeenThere: freebsd-questions@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Gunnar Flygt <gunnar.flygt@sr.se>
List-Id: User questions <freebsd-questions.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-questions>, 
	<mailto:freebsd-questions-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-questions>
List-Post: <mailto:freebsd-questions@freebsd.org>
List-Help: <mailto:freebsd-questions-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-questions>, 
	<mailto:freebsd-questions-request@freebsd.org?subject=subscribe>
Date: Fri, 03 Feb 2006 11:24:09 -0000
X-Original-Date: Wed, 30 Apr 2003 11:37:09 +0200
X-List-Received-Date: Fri, 03 Feb 2006 11:24:09 -0000

After upgrade from 4.6.2-RELEASE to 4.7-RELEASE I've got problems
with a shellscript that I have on one of my machines. The script
(which I've taken over from a far better shellprogammer) looks as follows:

#!/bin/sh

RTSPCONTROL="/usr/local/etc/rc.d/rtspproxy.sh"
cd `dirname $0`
cd ../..
PREFIX=/usr/local

case $1 in
        start)  echo -n ' rtspproxy'
                RTSPPROXY=${PREFIX}/sbin/rtspproxy
                PID_FILE=/var/run/rtspproxy.pid
                [ -x ${RTSPPROXY} ] && ${RTSPPROXY} > /dev/null & && echo $! > $ {PID_FILE}
                ;;
        stop)   if [ -f /var/run/rtspproxy.pid ]; then
                        kill `cat /var/run/rtspproxy.pid`
                        rm /var/run/rtspproxy.pid
                fi
                ;;
        check)
                for pidfile in `find /var/run -name 'rtspproxy.pid'`
                do
                        if ! kill -0 `head -1 $pidfile` > /dev/null ;then
                        echo "$pidfile process is dead! Restarting..."
                        logger -p daemon.err -t rtspproxy.sh "$pidfile process is dead! Restarting..."
                        ARGS=start
                        rm -f $pidfile
                        ${RTSPCONTROL} ${ARGS}
                        fi
                done
                ;;


esac

The problem line is line 12:
 [ -x ${RTSPPROXY} ] && ${RTSPPROXY} > /dev/null & && echo $! > $ {PID_FILE}

When I run `/usr/local/etc/rc.d/rtspproxy.sh start I get this error

/usr/local/etc/rc.d/rtspproxy.sh: 12: Syntax error: "&&" unexpected

The script starts the file and redirects the output from rtspproxy
(the PID) to the PID_FILE so that the check part can use it later.

Since my knowledge in shellscripting is not enough to rewrite the script,
I ask for help here.

-- 
Gunnar Flygt
OPC Data
Sveriges Radio