From nobody Sat Apr 5 11:29:36 2025 X-Original-To: freebsd-net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZVCv33CRxz5s2Nx for ; Sat, 05 Apr 2025 11:30:07 +0000 (UTC) (envelope-from lexi@hemlock.eden.le-fay.org) Received: from fuchsia.eden.le-fay.org (fuchsia.eden.le-fay.org [81.187.47.195]) by mx1.freebsd.org (Postfix) with ESMTP id 4ZVCv23dhsz3gJT for ; Sat, 05 Apr 2025 11:30:06 +0000 (UTC) (envelope-from lexi@hemlock.eden.le-fay.org) Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of lexi@hemlock.eden.le-fay.org has no SPF policy when checking 81.187.47.195) smtp.mailfrom=lexi@hemlock.eden.le-fay.org Received: from hemlock.eden.le-fay.org (hemlock.eden.le-fay.org [81.2.96.162]) by fuchsia.eden.le-fay.org (Postfix) with ESMTP id 4C85722767 for ; Sat, 05 Apr 2025 11:29:44 +0000 (UTC) Received: by hemlock.eden.le-fay.org (Postfix, from userid 10006) id EA0184AB12; Sat, 05 Apr 2025 12:29:36 +0100 (BST) Date: Sat, 5 Apr 2025 12:29:36 +0100 From: Lexi Winter To: freebsd-net@freebsd.org Subject: Re: bridge(4) VLAN filtering Message-ID: Mail-Followup-To: freebsd-net@freebsd.org References: <4b137357-a674-4fe3-82ea-7c1985fa0dd0@shrew.net> List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spamd-Result: default: False [2.04 / 15.00]; AUTH_NA(1.00)[]; NEURAL_SPAM_LONG(0.97)[0.970]; NEURAL_SPAM_MEDIUM(0.91)[0.911]; NEURAL_HAM_SHORT(-0.74)[-0.738]; RCVD_NO_TLS_LAST(0.10)[]; RCVD_IN_DNSWL_LOW(-0.10)[81.187.47.195:from]; MIME_GOOD(-0.10)[text/plain]; RCPT_COUNT_ONE(0.00)[1]; ASN(0.00)[asn:20712, ipnet:81.187.0.0/16, country:GB]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; MISSING_XM_UA(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; R_DKIM_NA(0.00)[]; DMARC_NA(0.00)[le-fay.org]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; MLMMJ_DEST(0.00)[freebsd-net@freebsd.org]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_NONE(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[freebsd-net@freebsd.org]; R_SPF_NA(0.00)[no SPF record] X-Rspamd-Queue-Id: 4ZVCv23dhsz3gJT X-Spamd-Bar: ++ Lexi Winter: > bridge_input() also does a second list walk in GRAB_OUR_PACKETS to find > traffic destined for the local host, which we could avoid with a sysctl > to ignore Ethernet traffic for MAC addresses other than the bridge > itself. this would break configurations where IP addresses are assigned > to bridge member interfaces, but that's always been the wrong way to > configure it, so it's not a huge loss. i tested this today and observed a 22% throughput increase on a 50-member bridge by removing this list walk. PR at https://github.com/freebsd/freebsd-src/pull/1641 (however, it's possible this breaks something else that i haven't thought of; ymmv.)