From owner-cvs-src@FreeBSD.ORG Sun Mar 6 05:05:53 2005 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DFC5E16A4CE; Sun, 6 Mar 2005 05:05:53 +0000 (GMT) Received: from postfix3-2.free.fr (postfix3-2.free.fr [213.228.0.169]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3D88343D39; Sun, 6 Mar 2005 05:05:53 +0000 (GMT) (envelope-from tataz@tataz.chchile.org) Received: from tatooine.tataz.chchile.org (vol75-8-82-233-239-98.fbx.proxad.net [82.233.239.98]) by postfix3-2.free.fr (Postfix) with ESMTP id 2265FC047; Sun, 6 Mar 2005 06:05:51 +0100 (CET) Received: by tatooine.tataz.chchile.org (Postfix, from userid 1000) id 6E90F407C; Sun, 6 Mar 2005 06:05:06 +0100 (CET) Date: Sun, 6 Mar 2005 06:05:05 +0100 From: Jeremie Le Hen To: Warner Losh Message-ID: <20050306050505.GA71191@obiwan.tataz.chchile.org> References: <200502280127.j1S1ROkh066282@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200502280127.j1S1ROkh066282@repoman.freebsd.org> User-Agent: Mutt/1.5.7i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/cardbus cardbus.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Mar 2005 05:05:54 -0000 Hi, On Mon, Feb 28, 2005 at 01:27:24AM +0000, Warner Losh wrote: > imp 2005-02-28 01:27:24 UTC > > FreeBSD src repository > > Modified files: > sys/dev/cardbus cardbus.c > Log: > There were two calls to cardbus_do_cis when cardbus_do_cis changed, > yet I only changed one of them. So when we loaded drivers, we'd fail > to allocate resources correct. > > This pointed out that we were doing the wrong thing when we failed to > attach a child. We released all the resources and almost deleted the > child. Instead, we should keep the resources allocated so when/if a > driver is loaded, we can go w/o having to allocate them. We use > pci_cfg_save/restore to restore the BARs with these resources. > > This seems to fix the problems that we were seeing that I thought > might have magically gone away in the last revision of cardbus.c (but > really didn't). > > Noticed by: avatar (nicely done!) > > Revision Changes Path > 1.49 +5 -7 src/sys/dev/cardbus/cardbus.c This commit prevents my rl(4) network card from attaching. Reverting to rev 1.48 makes things goes right. Feel free to contact me if you need more details. Regards, -- Jeremie Le Hen jeremie at le-hen dot org