From owner-cvs-ports@FreeBSD.ORG  Sun Jul  3 00:33:36 2011
Return-Path: <owner-cvs-ports@FreeBSD.ORG>
Delivered-To: cvs-ports@FreeBSD.org
Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2001:4f8:fff6::35])
	by hub.freebsd.org (Postfix) with ESMTP id B0155106564A;
	Sun,  3 Jul 2011 00:33:36 +0000 (UTC)
	(envelope-from dougb@FreeBSD.org)
Received: from 65-241-43-4.globalsuite.net (hub.freebsd.org
	[IPv6:2001:4f8:fff6::36])
	by mx2.freebsd.org (Postfix) with ESMTP id 0E87B14E77F;
	Sun,  3 Jul 2011 00:33:36 +0000 (UTC)
Message-ID: <4E0FB8DF.90904@FreeBSD.org>
Date: Sat, 02 Jul 2011 17:33:35 -0700
From: Doug Barton <dougb@FreeBSD.org>
Organization: http://SupersetSolutions.com/
User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US;
	rv:1.9.2.18) Gecko/20110624 Thunderbird/3.1.11
MIME-Version: 1.0
To: Martin Wilke <miwi@FreeBSD.org>
References: <201107021323.p62DNWeP082020@repoman.freebsd.org>
In-Reply-To: <201107021323.p62DNWeP082020@repoman.freebsd.org>
X-Enigmail-Version: 1.1.2
OpenPGP: id=1A1ABC84
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: cvs-ports@FreeBSD.org, samm@os2.kiev.ua, cvs-all@FreeBSD.org,
	ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/sysutils/atop Makefile distinfo
 ports/sysutils/atop/files atop.in pkg-message.in
X-BeenThere: cvs-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the ports tree <cvs-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-ports>
List-Post: <mailto:cvs-ports@freebsd.org>
List-Help: <mailto:cvs-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 03 Jul 2011 00:33:36 -0000

Overall this looks good, just 2 small comments. It's not clear why it uses:

# REQUIRE: DAEMON
# BEFORE: LOGIN

Instead of just

# REQUIRE: LOGIN

like most ports scripts do. Also the default empty assignment for _flags 
is neither necessary or desirable.


hth,

Doug


On 07/02/2011 06:23, Martin Wilke wrote:
> miwi        2011-07-02 13:23:32 UTC
>
>    FreeBSD ports repository
>
>    Modified files:
>      sysutils/atop        Makefile distinfo
>      sysutils/atop/files  atop.in
>    Added files:
>      sysutils/atop/files  pkg-message.in
>    Log:
>    - Update to to 1.26.b4
>
>    PR:             158591  http://www.FreeBSD.org/cgi/query-pr.cgi?pr=158591
>    Submitted by:   maintainer
>
>    Revision  Changes    Path
>    1.2       +4 -1      ports/sysutils/atop/Makefile
>    1.2       +2 -2      ports/sysutils/atop/distinfo
>    1.2       +17 -3     ports/sysutils/atop/files/atop.in
>    1.1       +21 -0     ports/sysutils/atop/files/pkg-message.in (new)
>
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/sysutils/atop/Makefile.diff?&r1=1.1&r2=1.2&f=h
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/sysutils/atop/distinfo.diff?&r1=1.1&r2=1.2&f=h
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/sysutils/atop/files/atop.in.diff?&r1=1.1&r2=1.2&f=h
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/sysutils/atop/files/pkg-message.in
>



-- 

	Nothin' ever doesn't change, but nothin' changes much.
			-- OK Go

	Breadth of IT experience, and depth of knowledge in the DNS.
	Yours for the right price.  :)  http://SupersetSolutions.com/