From owner-cvs-src@FreeBSD.ORG  Tue Mar  6 12:42:38 2007
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@FreeBSD.org
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id D127616A401;
	Tue,  6 Mar 2007 12:42:38 +0000 (UTC)
	(envelope-from doginou@dong.ci0.org)
Received: from dong.ci0.org (cognet.ci0.org [80.65.224.102])
	by mx1.freebsd.org (Postfix) with ESMTP id DCB8413C441;
	Tue,  6 Mar 2007 12:42:37 +0000 (UTC)
	(envelope-from doginou@dong.ci0.org)
Received: from dong.ci0.org (localhost.ci0.org [127.0.0.1])
	by dong.ci0.org (8.13.8/8.13.8) with ESMTP id l26CHkdp086623;
	Tue, 6 Mar 2007 13:17:46 +0100 (CET)
	(envelope-from doginou@dong.ci0.org)
Received: (from doginou@localhost)
	by dong.ci0.org (8.13.8/8.13.8/Submit) id l26CHj13086622;
	Tue, 6 Mar 2007 13:17:45 +0100 (CET) (envelope-from doginou)
Date: Tue, 6 Mar 2007 13:17:45 +0100
From: Olivier Houchard <cognet@ci0.org>
To: Sam Leffler <sam@errno.com>
Message-ID: <20070306121745.GB86528@ci0.org>
References: <200703042340.l24Neanq039195@repoman.freebsd.org>
	<20070306234936.O635@10.0.0.1> <45ECE475.1010405@errno.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <45ECE475.1010405@errno.com>
User-Agent: Mutt/1.4.1i
Cc: Jeff Roberson <jroberson@chesapeake.net>, src-committers@FreeBSD.org,
	"Wojciech A. Koszek" <wkoszek@FreeBSD.org>, cvs-all@FreeBSD.org,
	cvs-src@FreeBSD.org
Subject: Re: cvs commit: src/sys/kern kern_alq.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 06 Mar 2007 12:42:38 -0000

On Mon, Mar 05, 2007 at 07:48:05PM -0800, Sam Leffler wrote:
> Jeff Roberson wrote:
> > The ALQ lock is a spinlock.  I don't believe this works.  Do I
> > misunderstand something?
> > 
> > On Sun, 4 Mar 2007, Wojciech A. Koszek wrote:
> > 
> >> wkoszek     2007-03-04 23:40:36 UTC
> >>
> >>  FreeBSD src repository
> >>
> >>  Modified files:
> >>    sys/kern             kern_alq.c
> >>  Log:
> >>  Use msleep(9) instead of tsleep(9) surrounded by lock acquisition and
> >>  release.
> >>
> >>  Approved by:    cognet (mentor)
> >>
> >>  Revision  Changes    Path
> >>  1.17      +2 -6      src/sys/kern/kern_alq.c
> >>
> > 
> > 
> 
> Yeah, this is totally busted and could never been tested.
> 

That's my fault, sorry.

Olivier