Date: Mon, 8 Jan 1996 20:20:04 -0800 (PST) From: Dave Marquardt <marquard@austin.ibm.com> To: freebsd-bugs Subject: Re: kern/923: Multicast problems on point-to-point interfaces Message-ID: <199601090420.UAA06221@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/923; it has been noted by GNATS.
From: Dave Marquardt <marquard@austin.ibm.com>
To: Bill Fenner <fenner@parc.xerox.com>
Cc: wollman@lcs.mit.edu, FreeBSD-gnats-submit@freebsd.org
Subject: Re: kern/923: Multicast problems on point-to-point interfaces
Date: Mon, 08 Jan 1996 22:12:06 -0600
On Wed, 3 Jan 1996 07:04:47 PST Bill Fenner wrote:
> In message <96Jan2.171459pst.177478@crevenia.parc.xerox.com> I wrote:
> >*** in_var.h.old Tue Nov 14 14:52:43 1995
> >--- in_var.h Tue Jan 2 17:11:10 1996
>
> Ugh. I really shouldn't try writing code after two days of travel hell.
> Try this one:
>
>
> *** in_var.h.old Tue Nov 14 14:52:43 1995
> --- in_var.h Wed Jan 3 07:02:45 1996
> ***************
> *** 106,111 ****
> --- 106,118 ----
> IA_DSTSIN(ia):IA_SIN(ia))->sin_addr.s_addr != (addr).s_addr; \
> ia = ia->ia_next) \
> continue; \
> + if (ia == NULL) \
> + for (ia = in_ifaddr; \
> + ia != NULL; \
> + ia = ia->ia_next) \
> + if (ia->ia_ifp->if_flags & IFF_POINTOPOINT && \
> + IA_SIN(ia)->sin_addr.s_addr != (addr).s_addr) \
^^
Seems like that should be ==, shouldn't it? With !=, you quit on the
first interface whose address DOESN'T match, which I don't think is
what was intended.
> + break; \
> (ifp) = (ia == NULL) ? NULL : ia->ia_ifp; \
> }
>
> Bill
--
Dave Marquardt
SMTP: marquard@austin.ibm.com
VNET: MARQUARD at AUSTIN
T/L 678-1139
+1 512 838-1139
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199601090420.UAA06221>