From owner-svn-src-head@freebsd.org Fri Jul 20 17:45:38 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2DB63104D435 for ; Fri, 20 Jul 2018 17:45:38 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-it0-x22e.google.com (mail-it0-x22e.google.com [IPv6:2607:f8b0:4001:c0b::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B223D865FD for ; Fri, 20 Jul 2018 17:45:37 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-it0-x22e.google.com with SMTP id q20-v6so15648203ith.0 for ; Fri, 20 Jul 2018 10:45:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=gOit3VWlGnYcXhUME2DyRtPS/86JpM4yQtUvITDVNIc=; b=bdj5V6yQ5DXOb9M3qYJ5RffqCPtnNywuVLZbQNqgeKmnBMrzh2Rh5gxBOM6Lm+ooB4 iAdN2OgB2ksWaBeFbkf9dVJpu8zEzo/RMxnVB2XqHFr6PamFS+MBSggnszFQXwLYqMXE VXQOUsSnTVjQMbphF1QVYkvbStLzlaUyZSSmlK7C+fEoxT0jY77t/OE/yye/n1WxNaKh L6gjFKIeXKqu4pAFg8VBdEfBWPD6P3Uuzi1jV4ymDxI9EXgSrArVMWlg8B7L2u0cqSd/ 0teDX2RLQnYkEh95atMHdnhsh3ZPf292wn3SR64es0yVu7O8+jDh7m+kfZ5p6zEiR9FF LMoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=gOit3VWlGnYcXhUME2DyRtPS/86JpM4yQtUvITDVNIc=; b=qGVVMTQ9qWlHN8MtYfNpdgHhYGUj3Gyeym9fv+9HhMBpK2/MNwqwSMZesbPB3kQSTS 5XjfbLxFRvpOqbqjR3HRG7XyQFbnYUlr5zq4wXsjYLrCjPKCm5iISFypyZKV/uXRJAPw iJwXa/SmomYmHoxBck4XGQqvjuDCEtTctHxRgL/XSERXpG5vx7mebOO0+pIEeCFSaKEC 3By9fdOew94PMWRc7lvGnzZgOxWS19HbpHr8Ck0t9y4SiH5CUR1ZP9Gf8dCkFa7OnFp3 X5Yh4QY4PcJGyuWeiK3KmxzMjpIJUR+DGttVU00N9eTbpXwiJdTyEwBX82Cqh4xj6xUR 3NHA== X-Gm-Message-State: AOUpUlEiyLvR/IcZnFb+V5djyPKVxmtxZphScWJncMiYBkt72VOhP2gK odgXex9pCBZJ1Gc45Ji0ODa88GJ6ZoWT6wbq4DbH0cO035w= X-Google-Smtp-Source: AAOMgpfXX/7CSROS61gqVqwphFHiFLSycMg1YzSJ1monGPqyFG5C1VKslw/F3FGJm6WVFnwiK+CcywdWsOdb+bVk9Rg= X-Received: by 2002:a24:ad28:: with SMTP id c40-v6mr2684901itf.36.1532108737073; Fri, 20 Jul 2018 10:45:37 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 2002:a4f:4485:0:0:0:0:0 with HTTP; Fri, 20 Jul 2018 10:45:36 -0700 (PDT) X-Originating-IP: [63.237.121.26] In-Reply-To: <1532108303.1344.57.camel@freebsd.org> References: <201807200044.w6K0i4QQ079894@repo.freebsd.org> <1532108303.1344.57.camel@freebsd.org> From: Warner Losh Date: Fri, 20 Jul 2018 11:45:36 -0600 X-Google-Sender-Auth: HGTdA5xANE1tZX4CCw5aaJ8tgyw Message-ID: Subject: Re: svn commit: r336526 - head To: Ian Lepore Cc: Ravi Pokala , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.27 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Jul 2018 17:45:38 -0000 On Fri, Jul 20, 2018 at 11:38 AM, Ian Lepore wrote: > On Fri, 2018-07-20 at 09:56 -0700, Ravi Pokala wrote: > > Hi Ian, > > > > -----Original Message----- > > From: on behalf of Ian Lepore > > Date: 2018-07-19, Thursday at 17:44 > > To: , , > > Subject: svn commit: r336526 - head > > > > > > > > Author: ian > > > Date: Fri Jul 20 00:44:04 2018 > > > New Revision: 336526 > > > URL: https://svnweb.freebsd.org/changeset/base/336526 > > > > > > Log: > > > Add ntpd to the list of users/groups to check before installing. > > > > > > Modified: > > > head/Makefile.inc1 > > When trying to installworld: > > > > ERROR: Required ntpd user is missing, see /usr/src/UPDATING. > > > > But there is no UPDATING entry about this. (Also, shouldn't it be > ${SRCTOP}/UPDATING?) > > > > Thanks, > > > > Ravi (rpokala@) > > I wondered about that too, when I accidentally stumbled across the > CHECK_UIDS thing and realized I should add ntpd to it. I searched in > UPDATING for some of the other things in the CHECK_UIDS list to see > what had been said about such changes in the past, even searching > through old-old svn history, and found nothing. > > I finally settled on the thought that the reference to UPDATING was to > the stuff at the bottom that never changes. In particular to the > section around line 1595 that documents the instalkernel, reboot, > mergemaster, installworld sequence. The mergemaster part should take > care of the new userid, I guess. > It should. While what you say is true, it's also been true that in the past people have often listed new userid's in the UPDATING text at the top to give people more info about whether or not it's safe to skip mergemaster and/or make alternative plans if it isn't and they don't use mergemaster :) Warner