From owner-cvs-all@FreeBSD.ORG Fri Jan 20 11:33:14 2006 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5001A16A41F; Fri, 20 Jan 2006 11:33:14 +0000 (GMT) (envelope-from edwin@mavetju.org) Received: from mail2out.barnet.com.au (mail2out.barnet.com.au [202.83.176.14]) by mx1.FreeBSD.org (Postfix) with ESMTP id 955EE43D45; Fri, 20 Jan 2006 11:33:12 +0000 (GMT) (envelope-from edwin@mavetju.org) Received: by mail2out.barnet.com.au (Postfix, from userid 27) id A40B17073DD; Fri, 20 Jan 2006 22:33:11 +1100 (EST) X-Viruscan-Id: <43D0CA770000A00545D3F2@BarNet> Received: from mail2-auth.barnet.com.au (mail2.barnet.com.au [202.83.176.13]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "*.barnet.com.au", Issuer "BarNet Root Certificate Authority" (verified OK)) by mail2.barnet.com.au (Postfix) with ESMTP id 4C0BB7073D8; Fri, 20 Jan 2006 22:33:11 +1100 (EST) Received: from k7.mavetju (edwin-3.int.barnet.com.au [10.10.12.2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mail2-auth.barnet.com.au (Postfix) with ESMTP id D22807073D5; Fri, 20 Jan 2006 22:33:08 +1100 (EST) Received: by k7.mavetju (Postfix, from userid 1001) id 89221201; Fri, 20 Jan 2006 22:32:32 +1100 (EST) Date: Fri, 20 Jan 2006 22:32:32 +1100 From: Edwin Groothuis To: Sergey Skvortsov Message-ID: <20060120113232.GD1026@k7.mavetju> References: <200601201014.k0KAEMQ5053386@repoman.freebsd.org> <20060120102934.GB1026@k7.mavetju> <43D0BE68.6010403@FreeBSD.org> <20060120105326.GC1026@k7.mavetju> <43D0C93D.1050704@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <43D0C93D.1050704@FreeBSD.org> User-Agent: Mutt/1.4.2.1i Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/net/ssldump/files patch-ssl%ssldecode.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Jan 2006 11:33:14 -0000 On Fri, Jan 20, 2006 at 02:27:57PM +0300, Sergey Skvortsov wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Edwin Groothuis wrote: > >> > >> Edwin Groothuis wrote: > >>>> FreeBSD ports repository > >>>> > >>>> Added files: > >>>> net/ssldump/files patch-ssl%ssldecode.c > >>> Did I miss a naming-convention change? > > > >> History repeats itself... Ok. > >> > >> 1. I dislike "_" as path delimiter. It's not so obvious and aesthetic as > >> "::" or "%". > > > > I don't like it neither, but I accepted the fact that there was a > > proper naming standard for it so at least this wildgrowth of patch > > files would be resolved. > > First of all, it is not a "proper naming standard". I always suggest to > use SHOULD/MUST/etc words (RFC 2119) in "Porters' Handboook" to avoid > any incomprehension. In current situation I prefer to treat "Please only > use characters [-+._a-zA-Z0-9]" as "You SHOULD use characters > [-+._a-zA-Z0-9]". > > Many committers do not like this "convention". Hence the above regex > should be reviewed and extended. There is no technical problems with > additional ":%" symbols. Patch names must be convenient, not procrustean. Please stop being so annoying, and follow the spirit of the guide instead of the letter of the guide. I'm now off to bed, I'll see what I have to do in the morning. Edwin -- Edwin Groothuis | Personal website: http://www.mavetju.org edwin@mavetju.org | Weblog: http://weblog.barnet.com.au/edwin/