From owner-freebsd-emulation@FreeBSD.ORG  Fri Apr 29 05:41:22 2011
Return-Path: <owner-freebsd-emulation@FreeBSD.ORG>
Delivered-To: emulation@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C05E7106566B;
	Fri, 29 Apr 2011 05:41:22 +0000 (UTC) (envelope-from avg@FreeBSD.org)
Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140])
	by mx1.freebsd.org (Postfix) with ESMTP id 965348FC0C;
	Fri, 29 Apr 2011 05:41:20 +0000 (UTC)
Received: from porto.topspin.kiev.ua (porto-e.starpoint.kiev.ua
	[212.40.38.100])
	by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id IAA13552;
	Fri, 29 Apr 2011 08:41:12 +0300 (EEST)
	(envelope-from avg@FreeBSD.org)
Received: from localhost.topspin.kiev.ua ([127.0.0.1])
	by porto.topspin.kiev.ua with esmtp (Exim 4.34 (FreeBSD))
	id 1QFgS0-000F6S-68; Fri, 29 Apr 2011 08:41:12 +0300
Message-ID: <4DBA4F77.1000409@FreeBSD.org>
Date: Fri, 29 Apr 2011 08:41:11 +0300
From: Andriy Gapon <avg@FreeBSD.org>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US;
	rv:1.9.2.15) Gecko/20110308 Lightning/1.0b2 Thunderbird/3.1.9
MIME-Version: 1.0
To: Juergen Lock <nox@jelal.kn-bremen.de>
References: <20110426174449.GA4437@triton8.kn-bremen.de>
	<20110426185132.GA8111@triton8.kn-bremen.de>
	<4DB72341.7060201@FreeBSD.org>
	<20110426202349.GA14855@triton8.kn-bremen.de>
	<4DB7BC6A.7060207@FreeBSD.org>
	<20110427163047.GA47520@triton8.kn-bremen.de>
	<7d7a2fab-7c4e-44ce-bdf2-93811c40a4fe@email.android.com>
	<20110428193351.GA8814@triton8.kn-bremen.de>
	<68864477@h30.sp.ipt.ru> <20110428220114.00004b22@unknown>
	<20110428201939.GA16556@triton8.kn-bremen.de>
In-Reply-To: <20110428201939.GA16556@triton8.kn-bremen.de>
X-Enigmail-Version: 1.1.2
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: netchild@FreeBSD.org, emulation@FreeBSD.org, multimedia@FreeBSD.org,
	Alexander Leidinger <Alexander@Leidinger.net>,
	Ion-Mihai Tetcu <itetcu@FreeBSD.org>, fluffy@FreeBSD.org
Subject: Re: audio/linux-f10-alsa-plugins-oss
X-BeenThere: freebsd-emulation@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Development of Emulators of other operating systems
	<freebsd-emulation.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-emulation>, 
	<mailto:freebsd-emulation-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-emulation>
List-Post: <mailto:freebsd-emulation@freebsd.org>
List-Help: <mailto:freebsd-emulation-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-emulation>, 
	<mailto:freebsd-emulation-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 29 Apr 2011 05:41:22 -0000


There is another thing that I've just noticed - wouldn't the port overwrite a
custom pcm-oss.conf (if any)?

I think it would be nice to do the usual .conf-dist vs .conf dance here.
E.g. something like:
CONF_FILE=      etc/alsa/pcm/pcm-oss.conf

post-patch:
	@${RM} ${WRKDIR}/${CONF_FILE}.orig
	@${MV} ${WRKDIR}/${CONF_FILE} ${WRKDIR}/${CONF_FILE}-dist

post-install:
	@if [ ! -f ${PREFIX}/${CONF_FILE} ]; then \
		${CP} -p ${PREFIX}/${CONF_FILE}-dist ${PREFIX}/${CONF_FILE} ; \
	fi
	PKG_PREFIX=${PREFIX} ${SH} ${PKGINSTALL} ${PKGNAME} POST-INSTALL


And in pkg-plist:
@unexec if cmp -s %D/etc/alsa/pcm/pcm-oss.conf-dist
%D/etc/alsa/pcm/pcm-oss.conf; then rm -f %D/etc/alsa/pcm/pcm-oss.conf; fi
etc/alsa/pcm/pcm-oss.conf-dist
@exec if [ ! -f %D/etc/alsa/pcm/pcm-oss.conf ] ; then cp -p %D/%F %B/client.conf; fi


What do you think?

-- 
Andriy Gapon