From owner-cvs-all  Fri May 10 21: 1:12 2002
Delivered-To: cvs-all@freebsd.org
Received: from mail.speakeasy.net (mail12.speakeasy.net [216.254.0.212])
	by hub.freebsd.org (Postfix) with ESMTP id BA14137B407
	for <cvs-all@FreeBSD.org>; Fri, 10 May 2002 21:01:04 -0700 (PDT)
Received: (qmail 2809 invoked from network); 11 May 2002 04:01:04 -0000
Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender <jhb@FreeBSD.org>)
          by mail12.speakeasy.net (qmail-ldap-1.03) with DES-CBC3-SHA encrypted SMTP
          for <cvs-all@FreeBSD.org>; 11 May 2002 04:01:04 -0000
Received: from laptop.baldwin.cx (laptop.baldwin.cx [192.168.0.4])
	by server.baldwin.cx (8.11.6/8.11.6) with ESMTP id g4B412F45382;
	Sat, 11 May 2002 00:01:02 -0400 (EDT)
	(envelope-from jhb@FreeBSD.org)
Message-ID: <XFMail.20020511000059.jhb@FreeBSD.org>
X-Mailer: XFMail 1.5.2 on FreeBSD
X-Priority: 3 (Normal)
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
In-Reply-To: <20020511035555.GE90188@elvis.mu.org>
Date: Sat, 11 May 2002 00:00:59 -0400 (EDT)
From: John Baldwin <jhb@FreeBSD.org>
To: Alfred Perlstein <alfred@FreeBSD.org>
Subject: Re: cvs commit: src/usr.sbin/pkg_install/add extract.c src/usr.s
Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG


On 11-May-2002 Alfred Perlstein wrote:
> * John Baldwin <jhb@FreeBSD.org> [020510 20:51] wrote:
>> 
>> On 11-May-2002 Alfred Perlstein wrote:
>> > alfred      2002/05/10 20:48:49 PDT
>> > 
>> >   Modified files:
>> >     usr.sbin/pkg_install/add extract.c 
>> >     usr.sbin/pkg_install/create perform.c pl.c 
>> >     usr.sbin/pkg_install/delete perform.c 
>> >     usr.sbin/pkg_install/info show.c 
>> >     usr.sbin/pkg_install/lib file.c pen.c plist.c 
>> >   Log:
>> >   fix build:
>> >   you may not use string concatination with __FUNCTION__, replace all
>> > occurances
>> >   of:
>> >   __FUNCTION__ ": error string"
>> >   with:
>> >   "%s: error string"
>> 
>> You should also use __func__ instead of __FUNCTION__ since __func__ is
>> the standard (C-99 IIRC) name for it.
> 
> I don't mind fixing that, should I?

I would. :)  I've tried to use __func__ instead of __FUNCTION__ in the kernel.

-- 

John Baldwin <jhb@FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message