From owner-svn-src-all@FreeBSD.ORG Thu Feb 12 22:44:33 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id A03C6FA; Thu, 12 Feb 2015 22:44:33 +0000 (UTC) Received: from mx1.sbone.de (mx1.sbone.de [IPv6:2a01:4f8:130:3ffc::401:25]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client CN "mx1.sbone.de", Issuer "SBone.DE" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 306C2910; Thu, 12 Feb 2015 22:44:33 +0000 (UTC) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:31::2013:587]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.sbone.de (Postfix) with ESMTPS id D01EA25D3A92; Thu, 12 Feb 2015 22:44:27 +0000 (UTC) Received: from content-filter.sbone.de (content-filter.sbone.de [IPv6:fde9:577b:c1a9:31::2013:2742]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id 23D4EC7709E; Thu, 12 Feb 2015 22:44:27 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:31::2013:587]) by content-filter.sbone.de (content-filter.sbone.de [fde9:577b:c1a9:31::2013:2742]) (amavisd-new, port 10024) with ESMTP id PqrZB4NLu9XP; Thu, 12 Feb 2015 22:44:25 +0000 (UTC) Received: from [IPv6:fde9:577b:c1a9:4410:ccda:6447:f:a] (unknown [IPv6:fde9:577b:c1a9:4410:ccda:6447:f:a]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id B81ACC770A0; Thu, 12 Feb 2015 22:44:23 +0000 (UTC) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2070.6\)) Subject: Re: svn commit: r278634 - head/lib/libc/gen From: "Bjoern A. Zeeb" In-Reply-To: <54DD2A87.2050008@FreeBSD.org> Date: Thu, 12 Feb 2015 22:44:13 +0000 Content-Transfer-Encoding: quoted-printable Message-Id: <9A683D99-C1E9-4736-982C-69F583D3A40D@FreeBSD.org> References: <201502122107.t1CL7gaO004041@svn.freebsd.org> <54DD2A87.2050008@FreeBSD.org> To: Pedro Giffuni X-Mailer: Apple Mail (2.2070.6) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Feb 2015 22:44:33 -0000 > On 12 Feb 2015, at 22:34 , Pedro Giffuni wrote: >=20 >=20 > On 02/12/15 17:27, Bjoern A. Zeeb wrote: >>> On 12 Feb 2015, at 21:07 , Pedro F. Giffuni wrote: >>>=20 >>> Author: pfg >>> Date: Thu Feb 12 21:07:42 2015 >>> New Revision: 278634 >>> URL: https://svnweb.freebsd.org/changeset/base/278634 >>>=20 >>> Log: >>> ulimit(3): Fix broken check. >>>=20 >>> The existing implementation had a broken comparison that could = overflow. >>> Replace this with a check that avoids the overflow before it = happens. >>>=20 >>> Consistently return a maximum value also on the case of negative >>> arguments since negative is considered an overflow and means >>> infinity for our current setrlimit(). >>>=20 >>> Discussed with: bde (rather extensively) >>>=20 >> Did this compile? >>=20 >=20 > Yes! Any log message to share? Now I do again; had lost them due to buildworld starting over again: =3D=3D=3D> lib/libc_nonshared (obj,depend,all,install) cc1: warnings being treated as errors /scratch/tmp/bz/head.svn/lib/libc/gen/ulimit.c: In function 'ulimit': /scratch/tmp/bz/head.svn/lib/libc/gen/ulimit.c:56: warning: comparison = is always false due to limited range of data type /scratch/tmp/bz/head.svn/lib/libc/gen/ulimit.c:57: warning: overflow in = implicit constant conversion --- ulimit.So --- *** [ulimit.So] Error code 1 mips.mipsn32 buildworld failed, check _.mips.mipsn32.buildworld for = details mips.mips buildworld failed, check _.mips.mips.buildworld for details powerpc.powerpc buildworld failed, check _.powerpc.powerpc.buildworld = for details mips.mipsel buildworld failed, check _.mips.mipsel.buildworld for = details arm.armeb buildworld failed, check _.arm.armeb.buildworld for details arm.armv6hf buildworld failed, check _.arm.armv6hf.buildworld for = details arm.arm buildworld failed, check _.arm.arm.buildworld for details arm.armv6 buildworld failed, check _.arm.armv6.buildworld for details pc98.i386 buildworld failed, check _.pc98.i386.buildworld for details i386.i386 buildworld failed, check _.i386.i386.buildworld for details powerpc.powerpc64 buildworld failed, check = _.powerpc.powerpc64.buildworld for details amd64.amd64 buildworld failed, check _.amd64.amd64.buildworld for = details