From owner-freebsd-fs@FreeBSD.ORG Thu Mar 29 18:28:53 2012 Return-Path: Delivered-To: fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5C99B1065678; Thu, 29 Mar 2012 18:28:53 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200]) by mx1.freebsd.org (Postfix) with ESMTP id A78D08FC14; Thu, 29 Mar 2012 18:28:52 +0000 (UTC) Received: from skuns.kiev.zoral.com.ua (localhost [127.0.0.1]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id q2TISl83025398; Thu, 29 Mar 2012 21:28:47 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.5/8.14.5) with ESMTP id q2TISlE4007768; Thu, 29 Mar 2012 21:28:47 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.5/8.14.5/Submit) id q2TISl5h007767; Thu, 29 Mar 2012 21:28:47 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Thu, 29 Mar 2012 21:28:47 +0300 From: Konstantin Belousov To: mdf@freebsd.org Message-ID: <20120329182847.GD2358@deviant.kiev.zoral.com.ua> References: <20120327183440.GS2358@deviant.kiev.zoral.com.ua> <20120329091415.GA1316@reks> <20120329093427.GA2358@deviant.kiev.zoral.com.ua> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="J/iAXrWP4xH+aVs6" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-4.0 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: fs@freebsd.org Subject: Re: RFC: SEEK_HOLE/SEEK_DATA common implementation X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Mar 2012 18:28:53 -0000 --J/iAXrWP4xH+aVs6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Mar 29, 2012 at 06:56:31AM -0700, mdf@freebsd.org wrote: > On Thu, Mar 29, 2012 at 2:34 AM, Konstantin Belousov > wrote: > > Filesystem probably should always fall back to calling vop_stdioctl() > > manually if it ever implements VOP_IOCTL, regardless of seek_hole/data. >=20 > We can't if there's a use of VOP_BMAP() in one of the ioctls. For > OneFS, a call to VOP_BMAP is fatal. That operation doesn't work with > our system. But you had to already take some measure to disable the call to VOP_BMAP() for your filesystem, otherwise mmap() is fatal too (whatever the word fatal means) ? >=20 > We could implement SEEK_HOLE/SEEK_DATA semi-efficiently, but > implementing a custom filesystem becomes very complex once one has not > only to manage replacing all VOPs where the default doesn't work but > also has to know there's a bunch of ioctls in VOP_IOCTL that must be > handled as well. Does anything change if VOP_SEEKDATA() is added which default implementation using VOP_BMAP() ? --J/iAXrWP4xH+aVs6 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (FreeBSD) iEYEARECAAYFAk90qd8ACgkQC3+MBN1Mb4iW0gCfRL7N7wSLpIWEQYZqr1c5nhFH V2gAoMPffMz7oLWi6Ihnxj/f9C5IZf5u =Djew -----END PGP SIGNATURE----- --J/iAXrWP4xH+aVs6--