Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 15 Aug 2020 22:21:00 +0000
From:      bugzilla-noreply@freebsd.org
To:        python@FreeBSD.org
Subject:   maintainer-feedback requested: [Bug 248676] net/py-urllib3: Update to 1.25.10
Message-ID:  <bug-248676-21822-u8MxPXIPCk@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-248676-21822@https.bugs.freebsd.org/bugzilla/>
References:  <bug-248676-21822@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
Bugzilla Automation <bugzilla@FreeBSD.org> has asked freebsd-python (Nobody)
<python@FreeBSD.org> for maintainer-feedback:
Bug 248676: net/py-urllib3: Update to 1.25.10
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D248676



--- Description ---
Update (py-)urllib3 to 1.25.10
Fix "make test"

Tested on FreeBSD 13.0-CURRENT #0 r358620 (AMD64) (make test)
Poudriere OK 12.1-RELEASE (AMD64)

1.25.7 (fixed make test)

test/contrib/test_socks.py::TestSocks5Proxy::test_socks_with_invalid_passwo=
rd
FAILED
test/with_dummyserver/test_proxy_poolmanager.py::TestHTTPProxyManager::test=
_cro
ss_protocol_redirect
FAILED

=3D=3D=3D 2 failed, 1139 passed, 175 skipped, 1 deselected, 129 warnings in=
 67.67
seconds =3D=3D=3D

1.25.10

test/contrib/test_socks.py::TestSocks5Proxy::test_socks_with_invalid_passwo=
rd
FAILED

=3D=3D=3D 1 failed, 1159 passed, 195 skipped, 3 deselected, 47 warnings in =
36.02
seconds =3D=3D=3D

Full log:

___ TestSocks5Proxy.test_socks_with_invalid_password ___

self =3D <test.contrib.test_socks.TestSocks5Proxy object at 0x8036f4210>

    def test_socks_with_invalid_password(self):
	def request_handler(listener):
	    sock =3D listener.accept()[0]

	    handler =3D handle_socks5_negotiation(
		sock, negotiate=3DTrue, username=3Db"user", password=3Db"pass"
	    )
	    next(handler)

	self._start_server(request_handler)
	proxy_url =3D "socks5h://%s:%s" % (self.host, self.port)
	with socks.SOCKSProxyManager(
	    proxy_url, username=3D"user", password=3D"badpass"
	) as pm:
	    with pytest.raises(NewConnectionError) as e:
		pm.request("GET", "http://example.com", retries=3DFalse)
>	    assert "SOCKS5 authentication failed" in str(e.value)
E	    AssertionError: assert 'SOCKS5 authentication failed' in
'<urllib3.contrib.socks.SOCKSConnection object at 0x80460a4d0>: Failed to
establish a new connection: [Errno 61] Connection refused'
E	     +	where '<urllib3.contrib.socks.SOCKSConnection object at
0x80460a4d0>: Failed to establish a new connection: [Errno 61] Connection
refused' =3D str(NewConnectionError('<urllib3.contrib.socks.SOCKSConnection
object at 0x80460a4d0>: Failed to establish a new connection: [Errno 61]
Connection refused'))
E	     +	  where
NewConnectionError('<urllib3.contrib.socks.SOCKSConnection object at
0x80460a4d0>: Failed to establish a new connection: [Errno 61] Connection
refused') =3D <ExceptionInfo NewConnectionError tblen=3D16>.value

test/contrib/test_socks.py:448: AssertionError



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-248676-21822-u8MxPXIPCk>