From owner-freebsd-ports-bugs@FreeBSD.ORG Fri Dec 9 13:39:19 2005 Return-Path: X-Original-To: freebsd-ports-bugs@FreeBSD.org Delivered-To: freebsd-ports-bugs@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5A99E16A426; Fri, 9 Dec 2005 13:39:19 +0000 (GMT) (envelope-from pav@FreeBSD.org) Received: from e0-a11.b1.lan.prg.vol.cz (e0-a11.b1.lan.prg.vol.cz [195.122.204.152]) by mx1.FreeBSD.org (Postfix) with ESMTP id E59CA43D45; Fri, 9 Dec 2005 13:39:01 +0000 (GMT) (envelope-from pav@FreeBSD.org) Received: from pav.hide.vol.cz (localhost [127.0.0.1]) by e0-a11.b1.lan.prg.vol.cz (8.13.4/8.13.4) with ESMTP id jB9DciJ2031257; Fri, 9 Dec 2005 14:38:44 +0100 (CET) (envelope-from pav@FreeBSD.org) Received: (from pav@localhost) by pav.hide.vol.cz (8.13.4/8.13.4/Submit) id jB9Dcio7031256; Fri, 9 Dec 2005 14:38:44 +0100 (CET) (envelope-from pav@FreeBSD.org) X-Authentication-Warning: pav.hide.vol.cz: pav set sender to pav@FreeBSD.org using -f From: Pav Lucistnik To: Ion-Mihai Tetcu In-Reply-To: <20051209153510.5182ebe2@it.buh.tecnik93.com> References: <200512090922.jB99MYbH094744@freefall.freebsd.org> <20051209143235.79632f96@it.buh.tecnik93.com> <1134131789.28991.24.camel@pav.hide.vol.cz> <20051209150907.1725f4c9@it.buh.tecnik93.com> <1134134096.28991.27.camel@pav.hide.vol.cz> <20051209153510.5182ebe2@it.buh.tecnik93.com> Content-Type: text/plain Content-Transfer-Encoding: 7bit Date: Fri, 09 Dec 2005 14:38:43 +0100 Message-Id: <1134135523.28991.30.camel@pav.hide.vol.cz> Mime-Version: 1.0 X-Mailer: Evolution 2.4.2.1 FreeBSD GNOME Team Port Cc: freebsd-ports-bugs@FreeBSD.org, dougb@FreeBSD.org, bug-followup@FreeBSD.org Subject: Re: ports/90070: [MAINTAINER] mail/rabl_server: per sougb request, use "new style" RC script X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: pav@FreeBSD.org List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Dec 2005 13:39:19 -0000 > > > > And with new dougb's rcNG, rc scripts in /usr/local/etc/rc.d now > > > > must be without .sh extension? > > > > > > In dougb's words: > > > >>> The rc.subr system treats scripts named foo.sh differently than > > > > scripts named foo. The former are actually sourced into the rc > > > > environment, which can cause problems if there are errors in the > > > > script, it overwrites a global variable used elsewhere, etc. > > > > Thus, it is better to install the script as foo instead of foo.sh. > > > And the example he provided install non .sh on HEAD; unfortunately > > > the port from his example doesn't USE_RC_SUBR macro. > > > > So when installed with .sh they will still work? > > Yes, but w/o using dougb's new style. That's pity, I hoped it will be transparent. > > > > This is absolutely something that must be fixed in the > > > > infrastructure, not in every port over and over again. > > > > > > My point exactly. And, as I've said, I'm willing to work on this; I > > > could (manually) check the USE_RC_SUBR ports over the weekend to see > > > what kind of rc script they're using. But I need to know which way > > > to go: renaming non-RCng scripts to *.sh, etc., or I could try to > > > convert them to RCmng (but this should be done but maintainers, as > > > they know better what to REQUIRE, etc.) > > > > Is it a good thing to modify USE_RC_SUBR inside bsd.port.mk to install > > without .sh suffix if ${OSVERSION} > 7000xx and be done with it? > > I think so, but we must check that (1) at least all ports that > USE_RC_SUBR have RCng scripts and (2) no port relies on .sh adding; 1 > and 2 are somehow the same thing, as 2 hurts only if 1 is false. > > In the end we should have only new-style RCng scripts > (files/rc_script.in) whit ports setting USE_RC_SUBR= rc_script.in, > installed as such on HEAD (and sometime on 6-STABLE) and .sh added for > older OSVERSIONs. Other way around, leave USE_RC_SUBR=skript.sh and files/skript.sh.in, to avoid repo churn, and strip .sh when installing on newer OSVERSIONs. You file a PR with patch or should I do it? (I would not have a chance to test it as I don't possess a -CURRENT box.) -- Pav Lucistnik Quantum physics was developed in the 1930's, as a result of a bet between Albert Einstein and Niels Bohr, to see who could come up with the most ridiculous theory and still have it published.