From nobody Tue Jun 9 23:14:18 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gZl9R2dk6z6grLm; Tue, 09 Jun 2026 23:14:35 +0000 (UTC) (envelope-from kib@freebsd.org) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4gZl9Q3wrYz3Qrf; Tue, 09 Jun 2026 23:14:34 +0000 (UTC) (envelope-from kib@freebsd.org) Authentication-Results: mx1.freebsd.org; none Received: from tom.home (kib@localhost [127.0.0.1] (may be forged)) by kib.kiev.ua (8.18.1/8.18.1) with ESMTP id 659NEIVX062790; Wed, 10 Jun 2026 02:14:21 +0300 (EEST) (envelope-from kib@freebsd.org) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 659NEIVX062790 Received: (from kostik@localhost) by tom.home (8.18.1/8.18.1/Submit) id 659NEINt062789; Wed, 10 Jun 2026 02:14:18 +0300 (EEST) (envelope-from kib@freebsd.org) X-Authentication-Warning: tom.home: kostik set sender to kib@freebsd.org using -f Date: Wed, 10 Jun 2026 02:14:18 +0300 From: Konstantin Belousov To: John Baldwin Cc: Robert Clausecker , Robert Clausecker , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, Faraz Vahedi Subject: Re: git: 5f732742ad5b - main - libc: Add free_sized() and free_aligned_sized() as per C23 Message-ID: References: <6a25dc0b.4729a.7f7225a7@gitrepo.freebsd.org> <15221817-b23e-4cd2-94a9-edff4d06bb3b@FreeBSD.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <15221817-b23e-4cd2-94a9-edff4d06bb3b@FreeBSD.org> X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham autolearn_force=no version=4.0.2 X-Spam-Checker-Version: SpamAssassin 4.0.2 (2025-08-27) on tom.home X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:6939, ipnet:2001:470::/32, country:US] X-Rspamd-Queue-Id: 4gZl9Q3wrYz3Qrf X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated On Tue, Jun 09, 2026 at 10:06:09AM -0400, John Baldwin wrote: > On 6/9/26 05:30, Robert Clausecker wrote: > > Hi Konstantin, > > > > Am Tue, Jun 09, 2026 at 04:38:58AM +0300 schrieb Konstantin Belousov: > > > On Sun, Jun 07, 2026 at 09:00:59PM +0000, Robert Clausecker wrote: > > > > The branch main has been updated by fuz: > > > > > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=5f732742ad5b3133a860a8969cf2bd13dc9ac358 > > > > > > > > commit 5f732742ad5b3133a860a8969cf2bd13dc9ac358 > > > > Author: Faraz Vahedi > > > > AuthorDate: 2026-05-16 18:36:17 +0000 > > > > Commit: Robert Clausecker > > > > CommitDate: 2026-06-07 20:59:19 +0000 > > > > > > > > libc: Add free_sized() and free_aligned_sized() as per C23 > > > > > > > +FBSD_1.9 { > > > > + free_sized; > > > > + free_aligned_sized; > > > > > > > + __free_sized; > > > > + __free_aligned_sized; > > > > > > Why these two symbols (from private C namespace) need to be exported? > > > And then, why they need to be exported in the public version? > > > > > > > +}; > > > > This is for consistency with the other libc allocator symbols, which are also > > exported. I suppose this is useful if you e.g. wish to hook or replace the > > allocation machinery, giving you access to the originals where desired. > > That's what RTLD_NEXT is for? Well there is indeed 9dfba391d62cb. But since we are trying to discourage the non-standard interpretation of the weak symbol semantic from rtld (of course this can never happen), might be it is not too wise to extend the hack. Anyway, it is in now, so let it be.