From owner-freebsd-current@freebsd.org Thu Aug 1 19:31:20 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 8F5F8C72C5; Thu, 1 Aug 2019 19:31:20 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-io1-xd44.google.com (mail-io1-xd44.google.com [IPv6:2607:f8b0:4864:20::d44]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4600lW4brpz4BDy; Thu, 1 Aug 2019 19:31:19 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-io1-xd44.google.com with SMTP id j5so142799344ioj.8; Thu, 01 Aug 2019 12:31:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=wlnToAyEDH3/o9SRsQIIH9r6ypCuwlnAVcAiAh6PVO0=; b=Rclz/Hv7i6UQvRHEsoAxCQMGXJMcpvT7Bh8LiXq5COrPcWFuo11ZsJgNx/fQGMcQoo Osz80q1TC2rkZDVZ9zvTimnPqmj36Mp3LjreQEX/xtxgqxNFz1ejXFQYNbUjkFqjRQh1 jIxYKgeAJM9JsYwPeszdBzZjDJ0MYy70MGSdsZxOBjrG0j6U+GsI3pdIF2QaGjXOFfHW L6LsBazM5fSJa1gdAK8ajkZ5geVlLI7vdVCA6R4k2ZOROoc9Oy1SWl0gnkgtKOTU2nrq ZAv/RNXDuTsXuth1oW2N4Eo1dkQxD3IUZgds2oN5pLeo7bPclyk/7L9Axa+KdyP3e9yM 3zvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=wlnToAyEDH3/o9SRsQIIH9r6ypCuwlnAVcAiAh6PVO0=; b=rn2iTOWpyY/VZhkQSu34FBKxXYQnJIpDp0ScK+TmXFVztzw7PVyqLgYwCAq8Vzb1zh ro8GbRIOiPvnobwDXjybululoZO20LnMgfI6kDbJAZaEqe5G+4/VcUqjcS2ogDMibJwy DP6IUjBDsSYu00lfW/3YOs8RBPY11yZi727wvU/URhGtLKoKuMORjlNd0OZZYPQcoKL7 pvRUwhtmAXJcI6XmJ32aLXJrS5XEOzT1Sca+jCZUb2cz3c9mFeLqzVwGoBD3wnmaMWTn h28c5juyiVZozQYmmaOBuPLCJkGoifsP7nTMhpFS/NRXLveTIAJj2Lj8h1iHjBNq//e/ IEYw== X-Gm-Message-State: APjAAAXXi/1JVYqZ3laY4DRFzZ56fJVl47hsPD9py1nUEGw/UU/d1s1T QGpFrxrNKsXYJl4eYQjSyhw= X-Google-Smtp-Source: APXvYqxE1yWzIpBxX5VCeg2G0Po4V8urXNatLwGSvW9i1lfcrTr14NNgMpn6EH9ZKKE4hBTixINsfQ== X-Received: by 2002:a6b:3102:: with SMTP id j2mr7006881ioa.5.1564687878532; Thu, 01 Aug 2019 12:31:18 -0700 (PDT) Received: from raichu (toroon0560w-lp140-05-70-29-85-38.dsl.bell.ca. [70.29.85.38]) by smtp.gmail.com with ESMTPSA id m10sm128821379ioj.75.2019.08.01.12.31.17 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 01 Aug 2019 12:31:17 -0700 (PDT) Sender: Mark Johnston Date: Thu, 1 Aug 2019 15:31:15 -0400 From: Mark Johnston To: Steve Kargl Cc: freebsd-x11@freebsd.org, freebsd-current@freebsd.org Subject: Re: drm-legacy is broken, again Message-ID: <20190801193115.GC19051@raichu> References: <20190801191009.GA8229@troutmask.apl.washington.edu> <20190801192227.GB19051@raichu> <20190801193024.GA29819@troutmask.apl.washington.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190801193024.GA29819@troutmask.apl.washington.edu> User-Agent: Mutt/1.12.1 (2019-06-15) X-Rspamd-Queue-Id: 4600lW4brpz4BDy X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=Rclz/Hv7; dmarc=none; spf=pass (mx1.freebsd.org: domain of markjdb@gmail.com designates 2607:f8b0:4864:20::d44 as permitted sender) smtp.mailfrom=markjdb@gmail.com X-Spamd-Result: default: False [-1.09 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; MIME_GOOD(-0.10)[text/plain]; MIME_TRACE(0.00)[0:+]; DMARC_NA(0.00)[freebsd.org]; TO_DN_SOME(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; NEURAL_HAM_SHORT(-0.69)[-0.690,0]; RCVD_IN_DNSWL_NONE(0.00)[4.4.d.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; IP_SCORE(-0.70)[ip: (2.09), ipnet: 2607:f8b0::/32(-3.09), asn: 15169(-2.46), country: US(-0.05)]; FORGED_SENDER(0.30)[markj@freebsd.org,markjdb@gmail.com]; MID_RHS_NOT_FQDN(0.50)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[markj@freebsd.org,markjdb@gmail.com]; RCVD_TLS_ALL(0.00)[] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Aug 2019 19:31:20 -0000 On Thu, Aug 01, 2019 at 12:30:24PM -0700, Steve Kargl wrote: > On Thu, Aug 01, 2019 at 03:22:27PM -0400, Mark Johnston wrote: > > On Thu, Aug 01, 2019 at 12:10:09PM -0700, Steve Kargl wrote: > > > Just updated /usr/src to top of tree. > > > > > > Trying to update drm-legacy port. After > > > a failed 'make' in /usr/ports/drm-legacy > > > > The patch below should fix it. drm was relying on refcount.h including > > limits.h. > > > > diff --git a/src/dev/drm2/drmP.h b/src/dev/drm2/drmP.h > > index 3af7ad1..7cbd8db 100644 > > --- a/src/dev/drm2/drmP.h > > +++ b/src/dev/drm2/drmP.h > > @@ -42,6 +42,7 @@ __FBSDID("$FreeBSD$"); > > > > #include > > #include > > +#include > > #include > > #include > > #include > > Thanks for the quick response. I had recalled someone > has/had been undoing some header pollution changes, > but the individual names escaped me. I reproduced the issue and submitted a PR: https://github.com/FreeBSDDesktop/drm-legacy/pull/13