From nobody Sun Jan 11 23:18:11 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dqBJd5pYwz6Nfrx for ; Sun, 11 Jan 2026 23:18:25 +0000 (UTC) (envelope-from ctuffli@gmail.com) Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dqBJc6LXSz49kZ for ; Sun, 11 Jan 2026 23:18:24 +0000 (UTC) (envelope-from ctuffli@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=freebsd.org (policy=none); spf=pass (mx1.freebsd.org: domain of ctuffli@gmail.com designates 209.85.215.171 as permitted sender) smtp.mailfrom=ctuffli@gmail.com Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-ba599137cf8so1745280a12.0 for ; Sun, 11 Jan 2026 15:18:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768173503; x=1768778303; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=M8HkODoNvUiuShebxlYa55EziAHQDlCTZbo9b7KE5/s=; b=YqOcv4BOaZy5UzlCuAqNdUJYqyOyCeP/CjgJd83TFlzAfELBHMqLEs3vymGR8qDcia 3hhNmPP6+xUMerV+4g9GN2m7WiJ4/bMDmlYDXvXreT93gFr3pNDCSTksOlFxeOOmiKHH s7oM0gFuwjGzbkyooRHKv63ckw5wtJiJ9B465CWOlTByTCJ3ah7MEMuJIic841/dbdQS oU37JUQ5a9SnhkZ36vOFM+CMbpqAZTmvh70/luykmqijteia8irpl4vefTCFQesZUOY4 0woq2nMYTy/hWieBSWlXba8IM4WJRooE2S2s9kV2ZUy7+F2YmtqSGa4fFKDeDJQv/Rqr r3wQ== X-Forwarded-Encrypted: i=1; AJvYcCW+DoBkcLCPSzccY2AENYMVhOxdMC1+Lptc/ymcK1iZL1cI3Kn617URQESQ8O13jSXFNwCqlve099PTn5B8vOch3Z45jA==@freebsd.org X-Gm-Message-State: AOJu0YxY8oijlFG77OEHM5d+GpT8+e8K0/OjkqE2i2to/wbLa7SL3tO6 mQtG7v2bGK3Q5XC7U34Y1mBRrMOw5XqCUW91nE+OCe0Xgbtbe+Sw7YK+Zphuxg== X-Gm-Gg: AY/fxX4l0sOMCko91F8f7o5cu4auIkuUtRSqdCh4rJP6G9+74SSfid6AZeREgQtHoPS qECP2RYeZZZfw64OXKQshb6baGVd/zTPdjAh51gPmCVayjAAQaJpeMXdobTDRiPMev+LD9a/6mk 7I7uMkceviDuCsOIH6Q/kK/PXoG7yvBn8GoWHVFuWfpdPQm66VAXC/qZWlcj8jvx431/iXH/Pg+ e98N9mgOYt9ydD6q/6x3qA2f8vcVWXaYwU/m6gQtoEGGb4gfCiovQZ2u+ui2XBgLNIkU29s1e+u gAfMF24/yQOTNlNTAreCQeXdXVIKr6aPrTfTFE9X1qJA7Vp1f4u/fNifXzSoIKLmEfP/vggJrcG hobCybe1x9vBTNfrUlmwiJPLPuPzh+MUFT54tWZWQmUh+q6lAki8YOg1qVyTg5MizxopC6XOrZ0 9CsglPNIRRaU3ORK7+8zuuzy0zwfAV164fdsVONcavN4eo5Xkv7L0tMTw= X-Google-Smtp-Source: AGHT+IEMi5z65TTrJHPXQ+7emVaONN3grdIh3f81riaSCcb/GIHUuaH2u0q/dIygn8HH9nZOIATfCg== X-Received: by 2002:a17:902:da8d:b0:2a0:e7e0:1d31 with SMTP id d9443c01a7336-2a3e3992e27mr212904835ad.11.1768173503038; Sun, 11 Jan 2026 15:18:23 -0800 (PST) Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com. [209.85.216.48]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a3e3cd2ac2sm157422235ad.90.2026.01.11.15.18.22 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 11 Jan 2026 15:18:22 -0800 (PST) Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-34c93e0269cso2607773a91.1 for ; Sun, 11 Jan 2026 15:18:22 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCUqTAXfKFAN+z/3ar+aCue0onUBGUOpxP4LdLbZ6oueN3ATiPKJOKU7fINDF4KG0Z7O/KQzV0fPUY7t/7QWSTorO2vCIA==@freebsd.org X-Received: by 2002:a17:90b:2e8f:b0:343:3898:e7c7 with SMTP id 98e67ed59e1d1-34f68c010d0mr14449473a91.12.1768173502378; Sun, 11 Jan 2026 15:18:22 -0800 (PST) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 References: <69616257.8255.cd9e3ac@gitrepo.freebsd.org> In-Reply-To: <69616257.8255.cd9e3ac@gitrepo.freebsd.org> From: Chuck Tuffli Date: Sun, 11 Jan 2026 15:18:11 -0800 X-Gmail-Original-Message-ID: X-Gm-Features: AZwV_QhTvQzpHAVtsh6-SGCggImBpJrNu9PomM10A91_hYZ14cm3uIr2rrQUvbo Message-ID: Subject: Re: git: 763179042246 - main - Fix NULL deref segfault in bhyve's usb_mouse.c To: Warner Losh Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, Jack Bendtsen Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: / X-Spamd-Result: default: False [-0.99 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.999]; FORGED_SENDER(0.30)[chuck@freebsd.org,ctuffli@gmail.com]; NEURAL_HAM_SHORT(-0.26)[-0.263]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; NEURAL_SPAM_LONG(0.17)[0.173]; MIME_GOOD(-0.10)[text/plain]; DMARC_POLICY_SOFTFAIL(0.10)[freebsd.org : SPF not aligned (relaxed), No valid DKIM,none]; RCVD_TLS_LAST(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; FROM_HAS_DN(0.00)[]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; TO_DN_SOME(0.00)[]; FREEMAIL_CC(0.00)[freebsd.org,gmail.com]; MISSING_XM_UA(0.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-main@freebsd.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; FROM_NEQ_ENVFROM(0.00)[chuck@freebsd.org,ctuffli@gmail.com]; RCVD_IN_DNSWL_NONE(0.00)[209.85.215.171:from,209.85.216.48:received]; MLMMJ_DEST(0.00)[dev-commits-src-main@freebsd.org]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.215.171:from]; R_DKIM_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_FIVE(0.00)[5] X-Rspamd-Queue-Id: 4dqBJc6LXSz49kZ On Fri, Jan 9, 2026 at 12:18=E2=80=AFPM Warner Losh wrote= : > > The branch main has been updated by imp: > > URL: https://cgit.FreeBSD.org/src/commit/?id=3D7631790422464de1aec309018e= 2c444defe5f629 > > commit 7631790422464de1aec309018e2c444defe5f629 > Author: Jack Bendtsen > AuthorDate: 2025-06-19 07:40:31 +0000 > Commit: Warner Losh > CommitDate: 2026-01-09 20:17:13 +0000 > > Fix NULL deref segfault in bhyve's usb_mouse.c > > Some of the cases inside umouse_request() (usr.sbin/bhyve/usb_mouse.c= ) > use the data component of an event, while only partially checking if > it's NULL. 'data' has a NULL check, but then 'data' is immediately > deferenced anyway after the check regardless of if it's NULL or not. The SmartOS/Illumos folks ran into this issue a bit ago and fixed their version of bhyve differently (https://www.illumos.org/issues/17784). This has been on my to-do list, but it didn't make it to the top before this (point hat: chuck@). Any concerns or objections to my committing https://reviews.freebsd.org/D54661 to minimize our diffs with SmartOS/illumos? --chuck