Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 21 Nov 2015 22:57:05 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-ports-bugs@FreeBSD.org
Subject:   [Bug 204725] |make makepatch| inserts context junk after r401709
Message-ID:  <bug-204725-13-i9GxoHNR4c@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-204725-13@https.bugs.freebsd.org/bugzilla/>
References:  <bug-204725-13@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=204725

--- Comment #1 from John Marino <marino@FreeBSD.org> ---
The sequence "clean patch makepatch" is wrong.  There's a post-patch target
that would affect the patches, so it should be "clean extract do-patch
makepatch"

There's a series of "locale: 2: bad variable name" messages that block most of
the regenerations.  Those would only appear on multipatch files.  I'll take a
look at the awk logic to see if there's an issue there.

I'm not seeing your "false positives".  It just failed to regenerate 8 of the 9
patches, so there's no point in even trying patch(1). 


It does say in the comments of makepatch that garbage in hunks can confuse it,
but I don't think that's what is going on here.

-- 
You are receiving this mail because:
You are on the CC list for the bug.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-204725-13-i9GxoHNR4c>