Date: Fri, 23 Feb 2024 17:37:32 +0000 From: bugzilla-noreply@freebsd.org To: gnome@FreeBSD.org Subject: [Bug 257255] graphics/rawtherapee: Crashes in rtengine::Color::rgb2lab01 when editing a picture; nullptr dereference related to color profile Message-ID: <bug-257255-6497-B6xWI8ue7i@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-257255-6497@https.bugs.freebsd.org/bugzilla/> References: <bug-257255-6497@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D257255 --- Comment #32 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=3D7e027ece12342fab2bd29ce325c4a61= 09677ae8a commit 7e027ece12342fab2bd29ce325c4a6109677ae8a Author: Matthias Andree <mandree@FreeBSD.org> AuthorDate: 2024-02-20 23:24:23 +0000 Commit: Matthias Andree <mandree@FreeBSD.org> CommitDate: 2024-02-23 17:37:09 +0000 graphics/rawtherapee: update to 5.10 ChangeLog: https://rawtherapee.com/downloads/5.10/#new-features We need to stick to GCC because LLVM-compiled code may take more than twice as much processing time as GCC-compiled does, for my test set comparing a few images with denoising and stuff on FreeBSD-14.0-RELEASE amd64 comparing GCC 12.3 to clang 16.0, and similar values on FreeBSD-13.2-RELEASE. Pin GCC to 12 and override -stdlib accordingly, to fix PR: 273682 Clean up Makefile a bit, but we cannot let go of the CCACHE workarounds yet, which we need when enforcing GCC compile. Convert some .if branches to options helpers. Make LTO an option that defaults to on. For some strange reason, massively-parallel compilation WITHOUT LTO appears to trigger OOM kills much more than an LTO-enabled build. Upstream states that LTO build should run faster. For one self-test that fails frequently with SIGPIPE (Exit code 141 is 128 for core dump + 13 for SIGPIPE), pipe through dd with bigger input buffer to avoid SIGPIPE/exit code 141 test failures. Replace echo by ${ECHO_CMD} in self-tests to appease portlint. Portlint misdetects "file system" as bare use of file though and suggests ${FILE}, which is wrong. Revise warnings around the CCACHE hacks because https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D277204 strives to move ports to CCACHE_ENABLED, which does not work for this port. Also, 5.10 should fix the profile/locale related crash PR: 257255 by switching the std::map variable to use std::string as index, rather than Glib::ustring, which caused inconsistencies with locales. Upstream references (two bug reports, and the fix, in order): https://github.com/Beep6581/RawTherapee/issues/6357 https://github.com/Beep6581/RawTherapee/issues/6876 =20=20=20 https://github.com/Beep6581/RawTherapee/pull/6889/commits/a95a58a8a399173e6= 947ff12a4b82b5d83ae80d9 graphics/rawtherapee/Makefile | 88 +++++++++++++++++++++-----------------= ---- graphics/rawtherapee/distinfo | 6 +-- graphics/rawtherapee/pkg-plist | 20 ++++++++++ 3 files changed, 68 insertions(+), 46 deletions(-) --=20 You are receiving this mail because: You are on the CC list for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-257255-6497-B6xWI8ue7i>