From owner-svn-src-all@freebsd.org  Mon Aug 31 08:50:45 2015
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8A4059C622B;
 Mon, 31 Aug 2015 08:50:45 +0000 (UTC)
 (envelope-from adrian.chadd@gmail.com)
Received: from mail-ig0-x235.google.com (mail-ig0-x235.google.com
 [IPv6:2607:f8b0:4001:c05::235])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 56E03164F;
 Mon, 31 Aug 2015 08:50:45 +0000 (UTC)
 (envelope-from adrian.chadd@gmail.com)
Received: by igui7 with SMTP id i7so50284711igu.0;
 Mon, 31 Aug 2015 01:50:44 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:sender:in-reply-to:references:date:message-id:subject
 :from:to:cc:content-type;
 bh=nQii4d3TfSRfobucyfpCKydbWgDS6YfCr4FMWCwIHeM=;
 b=iOKoRhZWUEN3E+kFsEldQdrfElDCbmtmZVIo58bgby2uKn8IFjyX+gb9elZn53DuZl
 DncbzREvobyD5OolmeCpcYAGIhg3xPnMOJVdRAX8gvOsWCrxW9ucJ32C1wGe7B5EzAi4
 sAt7qEw5ekzengGT/eMnQo/3XXwc2TYgca8xKztyDnrOWg0Ee9g14LRwrm25QuIqb8gC
 AX7YN0+fa7YX9tmYfPqWnQ5HJRF9UsxCo+I7n2oqc9p2XLijKJAksVLalteYRoolCNOL
 tNuS6uQ3yoBG5ey1/LMH0XoeuEbjJ9jf0rsv1Fv3OKLdwWoNbi00/bRK4MLiWmlb4n/M
 1Daw==
MIME-Version: 1.0
X-Received: by 10.50.43.227 with SMTP id z3mr12420505igl.22.1441011044719;
 Mon, 31 Aug 2015 01:50:44 -0700 (PDT)
Sender: adrian.chadd@gmail.com
Received: by 10.36.28.208 with HTTP; Mon, 31 Aug 2015 01:50:44 -0700 (PDT)
In-Reply-To: <20150831084333.GP2072@kib.kiev.ua>
References: <201508302154.t7ULsXaT070453@repo.freebsd.org>
 <20150831084333.GP2072@kib.kiev.ua>
Date: Mon, 31 Aug 2015 01:50:44 -0700
X-Google-Sender-Auth: Wkm8fk9aINt-wCcevzUwJ_lsSpQ
Message-ID: <CAJ-Vmom5DuL9+6+Eosii+_uuSxLJFoTGxJEnRBhGOS4=Bm6pbw@mail.gmail.com>
Subject: Re: svn commit: r287312 - head/sys/dev/iwn
From: Adrian Chadd <adrian@freebsd.org>
To: Konstantin Belousov <kostikbel@gmail.com>
Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, 
 "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, 
 "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>
Content-Type: text/plain; charset=UTF-8
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 31 Aug 2015 08:50:45 -0000

On 31 August 2015 at 01:43, Konstantin Belousov <kostikbel@gmail.com> wrote:
> On Sun, Aug 30, 2015 at 09:54:33PM +0000, Adrian Chadd wrote:
>>  static int
>> -iwn_ioctl(struct ieee80211com *ic, u_long cmd, void *data)
>> +iwn_cdev_open(struct cdev *dev, int flags, int type, struct thread *td)
>>  {
>> -     struct ifreq *ifr = data;
>> -     struct iwn_softc *sc = ic->ic_softc;
>> -     int error = 0;
>> -
>> +
>> +     return (0);
>> +}
>> +
>> +static int
>> +iwn_cdev_close(struct cdev *dev, int flags, int type, struct thread *td)
>> +{
>> +
>> +     return (0);
>> +}
>
> devfs does the right thing for drivers which does not provide d_open and
> d_close methods, these empty stubs are not needed.

I'll remove them tomorrow. I copied off of cxgbe, which does this.

Thanks!


-adrian