From owner-svn-ports-all@freebsd.org Tue Jul 2 08:35:18 2019 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E36BB15CC9B8; Tue, 2 Jul 2019 08:35:17 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 81B45745BE; Tue, 2 Jul 2019 08:35:17 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: from ivaldir.etoilebsd.net (etoilebsd.net [178.32.217.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: bapt) by smtp.freebsd.org (Postfix) with ESMTPSA id 4E27E1B00C; Tue, 2 Jul 2019 08:35:17 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: by ivaldir.etoilebsd.net (Postfix, from userid 1001) id E3F25B94E6; Tue, 2 Jul 2019 10:35:15 +0200 (CEST) Date: Tue, 2 Jul 2019 10:35:15 +0200 From: Baptiste Daroussin To: Alexey Dokuchaev Cc: Piotr Kubaj , Greg Lewis , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r505640 - head/java/openjdk11 Message-ID: <20190702083515.seykaqqjd77zyyr2@ivaldir.net> References: <201907012118.x61LIIQr011692@repo.freebsd.org> <20190702072450.GA17073@KGPE-D16> <20190702082607.GA45590@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="uk5b2jjnfovgbblk" Content-Disposition: inline In-Reply-To: <20190702082607.GA45590@FreeBSD.org> User-Agent: NeoMutt/20180716 X-Rspamd-Queue-Id: 81B45745BE X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.99 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.99)[-0.989,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Jul 2019 08:35:18 -0000 --uk5b2jjnfovgbblk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 02, 2019 at 08:26:08AM +0000, Alexey Dokuchaev wrote: > On Tue, Jul 02, 2019 at 09:24:50AM +0200, Piotr Kubaj wrote: > > Why not use USES=3Dcompiler:c11 instead of setting manually USE_GCC=3Dy= es? >=20 > Technically they're semantically not the same; while pulling C11-capable > compiler might fix the problem, you're still telling the reader that you'= re > pulling C11-capable compiler, while USE_GCC means that you want GCC, devo= id > of particular reasons. >=20 > In practice, compiler:c11 often used as compiler:modern. I'd welcome this > spelling: it would actually make things more clear because now people oft= en > abuse compiler:c11 or (even worse) compiler:c++11-lang for 98/99 code whi= ch > gcc-4.2 cannot eat, or because one of the dependencies requires new compi= ler > (majority of cases). >=20 > ./danfe >=20 > P.S. Sorry for lack of context due to prior top-posting. >=20 Actually the majority of addition of compiler:c11 are wrong (from the one I= have been able to check) and a simple USE_CSTD=3Dc99 would have fix the build wi= th gcc-4.2. It would be really nice to stop blindy using compiler:c11 ;) actually USE_GCC in this case is wrong as well, because if one day powerpc64 works with llvm/clang, then this will be broken. One has to identify what is really making it inconcompatible with gcc-4.2, without checking it should be mostly related to c++ (as the jvm is mostly written in c++) and if it is be= cause it uses "modern" c++ then any of the compiler:c++* is supposed to be the pr= oper thing to add. Best regards, Bapt --uk5b2jjnfovgbblk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEgOTj3suS2urGXVU3Y4mL3PG3PloFAl0bFygACgkQY4mL3PG3 Plr/cQ//QKOpawpsV1Diy1bdF1WQPCjHwJb98Jo+1Up9HxT/17oRKwtGLKqNXJnj L83e1Si9sirfP8J3FIEwhJSomZTkfvmagVa7bjAZd+RgDwO6LJyZ2P3V9LqA1C+m nOS8F8Q83eywxCFlYRk34jMPcRrgoiSULLzWzZVhnggfqpiO2w5BGU3slGKgzF4v d0yRp6oe059qINwZx23XEKPP+4Ow0qWjX5rP9S67KtZ2ZSRhioa+Zk6WQqj6sFnX YI7L2D6KxMNJHtwWd3XSzEF6A+gQBCxUnk0Cy2XtAEhvbTvaoBTu6Qhm3SxBuAeV 71NsmeiTCYmaBzzw/FcJ9QVJkhlVTqhsgnPPhCb33kMdjcofaVJ6p+xyOluvh4jk dRH1RolIaEnRM909ESPdQaF0sDtYR7J7/p5PeO1aBPB908nTwArsrnn2lyk7TY3F 37drrwkd6Ac5EYgrJjOEi33besA0EpG5JDurljppDE1B4tSL4jk4aqFr2T/78EGL W7eSSDESVRTrzcIhkO+SoPngifMVgvUxcyeVSaQ3Lqf8j81H9qcdhm7JdqN+Xg7m B1hyAD4hjlI/fKHnluOydzeRE62TgTxyqSdrb11zWVYafiiir+l5JZ7sIlUTKrRw dMjxgqIMT+o9CJ3k4QLUz0Z+gRlkRqf1JfcqdCQMgww5eQ4nCJw= =a97E -----END PGP SIGNATURE----- --uk5b2jjnfovgbblk--