Date: Thu, 18 Sep 2014 13:31:29 -0400 From: Adam Weinberger <adamw@adamw.org> To: Matthias Andree <mandree@FreeBSD.org> Cc: svn-ports-head@freebsd.org, Antoine Brodin <antoine@FreeBSD.org>, svn-ports-all@freebsd.org, marino@freebsd.org, ports-committers@freebsd.org, Bryan Drewery <bdrewery@FreeBSD.org> Subject: Re: svn commit: r367783 - head Message-ID: <2A60E3BE-1EE5-47BC-A4CB-6E39C57AB081@adamw.org> In-Reply-To: <541AF723.1000507@FreeBSD.org> References: <201409092112.s89LCtUa094817@svn.freebsd.org> <540F6E85.2050105@marino.st> <540F70A7.6030904@FreeBSD.org> <540F74AB.3020605@marino.st> <541AF723.1000507@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 18 Sep, 2014, at 11:15, Matthias Andree <mandree@FreeBSD.org> wrote: > Am 09.09.2014 um 23:44 schrieb John Marino: >> On 9/9/2014 23:27, Bryan Drewery wrote: >>> On 9/9/2014 4:17 PM, John Marino wrote: >>> I understand your reaction, but it's just the longstanding = convention. I >>> find it a bit rude too, but it speaks to the quality we expect of = each >>> other. Had this all not been fixed quickly we would not have = packages >>> this week. >>=20 >> The pointy hat was on the MOVED entry although I guess I deserve one = for >> removing the port in the first place. >>=20 >> The convention is not cool. I say it's time to retire this = tradition. >> If one really wants to make a point, send a private email. Have some >> class, this is just rubbing a mistake in somebody's face. This does = not >> make somebody's work better since they'll know about the error when = they >> see the commit. >=20 > I'd cast a ballot with the same mark as John's here. >=20 > Sometimes I'm lazy and mingle some things in one message with a = broader > distribution list, but guilt assignments don't get us anywhere. >=20 > What we COULD do is add a >=20 > Regression: <SVN revision>[, <SVN revision> [...]] >=20 > field and let the system look up whose commit caused the regressions = and > add them to the Cc: or Bcc: (to be discussed). That way we clearly = get > people on the hook without pointing fingers in public. Folks, please remember to be nice. Commit messages are written in ink, = so don=92t use =93Pointy hat:=94 unless it=92s in a good-natured manner, = and you=92re positive the subject will find it funny. Thinly veiling the blame game by calling people out by $Revision$ is not = progress. We don=92t need to =93get people on the hook,=94 we need to = ssh freefall.freebsd.org "cat /etc/motd|tail -2" # Adam --=20 Adam Weinberger adamw@adamw.org http://www.adamw.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2A60E3BE-1EE5-47BC-A4CB-6E39C57AB081>