From owner-svn-src-all@freebsd.org Fri Apr 15 03:10:06 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7B5ECAEC7FD; Fri, 15 Apr 2016 03:10:06 +0000 (UTC) (envelope-from imp@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 0A57C166A; Fri, 15 Apr 2016 03:10:05 +0000 (UTC) (envelope-from imp@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id u3F3A5t1047822; Fri, 15 Apr 2016 03:10:05 GMT (envelope-from imp@FreeBSD.org) Received: (from imp@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id u3F3A5Wj047821; Fri, 15 Apr 2016 03:10:05 GMT (envelope-from imp@FreeBSD.org) Message-Id: <201604150310.u3F3A5Wj047821@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: imp set sender to imp@FreeBSD.org using -f From: Warner Losh Date: Fri, 15 Apr 2016 03:10:05 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r298027 - head/sys/cam/ata X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Apr 2016 03:10:06 -0000 Author: imp Date: Fri Apr 15 03:10:04 2016 New Revision: 298027 URL: https://svnweb.freebsd.org/changeset/base/298027 Log: Add FCCT M500 to the NCQ black list. Linux added it in 4.2 (August 2015). Correct the M500 firmware versions. EU07 was the engineering test version, not the release version with the fix. MU07 is the release version. It's the only Micron firmware version to actually work. Remove support for EU07. This brings the blacklist into parity with the Linux blacklist as of 4.5, except for the Micron M500 MU07 entry. I personally tested the MU07 firmware on 12 machines running 6 drives each with no corruption in the past 6 months with Netflix production loads. Prior versions of the M500 firmware wouldn't last more than a few days. Sponsored by: Netflix, Inc. Modified: head/sys/cam/ata/ata_da.c Modified: head/sys/cam/ata/ata_da.c ============================================================================== --- head/sys/cam/ata/ata_da.c Fri Apr 15 03:09:58 2016 (r298026) +++ head/sys/cam/ata/ata_da.c Fri Apr 15 03:10:04 2016 (r298027) @@ -361,10 +361,10 @@ static struct ada_quirk_entry ada_quirk_ }, { /* - * Crucial M500 SSDs EU07 firmware - * NCQ Trim works ? + * Crucial M500 SSDs MU07 firmware + * NCQ Trim works */ - { T_DIRECT, SIP_MEDIA_FIXED, "*", "Crucial CT*M500*", "EU07" }, + { T_DIRECT, SIP_MEDIA_FIXED, "*", "Crucial CT*M500*", "MU07" }, /*quirks*/0 }, { @@ -401,6 +401,14 @@ static struct ada_quirk_entry ada_quirk_ }, { /* + * FCCT M500 SSDs + * NCQ Trim doesn't work + */ + { T_DIRECT, SIP_MEDIA_FIXED, "*", "FCCT*M500*", "*" }, + /*quirks*/ADA_Q_NCQ_TRIM_BROKEN + }, + { + /* * Intel 320 Series SSDs * 4k optimised & trim only works in 4k requests + 4k aligned */ @@ -465,10 +473,10 @@ static struct ada_quirk_entry ada_quirk_ }, { /* - * Micron M500 SSDs firmware EU07 + * Micron M500 SSDs firmware MU07 * NCQ Trim works? */ - { T_DIRECT, SIP_MEDIA_FIXED, "*", "Micron M500*", "EU07" }, + { T_DIRECT, SIP_MEDIA_FIXED, "*", "Micron M500*", "MU07" }, /*quirks*/0 }, {