From owner-svn-src-all@FreeBSD.ORG  Sat Jul 26 14:33:04 2014
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 6DA7D273;
 Sat, 26 Jul 2014 14:33:04 +0000 (UTC)
Received: from mail-oi0-x229.google.com (mail-oi0-x229.google.com
 [IPv6:2607:f8b0:4003:c06::229])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 12BAC2122;
 Sat, 26 Jul 2014 14:33:03 +0000 (UTC)
Received: by mail-oi0-f41.google.com with SMTP id a141so4363243oig.14
 for <multiple recipients>; Sat, 26 Jul 2014 07:33:03 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:in-reply-to:references:date:message-id:subject:from:to
 :cc:content-type;
 bh=Tx7H2BE2+MQIhhPeau+5DAup0nPZR/NSHJZthZmsVtE=;
 b=PznMtdSBR6EVHOpD1I6jzr+M4LI5n3zFl8xoqtM3UxJ2KZ6yRW6j0LF13+eLNJsmtG
 7CR75MP+hphGtXG6NDyZTUZtt6SxS+A3r0QfvPFmm1Ph+vqflcnShoGO1rbw3C5aegPo
 A/tJFFyWyp2e97a5af6sT+9MlWXmYmOOUVn13wdB3/vXOaObwpDtZLnASrna3vQ9Jc5B
 yRXDufHGheqBM5j7gUw9WyealP74leAOv+Zqz84wa8rjvjcTlbn9/8e0OA28BZk8e71A
 amVYQZepwDAFCE0D5Bdb120DxqmGxta0uuEZw+CpTw6k8gqqtWwZUDaYlATb+Qreq8y9
 hC9w==
MIME-Version: 1.0
X-Received: by 10.60.34.225 with SMTP id c1mr32352572oej.14.1406385183132;
 Sat, 26 Jul 2014 07:33:03 -0700 (PDT)
Received: by 10.182.142.34 with HTTP; Sat, 26 Jul 2014 07:33:03 -0700 (PDT)
In-Reply-To: <201407260409.s6Q49i20065578@svn.freebsd.org>
References: <201407260409.s6Q49i20065578@svn.freebsd.org>
Date: Sat, 26 Jul 2014 10:33:03 -0400
Message-ID: <CAJ5_RoBe-NWuxUgefoLvOCshe_HoYsekcHNpuyOGxh5g+T4YLg@mail.gmail.com>
Subject: Re: svn commit: r269112 - head/sys/boot/arm/at91/boot2
From: Benjamin Kaduk <bjkfbsd@gmail.com>
To: Ian Lepore <ian@freebsd.org>
Content-Type: text/plain; charset=UTF-8
X-Content-Filtered-By: Mailman/MimeDel 2.1.18
Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>,
 "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>,
 "src-committers@freebsd.org" <src-committers@freebsd.org>
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 26 Jul 2014 14:33:04 -0000

On Sat, Jul 26, 2014 at 12:09 AM, Ian Lepore <ian@freebsd.org> wrote:

> Author: ian
> Date: Sat Jul 26 04:09:43 2014
> New Revision: 269112
> URL: http://svnweb.freebsd.org/changeset/base/269112
>
> Log:
>   The 'flags' variable is conflicting with some inline code in a header
> file
>   ("variable flags shadows a global..."), just rename this variable to
>   wish away the problem.
>

Not trying to pick on you, but we have lots of places where we get
"variable <foo> shadows a global..." -- we have a global variable 'buf' in
the kernel namespace, for one :)
Do we think it's a good use of our time to try and get this to zero
instances?

-Ben