Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 3 Aug 2009 13:05:25 -0400
From:      John Baldwin <jhb@freebsd.org>
To:        freebsd-current@freebsd.org
Cc:        Julian Elischer <julian@elischer.org>, FreeBSD Current <current@freebsd.org>
Subject:   Re: possible readability improvement for i386 pcpu macros:
Message-ID:  <200908031305.25714.jhb@freebsd.org>
In-Reply-To: <4A75691E.9070401@elischer.org>
References:  <4A75691E.9070401@elischer.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sunday 02 August 2009 6:23:26 am Julian Elischer wrote:
> 
> if you have to ever look at the output of the cpp then this removes a 
> number of things you have to puzzle over in the output of PCPU_SET()
> and friends.
> 
> 
> I don't know if it applies to the other architectures.

It probably applies to amd64.  Also, simplifying the amount of code the macros 
generate can reduce compile time.  That is why Peter added __curthread() so 
that all the curthread references did not have to compile a fully expanded 
PCPU_GET() macro each time.  It gave a noticable reduction in kernel compile 
time.

-- 
John Baldwin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200908031305.25714.jhb>