Date: Fri, 21 Mar 2014 15:37:48 +0800 From: Kevin Lo <kevlo@FreeBSD.org> To: Joe Nosay <superbisquit@gmail.com> Cc: FreeBSD Hackers <freebsd-hackers@freebsd.org>, Adrian Chadd <adrian@freebsd.org> Subject: Re: Definition struct and int Message-ID: <532BEC4C.6080201@FreeBSD.org> In-Reply-To: <CA%2BWntOtiKCJB9ggY48RwYyYFqtL9gAqyG%2BvT6tjfPVCTdJ375Q@mail.gmail.com> References: <CA%2BWntOtT_SfQ4KRLyaWSQ8g-kkq3P7-YkJR7siqUZYAb-WtYTQ@mail.gmail.com> <CAJ-Vmok5RTi8SSm3PMXSYDpWonO3O%2BLetvH8ZaPzb66OD61S1A@mail.gmail.com> <CA%2BWntOufKY=7ikh2rNfXbxSKHW=WWKiW9iNXJOwZ%2Bar5GzXa9A@mail.gmail.com> <CA%2BWntOtsBu=1n134r6Te2kVQ4B=o%2BBzmTcKodxHdGEOwSChi9w@mail.gmail.com> <CA%2BWntOvLHYAxp5_s%2BCrWnQSy5H=G_p07WMRZn-=77Dx2kecr0g@mail.gmail.com> <53269B0E.5020904@FreeBSD.org> <CA%2BWntOtiKCJB9ggY48RwYyYFqtL9gAqyG%2BvT6tjfPVCTdJ375Q@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2014/03/18 08:05, Joe Nosay wrote: > On Mon, Mar 17, 2014 at 2:49 AM, Kevin Lo <kevlo@freebsd.org> wrote: > >> On 2014/03/17 14:07, Joe Nosay wrote: >> >>> On Sun, Mar 16, 2014 at 1:07 AM, Joe Nosay <superbisquit@gmail.com> >>> wrote: >>> >>> >>>> On Fri, Mar 14, 2014 at 5:43 PM, Joe Nosay <superbisquit@gmail.com> >>>> wrote: >>>> >>>> >>>>> On Thu, Mar 13, 2014 at 9:26 PM, Adrian Chadd <adrian@freebsd.org> >>>>> wrote: >>>>> >>>>> Is this -HEAD, or? >>>>>> >>>>>> -a >>>>>> >>>>>> >>>>>> On 13 March 2014 18:13, Joe Nosay <superbisquit@gmail.com> wrote: >>>>>> >>>>>>> Testing of a patch for using UDP Lite on FreeBSD caused no compilation >>>>>>> errors; however, after adding the options of "VIMAGE" and "MROUTING" >>>>>>> to >>>>>>> conf/kern?GENERIC, make buildkernel stops with: >>>>>>> /usr/src/sys/netinet/udp_usrreq.c:1701:18: error: too few arguments >>>>>>> to >>>>>>> function >>>>>>> call, expected 2, have 1 >>>>>>> udp_discardcb(up); >>>>>>> ~~~~~~~~~~~~~ ^ >>>>>>> /usr/src/sys/netinet/udp_usrreq.c:274:1: note: 'udp_discardcb' >>>>>>> >>>>>> declared here >>>>>> >>>>>>> void >>>>>>> ^ >>>>>>> 1 error generated. >>>>>>> *** Error code 1 >>>>>>> >>>>>>> The file in question of >>>>>>> /usr/src/sys/netinet/udp_usrreq.c >>>>>>> >>>>>>> has the value of >>>>>>> udp_discardcb(struct udpcb *up, int isudp) >>>>>>> >>>>>>> that is causing the problem. >>>>>>> >>>>>>> >>>>>>> >>>>>>> I believe that the compiler is looking for a value to int isudp but >>>>>>> >>>>>> that >>>>>> >>>>>>> value does not exist. >>>>>>> _______________________________________________ >>>>>>> freebsd-hackers@freebsd.org mailing list >>>>>>> http://lists.freebsd.org/mailman/listinfo/freebsd-hackers >>>>>>> To unsubscribe, send any mail to " >>>>>>> >>>>>> freebsd-hackers-unsubscribe@freebsd.org" >>>>>> >>>>>> >>>>> No, it is 10.0 RELEASE #0 r262601 >>>>> >>>>> Last time, I had entered too many files. Here are the relative files. >>>>> >>>>> >>>>> There was no problem in compiling as listed earlier. I have not >>>>> studied >>>>> C enough to solve this problem; however, I can see that int isudp >>>>> happens >>>>> once while the next closest account is int isudplite. >>>>> >>>>> >>>>> I've just upgraded source to head. I have three patches for UDP Lite. >>>> The >>>> question is which one(s) should I use. >>>> >>>> The udp-v.diff only has a reference to udp_discardcb up, while patch >>>> udplite and udplite.diff have the struct and int references. >>>> >>>> >>>> Could someone possibly point me towards some online documentation that >>> would allow me to learn of a solution to this problem? This would be much >>> better because I would be solving and learning. >>> >>> Included are the three patches mentioned earlier. >>> >>> Yes, I will be looking at them again. >>> >>> Apologies for any noise and if I am coming off the wrong way. >>> >> Hi Joe, >> >> As I mentioned, my udp-lite's diff no longer applies cleanly against >> -HEAD. I've been busy lately and haven't got time to reply to your >> messages. >> Give me another day or two to cook up a revised patch for you to test. >> Thanks! >> >> Kevin >> > > Alright. The revised patch is available at: http://people.freebsd.org/~kevlo/udplite.diff Kevin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?532BEC4C.6080201>