Date: Thu, 11 Jul 2013 07:50:00 -0500 From: Mark Linimon <linimon@lonesome.com> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, William Grzybowski <wg@FreeBSD.org>, ports-committers@freebsd.org Subject: Re: svn commit: r322724 - head/net-p2p/qbittorrent Message-ID: <20130711125000.GA31005@lonesome.com> In-Reply-To: <20130711054533.GA70334@FreeBSD.org> References: <201307101754.r6AHshZl027414@svn.freebsd.org> <20130711054533.GA70334@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jul 11, 2013 at 05:45:33AM +0000, Alexey Dokuchaev wrote: > 1) It gratuitously changes perfectly fine commas to (also perfectly fine > as it might seem) bars. Gratuitous commits should generally be avoided, as > they decrease STN ratio, and most importantly, they break 'svn blame'; This is exactly how I feel about non-code changes (e.g. whitespace, headers, formatting), and why I am in general against sweeps to implement such changes. mcl
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130711125000.GA31005>