From owner-svn-src-all@freebsd.org Thu Jun 9 12:49:52 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 688EEB6E7C5; Thu, 9 Jun 2016 12:49:52 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mail.blih.net (mail.blih.net [212.83.177.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.blih.net", Issuer "mail.blih.net" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 674F31684; Thu, 9 Jun 2016 12:49:51 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mail.blih.net (mail.blih.net [212.83.177.182]) by mail.blih.net (OpenSMTPD) with ESMTP id e7d5e33c; Thu, 9 Jun 2016 14:43:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=bidouilliste.com; h=date :from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; s=mail; bh=URpB82clsJ5C+P67mKFjRe1UiAQ=; b=Dgi9ZhucTNdzEiywP1B5y2Q9Cmik xL3FXxHd0G1GVuLRPIKxCWvi71t7hA7lBZ4bYC788L88cJ2JkZgF7P51PgpnJ5T1 Ao6QZXFufFsXV5iK0HzfVZUWf+df5NrpyVUgoQGA84lkK4mlsHRsp0hjCcbq92OU i+c+2vlaNh3Fxh8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=bidouilliste.com; h=date :from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; q=dns; s= mail; b=Ieds3hR0X5ly8GR57Nd23/4LYQJZyBXysumvNlA+7ESPPifJWDyDKdwB qkHjXERnRWT7Cg/WKdQHGT7HJNoyW9YNmeSJCSJ55Zq8BfHE8hmG/RpQAZZ5/+bY fAc3gYfMyciNAdj7eRiH/4ZBY6NBIfFUMD9mahZiN14NZvXqKxo= Received: from knuckles.blih.net (137.122.64.8 [137.122.64.8]) by mail.blih.net (OpenSMTPD) with ESMTPSA id 210e9768 TLS version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO; Thu, 9 Jun 2016 14:43:08 +0200 (CEST) Date: Thu, 9 Jun 2016 14:43:04 +0200 From: Emmanuel Vadot To: Warner Losh Cc: Emmanuel Vadot , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r301714 - head/sys/boot/efi/libefi Message-Id: <20160609144304.05437ef3d7f2fe9cd26704ac@bidouilliste.com> In-Reply-To: <90D3441D-D130-4D00-A12D-F4D3B81E606B@bsdimp.com> References: <201606090202.u5922pwl024436@repo.freebsd.org> <90D3441D-D130-4D00-A12D-F4D3B81E606B@bsdimp.com> X-Mailer: Sylpheed 3.5.0 (GTK+ 2.24.29; amd64-portbld-freebsd11.0) Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Jun 2016 12:49:52 -0000 I wanted to more verbose in case of the system don't have partition o n disk (or the EFI implementation only support raw disks like U-Boot) but this might be a bad way of doing saw, I didn't think about the implication you're talking about. I'll try to figure a better way to do this. On Wed, 8 Jun 2016 22:21:36 -0400 Warner Losh wrote: >=20 > > On Jun 8, 2016, at 10:02 PM, Emmanuel Vadot wrote: > >=20 > > Author: manu > > Date: Thu Jun 9 02:02:50 2016 > > New Revision: 301714 > > URL: https://svnweb.freebsd.org/changeset/base/301714 > >=20 > > Log: > > Print a message when the efi disk isn't a logical partition. >=20 > Why on earth would you do that? This will print a message, one per full d= isk, and our systems have 36 disks in them? > Please consider backing this out... >=20 > Warner >=20 >=20 > > Approved by: andrew (mentor) > > Differential Revision: https://reviews.freebsd.org/D6782 > >=20 > > Modified: > > head/sys/boot/efi/libefi/efipart.c > >=20 > > Modified: head/sys/boot/efi/libefi/efipart.c > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- head/sys/boot/efi/libefi/efipart.c Thu Jun 9 01:50:43 2016 (r30171= 3) > > +++ head/sys/boot/efi/libefi/efipart.c Thu Jun 9 02:02:50 2016 (r30171= 4) > > @@ -119,8 +119,11 @@ efipart_init(void)=20 > > (void**)&blkio); > > if (EFI_ERROR(status)) > > continue; > > - if (!blkio->Media->LogicalPartition) > > + if (!blkio->Media->LogicalPartition) { > > + printf("%s%d isn't a logical partition, skipping\n", > > + efipart_dev.dv_name, n); > > continue; > > + } > >=20 > > /* > > * If we come across a logical partition of subtype CDROM > >=20 --=20 Emmanuel Vadot