From owner-svn-src-all@freebsd.org Thu Jun 4 13:18:21 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id BF5682F2D08; Thu, 4 Jun 2020 13:18:21 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49d5v14c6Tz3WK6; Thu, 4 Jun 2020 13:18:21 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 994E420114; Thu, 4 Jun 2020 13:18:21 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id 054DILDA092214; Thu, 4 Jun 2020 13:18:21 GMT (envelope-from avg@FreeBSD.org) Received: (from avg@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id 054DILea092213; Thu, 4 Jun 2020 13:18:21 GMT (envelope-from avg@FreeBSD.org) Message-Id: <202006041318.054DILea092213@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: avg set sender to avg@FreeBSD.org using -f From: Andriy Gapon Date: Thu, 4 Jun 2020 13:18:21 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r361788 - head/sys/dev/superio X-SVN-Group: head X-SVN-Commit-Author: avg X-SVN-Commit-Paths: head/sys/dev/superio X-SVN-Commit-Revision: 361788 X-SVN-Commit-Repository: base MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Jun 2020 13:18:21 -0000 Author: avg Date: Thu Jun 4 13:18:21 2020 New Revision: 361788 URL: https://svnweb.freebsd.org/changeset/base/361788 Log: superio: do not assume that current LDN cannot change after config exit That assumption should be true when superio(4) uses the hardware exlusively. But it turns out to not hold on some real systems. So, err on the side of correctness rather than performance. Clear current_ldn in sio_conf_exit. Reported by: bz Tested by: bz MFC after: 1 week Modified: head/sys/dev/superio/superio.c Modified: head/sys/dev/superio/superio.c ============================================================================== --- head/sys/dev/superio/superio.c Thu Jun 4 13:06:49 2020 (r361787) +++ head/sys/dev/superio/superio.c Thu Jun 4 13:18:21 2020 (r361788) @@ -190,6 +190,7 @@ static void sio_conf_exit(struct siosc *sc) { sc->methods->exit(sc->io_res, sc->io_port); + sc->current_ldn = 0xff; mtx_unlock(&sc->conf_lock); }