Date: Sat, 07 Mar 2015 04:07:46 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 198379] net/liboping: Update to 1.8.0, Fix MASTER_SITES, WWW, Request MAINTAINER'ship Message-ID: <bug-198379-13-IDFZ3zTkhB@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-198379-13@https.bugs.freebsd.org/bugzilla/> References: <bug-198379-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=198379 --- Comment #2 from Kubilay Kocak <koobs@FreeBSD.org> --- Thanks Chris, On initial review: - COMMENT: Match upstream "tagline, comment" as close as possible. See: http://noping.cc/ COMMENT=C library to generate ICMP echo requests https://github.com/octo/liboping COMMENT=Protocol independent ANSI-C ping library and command line utility tldr; The original/previous value of COMMENT looks fine. - Always strip in post-install: - You're using INSTALL_TARGET=install-strip, but manual STRIP_CMD is still used? Use one or the other, ideally the former if it works. - You mention ncurses as an option, but there it doesn't look OPTION'al or conditional. - Try to use LIBS to add -lncurses instead of LDFLAGS - Dont hardcode -lncurses, use the variables provided by Mk/Uses/ncurses.mk - Group and sort USE_*/USES sections - When you update PORTVERSION, PORTREVISION is/should be reset (so remove it) -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-198379-13-IDFZ3zTkhB>