From owner-freebsd-ports-bugs@FreeBSD.ORG  Sat Mar  7 04:07:46 2015
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
Delivered-To: freebsd-ports-bugs@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id E9BD0E42
 for <freebsd-ports-bugs@FreeBSD.org>; Sat,  7 Mar 2015 04:07:46 +0000 (UTC)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id CECFD2AE
 for <freebsd-ports-bugs@FreeBSD.org>; Sat,  7 Mar 2015 04:07:46 +0000 (UTC)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t2747kh7045715
 for <freebsd-ports-bugs@FreeBSD.org>; Sat, 7 Mar 2015 04:07:46 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-ports-bugs@FreeBSD.org
Subject: [Bug 198379] net/liboping: Update to 1.8.0, Fix MASTER_SITES, WWW,
 Request MAINTAINER'ship
Date: Sat, 07 Mar 2015 04:07:46 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Ports & Packages
X-Bugzilla-Component: Individual Port(s)
X-Bugzilla-Version: Latest
X-Bugzilla-Keywords: patch, patch-ready
X-Bugzilla-Severity: Affects Only Me
X-Bugzilla-Who: koobs@FreeBSD.org
X-Bugzilla-Status: Open
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: maintainer-feedback?
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-198379-13-IDFZ3zTkhB@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-198379-13@https.bugs.freebsd.org/bugzilla/>
References: <bug-198379-13@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs/>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 07 Mar 2015 04:07:47 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=198379

--- Comment #2 from Kubilay Kocak <koobs@FreeBSD.org> ---
Thanks Chris,

On initial review:

- COMMENT: Match upstream "tagline, comment" as close as possible. See:

http://noping.cc/

COMMENT=C library to generate ICMP echo requests

https://github.com/octo/liboping

COMMENT=Protocol independent ANSI-C ping library and command line utility

tldr; The original/previous value of COMMENT looks fine.

- Always strip in post-install:
- You're using INSTALL_TARGET=install-strip, but manual STRIP_CMD is still
used? Use one or the other, ideally the former if it works.

- You mention ncurses as an option, but there it doesn't look OPTION'al or
conditional.
- Try to use LIBS to add -lncurses instead of LDFLAGS
- Dont hardcode -lncurses, use the variables provided by Mk/Uses/ncurses.mk

- Group and sort USE_*/USES sections

- When you update PORTVERSION, PORTREVISION is/should be reset (so remove it)

-- 
You are receiving this mail because:
You are the assignee for the bug.